All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Neal Kreitzinger" <neal@rsss.com>
To: git@vger.kernel.org
Subject: rebase -i reword converts to pick on pre-commit non-zero exit
Date: Wed, 1 Feb 2012 15:27:44 -0600	[thread overview]
Message-ID: <jgcaoh$d9q$1@dough.gmane.org> (raw)

When interactive rebase does the reword command it runs the pre-commit hook 
for that commit (a).  If the pre-commit hook gives a non-zero exit then 
interactive rebase picks commit (a) and continues to the next commit (b) in 
the rebase-to-do-list.  Instead of picking commit (a) when the pre-commit 
hook exits non-zero on the reword command, shouldn't interactive rebase 
learn to edit commit (a) and tell the user that because the pre-commit hook 
exited non-zero they need to either remedy the pre-commit hook violations 
and run git commit --amend or run git commit --amend --no-verify to bypass 
the pre-commit hook?  Otherwise, you have to run another rebase after the 
rejected rewords and edit those commits to accomplish the rewords.

v/r,
neal 

             reply	other threads:[~2012-02-01 21:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-01 21:27 Neal Kreitzinger [this message]
2012-02-01 21:28 ` rebase -i reword converts to pick on pre-commit non-zero exit Neal Kreitzinger
2012-02-02  4:12   ` Andrew Wong
2012-02-02 16:21     ` Neal Kreitzinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='jgcaoh$d9q$1@dough.gmane.org' \
    --to=neal@rsss.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.