From: Valentin Schneider <valentin.schneider@arm.com>
To: Juri Lelli <juri.lelli@redhat.com>
Cc: peterz@infradead.org, mingo@redhat.com,
linux-kernel@vger.kernel.org, bristot@redhat.com,
patrick.bellasi@matbug.net, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, chris.redpath@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de
Subject: Re: [PATCH] sched/features: Fix !CONFIG_JUMP_LABEL case
Date: Mon, 12 Oct 2020 11:40:10 +0100 [thread overview]
Message-ID: <jhj8scbenhx.mognet@arm.com> (raw)
In-Reply-To: <20201012053910.97010-1-juri.lelli@redhat.com>
Hi,
On 12/10/20 06:39, Juri Lelli wrote:
> Commit 765cc3a4b224e ("sched/core: Optimize sched_feat() for
> !CONFIG_SCHED_DEBUG builds") made sched features static for
> !CONFIG_SCHED_DEBUG configurations, but overlooked the CONFIG_
> SCHED_DEBUG enabled and !HAVE_JUMP_LABEL cases. For the latter, echoing
> changes to /sys/kernel/debug/sched_features has the nasty effect of
> effectively changing what sched_features reports, but without actually
> changing the scheduler behaviour (since different translation units get
> different sysctl_sched_features).
>
> Fix CONFIG_SCHED_DEBUG and !HAVE_JUMP_LABEL configurations by properly
> restructuring ifdefs.
>
That should be CONFIG_JUMP_LABEL, no? The HAVE stuff should've died with
e9666d10a567 ("jump_label: move 'asm goto' support test to Kconfig")
> Fixes: 765cc3a4b224e ("sched/core: Optimize sched_feat() for !CONFIG_SCHED_DEBUG builds")
> Co-developed-by: Daniel Bristot de Oliveira <bristot@redhat.com>
> Signed-off-by: Daniel Bristot de Oliveira <bristot@redhat.com>
> Signed-off-by: Juri Lelli <juri.lelli@redhat.com>
With the aforementioned replacement (changelog AND diff):
Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
prev parent reply other threads:[~2020-10-12 10:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 5:39 [PATCH] sched/features: Fix !CONFIG_JUMP_LABEL case Juri Lelli
2020-10-12 10:40 ` Valentin Schneider [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jhj8scbenhx.mognet@arm.com \
--to=valentin.schneider@arm.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=chris.redpath@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=patrick.bellasi@matbug.net \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.