All of lore.kernel.org
 help / color / mirror / Atom feed
From: Valentin Schneider <valentin.schneider@arm.com>
To: Thara Gopinath <thara.gopinath@linaro.org>
Cc: Russell King - ARM Linux admin <linux@armlinux.org.uk>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: v5.7: new core kernel option missing help text
Date: Thu, 04 Jun 2020 10:26:27 +0100	[thread overview]
Message-ID: <jhjeeqvi3m1.mognet@arm.com> (raw)
In-Reply-To: <a34fcb9a-ba4b-0c9e-328f-1244c2720ed2@linaro.org>


On 04/06/20 01:48, Thara Gopinath wrote:
> Hi Russel/Valentin
>
> The feature itself like Valentin explained below allows scheduler to be
> aware of cpu capacity reduced due to thermal throttling.
> arch_set_thermal_pressure feeds the capped capacity to the scheduler and
> hence the feature makes sense only if arch_set_thermal_pressure is
> implemented. Having said that arch_set_thermal_pressure is implemented
> in arch_topology driver for arm and arm64 platforms. But the feature
> itself is not bound to arm/arm64 platforms. So it would make it wrong to
> add a "depends on (ARM || ARM64) option."
>
> I agree with Vincent that allowing user to choose this option is
> probably not the best. IMO, this should be enabled by default in arm64
> defconfig considering both GENERIC_ARCH_TOPOLOGY and CPU_FREQ_THERMAL
> are enabled by default.

Right, I had skimmed over that but it probably does make more sense not
to bother users with it.

> So if it is acceptable three things to be done are:
> 1. Add the help text.
> 2. Don't allow SCHED_THERMAL_PRESSURE configurable by user
> 3. Enable it by default in arm64 defconfig

... and arm as well, I suppose?

  reply	other threads:[~2020-06-04  9:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03 17:31 v5.7: new core kernel option missing help text Russell King - ARM Linux admin
2020-06-03 18:00 ` Valentin Schneider
2020-06-03 18:45   ` Russell King - ARM Linux admin
2020-06-03 19:24     ` Vincent Guittot
2020-06-03 19:58       ` Russell King - ARM Linux admin
2020-06-03 20:22         ` Vincent Guittot
2020-06-03 20:25         ` Valentin Schneider
2020-06-04  0:48           ` Thara Gopinath
2020-06-04  9:26             ` Valentin Schneider [this message]
2020-06-04  9:29               ` Russell King - ARM Linux admin
2020-06-04 10:56                 ` Valentin Schneider
     [not found]                   ` <CALD-y_zQms4YQup2MgAfNhWSu=ewkhossHma2TKqfTcOFaG=uA@mail.gmail.com>
2020-06-04 15:38                     ` Valentin Schneider
2020-06-04 22:22                       ` Thara Gopinath
2020-06-05  7:03                       ` Vincent Guittot
2020-06-05  9:46                         ` Valentin Schneider
2020-06-05  8:15                       ` Russell King - ARM Linux admin
2020-06-05 10:02                         ` Valentin Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jhjeeqvi3m1.mognet@arm.com \
    --to=valentin.schneider@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=thara.gopinath@linaro.org \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.