From: Valentin Schneider <valentin.schneider@arm.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] sched/debug: Add new tracepoint to track cpu_capacity
Date: Thu, 27 Aug 2020 20:24:03 +0100 [thread overview]
Message-ID: <jhjsgc7optp.mognet@arm.com> (raw)
In-Reply-To: <202008280326.O6kOHfWU%lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 539 bytes --]
On 27/08/20 20:08, kernel test robot wrote:
> All errors (new ones prefixed by >>):
>
>>> kernel/sched/fair.c:11314:18: error: no member named 'cpu_capacity' in 'struct rq'
> return rq ? rq->cpu_capacity : -1;
> ~~ ^
> 1 error generated.
>
The joys of !SMP; you'll want to wrap this in an #ifdef CONFIG_SMP like
some of the other TP's. The !SMP case can probably return
SCHED_CAPACITY_SCALE for the sake of pedantism, AFAICT that TP can't fire
on !SMP (that, or only define it for SMP).
WARNING: multiple messages have this Message-ID (diff)
From: Valentin Schneider <valentin.schneider@arm.com>
To: kernel test robot <lkp@intel.com>
Cc: mingo@redhat.com, peterz@infradead.org,
vincent.guittot@linaro.org, kbuild-all@lists.01.org,
clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org,
dietmar.eggemann@arm.com, qais.yousef@arm.com,
Vincent Donnefort <vincent.donnefort@arm.com>
Subject: Re: [PATCH] sched/debug: Add new tracepoint to track cpu_capacity
Date: Thu, 27 Aug 2020 20:24:03 +0100 [thread overview]
Message-ID: <jhjsgc7optp.mognet@arm.com> (raw)
In-Reply-To: <202008280326.O6kOHfWU%lkp@intel.com>
On 27/08/20 20:08, kernel test robot wrote:
> All errors (new ones prefixed by >>):
>
>>> kernel/sched/fair.c:11314:18: error: no member named 'cpu_capacity' in 'struct rq'
> return rq ? rq->cpu_capacity : -1;
> ~~ ^
> 1 error generated.
>
The joys of !SMP; you'll want to wrap this in an #ifdef CONFIG_SMP like
some of the other TP's. The !SMP case can probably return
SCHED_CAPACITY_SCALE for the sake of pedantism, AFAICT that TP can't fire
on !SMP (that, or only define it for SMP).
next prev parent reply other threads:[~2020-08-27 19:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 15:35 [PATCH] sched/debug: Add new tracepoint to track cpu_capacity vincent.donnefort
2020-08-27 19:08 ` kernel test robot
2020-08-27 19:08 ` kernel test robot
2020-08-27 19:24 ` Valentin Schneider [this message]
2020-08-27 19:24 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jhjsgc7optp.mognet@arm.com \
--to=valentin.schneider@arm.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.