From: Valentin Schneider <valentin.schneider@arm.com>
To: "Li\, Aubrey" <aubrey.li@linux.intel.com>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
tim.c.chen@linux.intel.com, linux-kernel@vger.kernel.org,
Aubrey Li <aubrey.li@intel.com>,
Qais Yousef <qais.yousef@arm.com>,
Jiang Biao <benbjiang@gmail.com>
Subject: Re: [RFC PATCH v3] sched/fair: select idle cpu from idle cpumask for task wakeup
Date: Fri, 06 Nov 2020 21:22:36 +0000 [thread overview]
Message-ID: <jhjy2jexjs3.mognet@arm.com> (raw)
In-Reply-To: <27f88d6a-302e-2c28-c936-22ac233fe175@linux.intel.com>
On 04/11/20 11:52, Li, Aubrey wrote:
> On 2020/11/4 3:27, Valentin Schneider wrote:
>>> +static DEFINE_PER_CPU(bool, cpu_idle_state);
>>
>> I would've expected this to be far less compact than a cpumask, but that's
>> not the story readelf is telling me. Objdump tells me this is recouping
>> some of the padding in .data..percpu, at least with the arm64 defconfig.
>>
>> In any case this ought to be better wrt cacheline bouncing, which I suppose
>> is what we ultimately want here.
>
> Yes, every CPU has a byte, so it may not be less than a cpumask. Probably I can
> put it into struct rq, do you have any better suggestions?
>
Not really, I'm afraid.
next prev parent reply other threads:[~2020-11-06 21:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 15:03 [RFC PATCH v3] sched/fair: select idle cpu from idle cpumask for task wakeup Aubrey Li
2020-10-21 17:40 ` kernel test robot
2020-10-22 1:28 ` Li, Aubrey
2020-10-21 18:20 ` kernel test robot
2020-11-03 19:27 ` Valentin Schneider
2020-11-04 11:52 ` Li, Aubrey
2020-11-06 21:22 ` Valentin Schneider [this message]
2020-11-06 7:58 ` Vincent Guittot
2020-11-09 6:05 ` Li, Aubrey
2020-11-06 21:20 ` Valentin Schneider
2020-11-09 13:40 ` Li, Aubrey
2020-11-09 15:54 ` Valentin Schneider
2020-11-11 8:38 ` Li, Aubrey
2020-11-12 10:57 ` Qais Yousef
2020-11-12 12:12 ` Li, Aubrey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jhjy2jexjs3.mognet@arm.com \
--to=valentin.schneider@arm.com \
--cc=aubrey.li@intel.com \
--cc=aubrey.li@linux.intel.com \
--cc=benbjiang@gmail.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
--cc=rostedt@goodmis.org \
--cc=tim.c.chen@linux.intel.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.