All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] Combine bdrv_aio_readv and bdrv_aio_writev into bdrv_aio_rw_vector
Date: Wed, 29 Feb 2012 16:54:30 +0100	[thread overview]
Message-ID: <jilhnm$cv8$1@dough.gmane.org> (raw)
In-Reply-To: <1330473276-8975-3-git-send-email-mjt@msgid.tls.msk.ru>

Il 29/02/2012 00:54, Michael Tokarev ha scritto:
> iscsi block driver may receive some additional work.  For now, some
> common code has been moved out of iscsi_aio_writev() and iscsi_aio_readv()
> into iscsi_aio_rw_vector().  Leftovers there can be optimized further,
> and consolidated into the rw_vector too.  Read and write callbacks are
> consolidated as well, and once the XXX "todo" bounce-buffer change is
> complete the only difference there should go away too.

What about flush, discard, etc.?

It seems to me that either we make a single entry point that takes some
kind of BlockRequest, or there is no reason to do partial unification.

Paolo

  reply	other threads:[~2012-02-29 15:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1330473276-8975-1-git-send-email-mjt@tls.msk.ru>
2012-02-28 23:54 ` [Qemu-devel] [PATCH 1/3] Combine bdrv_read and bdrv_write to bdrv_rw Michael Tokarev
2012-02-29 15:53   ` Paolo Bonzini
2012-02-29 16:00     ` Michael Tokarev
2012-02-29 16:07       ` Paolo Bonzini
2012-02-29 16:36         ` Michael Tokarev
2012-02-28 23:54 ` [Qemu-devel] [PATCH 2/3] Combine bdrv_aio_readv and bdrv_aio_writev into bdrv_aio_rw_vector Michael Tokarev
2012-02-29 15:54   ` Paolo Bonzini [this message]
2012-02-29 16:16     ` Michael Tokarev
2012-02-28 23:54 ` [Qemu-devel] [PATCH 3/3] Combine bdrv_co_readv and bdrv_co_writev into bdrv_co_rw_vector Michael Tokarev
2012-02-29 16:01   ` Paolo Bonzini
2012-02-29 16:12     ` Michael Tokarev
2012-02-29 16:24       ` Paolo Bonzini
2012-02-29 16:45         ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='jilhnm$cv8$1@dough.gmane.org' \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.