From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from plane.gmane.org ([80.91.229.3]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1S9hyq-0001LK-IT for openembedded-devel@lists.openembedded.org; Mon, 19 Mar 2012 20:10:56 +0100 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1S9hqH-0006mD-LR for openembedded-devel@lists.openembedded.org; Mon, 19 Mar 2012 20:02:05 +0100 Received: from ip545070eb.adsl-surfen.hetnet.nl ([84.80.112.235]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 19 Mar 2012 20:02:05 +0100 Received: from koen by ip545070eb.adsl-surfen.hetnet.nl with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 19 Mar 2012 20:02:05 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: openembedded-devel@lists.openembedded.org From: Koen Kooi Date: Mon, 19 Mar 2012 20:01:55 +0100 Message-ID: References: <1332103254-3729-1-git-send-email-schnitzeltony@googlemail.com> Mime-Version: 1.0 X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: ip545070eb.adsl-surfen.hetnet.nl User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 In-Reply-To: X-Enigmail-Version: 1.3.5 Subject: Re: [meta-oe 1/6] mpd: initial add 0.16.7 X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Mar 2012 19:10:56 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Op 19-03-12 16:24, Andreas Müller schreef: > On Mon, Mar 19, 2012 at 1:54 PM, Koen Kooi > wrote: >>> +DESC="The Music Player Daemon" +DAEMON=/usr/bin/mpd >>> +MPDCONF=/etc/mpd.conf >> >> The above hardcodes $bindir and $sysconfdir, which it shouldn't do. > mpd.in + sed in V2. OK? sound good to me. >> Furthermore I'd like to stop maintaining our own initsystem in meta-oe >> and switch to upstream initscripts as much as possible > The package itself does not contain an initscript so I implemented it > close to that found in debian-lenny package. What upstream source do you > suggest (matching also above requirement not hardcoding paths)? > >> and include systemd units by default as well. > This requirement I did not know and did not find any source for that - > some suggestion? Fedora or arch should have one. > >> The above script is missing LSB headers as well. > This initscript as is does not need. AIUI OE-core requires lsb headers for all sysvinitscripts and systemd works a lot better when those headers are present as well. regards, Koen -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (Darwin) Comment: GPGTools - http://gpgtools.org iEYEARECAAYFAk9ngp8ACgkQMkyGM64RGpE97QCdFLCl80NB97Vug3qfiJladmA8 gGQAoIKOWTiq6QGM+mjqdJnAx+T7S1Q+ =okI0 -----END PGP SIGNATURE-----