From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mv1D7-0004zr-QJ for mharc-grub-devel@gnu.org; Wed, 08 Dec 2021 12:58:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mv1D5-0004zG-0y for grub-devel@gnu.org; Wed, 08 Dec 2021 12:58:32 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:38993) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mv1Cy-0003Oq-Vi for grub-devel@gnu.org; Wed, 08 Dec 2021 12:58:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638986303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OUil4i28ZaQH4tU9XdbEKObF3Fp/U/59cY7V+18wg6k=; b=ZNhweUh2Ohftr8enF5+4qEbRliafyjhhGfF4BQ4lPVUXGiLHm6TJ1F7+YKB285g1GhzXU2 JF4csdPRaVrNoNETR9I+mvh9zrmnpRGWHMh3oXVOgT8Py6Mr2Z/eoTfHpXWlx7424q26Y/ CT10DKjjIbR/9nYJRPRx3vwhwqek61A= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-400-oyfBuLOGN2KZ2EHE7EnPJQ-1; Wed, 08 Dec 2021 12:58:04 -0500 X-MC-Unique: oyfBuLOGN2KZ2EHE7EnPJQ-1 Received: by mail-qk1-f197.google.com with SMTP id bl6-20020a05620a1a8600b0046803c08cccso3991816qkb.15 for ; Wed, 08 Dec 2021 09:58:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=QIqhCqrEbZlm0eg+hk5m6QKYMS/XA4YA/OjSQv9BDtQ=; b=Rd1vJaavKEJeW+NlU+TLvOobp8ucn6VD+mAHn6D6uR4nlfYIHLC5qJ9XJ73syQ96Kg WG6QgNdZMyVBlsWzMUWuQDkKIOH3mApMl4Ipl+pjCulgF2HppYHiHNsNMz+NXfO6en6K EIkQcacUrCOpsI8CkD1T5YBZSlLbTKZRbXMVJ0uZMxEE0Yjt70WNOB7OynPnzsmEkvfP NHOk3BsR5CmlBPcgY4mcmL+1PLLwrgW7fZjztxlKyNTS6z6ud4jHbHQMaXx6DifXLdm8 sT9QDZavtKrgSMAnZicMwmSEovKK3nU3diSPMJWjQ1FG+JqltbRvpTU+/EV4pxWYZPQQ THIw== X-Gm-Message-State: AOAM530TG8zkyFFBYKWcrtljrF5tosWF5zI12yyvWc1cQC7W/dtNWW8u 4p85EaYkSWMT/6iKDgKKPu38LHPtoZEYBDv4WtZ4C5534Jo0zmSXvmta2+bGjWOeGme7ldfUGJa XTNWuG8a/rSA= X-Received: by 2002:a05:622a:192:: with SMTP id s18mr10713770qtw.6.1638986283385; Wed, 08 Dec 2021 09:58:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJx1u+vK/qLyvDZM7ErI1ScUZFV6c6Ul8wHvl82Q2B9iQ5kZjGE3wsYpVp9/89UH0sIuHd+gMA== X-Received: by 2002:a05:622a:192:: with SMTP id s18mr10713685qtw.6.1638986282652; Wed, 08 Dec 2021 09:58:02 -0800 (PST) Received: from localhost ([2601:184:4181:74c0:862e:5809:ed9e:e10e]) by smtp.gmail.com with ESMTPSA id a38sm1664098qkp.80.2021.12.08.09.58.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Dec 2021 09:58:02 -0800 (PST) From: Robbie Harwood To: Nicholas Vinson , grub-devel@gnu.org Subject: Re: [PATCH] Add Fedora location of DejaVu SANS font In-Reply-To: <4dff5c81-6efc-41b9-3ef6-52f63025ec9e@gmail.com> References: <20211206222542.20068-1-rharwood@redhat.com> <4dff5c81-6efc-41b9-3ef6-52f63025ec9e@gmail.com> Date: Wed, 08 Dec 2021 12:58:01 -0500 Message-ID: MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=rharwood@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=170.10.133.124; envelope-from=rharwood@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.619, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Dec 2021 17:58:32 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Nicholas Vinson writes: > On 12/7/21 15:04, Robbie Harwood wrote: >> Nicholas Vinson writes: >>=20 >>> Wouldn't it be better to modify configure.ac so the location could >>> be passed in instead of having one-off patches for alternate >>> locations? Something like >>> --with-dejavu-font=3D/usr/share/fonts/dejavu-sans-fonts? >>=20 >> That would mean that anyone using grub2 that wants the dejavu fonts >> will have to figure out that the option exists and pass it to the >> buildscripts. That's a pretty bad user experience for anyone >> building their own grub. > > On the contrary, it doesn't have to mean that at all. It could mean > that when a path is given, configure would use the provided path; > otherwise, it falls back to its default list to find the font. But then we still have to keep the default list... and I'd still be here as a distro maintainer wanting my distro's path in the default list. I don't see how this is any better. > Such an approach would mimic configure's current behavior for values > such as bootdir and grubdir. But those are *install* paths, not *detection* paths. We're not installing the font - we're figuring out where it is on the system. >> I get that maintaining a list of where everyone has put their fonts is >> somewhat obnoxious, but in the absence of a standard way of doing it, >> I'm not sure there's anything better. The only other alternative I > > See above and configure.ac's solutions to similar issues for better=20 > approaches. configure.ac is 2189 lines of code. You're going to have to be more specific :) Be well, --Robbie --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAmGw8ikUHHJoYXJ3b29k QHJlZGhhdC5jb20ACgkQJTL5F2qVpEIVVRAAhwp4E5okE40a/o9OyMg5rgkRcJin /VdgtuXv7skA0RyJFqATmVamQPi+jHEYsANuUdd8G3WJpbjVkb80q21J49EQ8W5X X0kOOud0o3zV0UTHRepNwVf99alJWIP4QRqNxnVdWrtWUX2lTYU4OMJEot9nIrfp qUIFR7nWZujoXnKfBNsV3e7vhCaCX8YuhIeQt4Ue7LFTQ/z6jJtPPd3KEuRAyBxv ivgzc/qAB8rcgqJ1frc4telZaWfZDt9iiSfLASKDqJLMKUEo126V8/CmcSATNxJM CoqFJSi7JP1n0/OM4NPpiHltYQQYvAAZ3iU27kLP9dwTqXRcpFhimrsXz5ffIn1g yLyEIhmsX5UKG+comdvFxI6ExV9xLngnreetkSUqe3kzP1OIvF/5X+uJ0MzOaARN CJA5WHSNsQAWu8Lln0QL4bjIBU9ti83qEczzZLcujTG/k9tADkDJQY+4FYhNrBun fVHh9NhGc1B9psYLUc384lnkcCUWHLT0wZN795++FRRTuRB9bpqqafqGFmxZM1cg ZnQTJGhyz+0c3t5i44iyMjAO75G+w1XGJZyH7sDI3Poka/RoY5kyZ0lnAwnA7f4+ qPspfPq18iGPi+UW0oWr8kZEk5Bv4Yw/OV+B6Q+HBtb/f/GHPTIxOReog2QdEW0W SR+j4CS+432Ddbk= =KoOv -----END PGP SIGNATURE----- --=-=-=--