From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nXmHf-0007Fp-4K for mharc-grub-devel@gnu.org; Fri, 25 Mar 2022 11:55:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXmHR-00078g-Nx for grub-devel@gnu.org; Fri, 25 Mar 2022 11:55:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:32914) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXmHM-0005Ck-Tu for grub-devel@gnu.org; Fri, 25 Mar 2022 11:55:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648223707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Sj2yN5VHvKvvxPdPGvyt/IB3Tm2Jh6pAOKPI3VUB6WU=; b=hSjAuVjxQgvSTnGRQ+WJxvIgO4Qrs6PnLhRdaB/fZCKX7Kg+NsG3OtCjkwp7UJMmOI8z6I Ly5J06NIuX0KEWMPoYHS4c4ZsWxWHnRmnxzAyOMSCA2n8TQvoaNDMo4lDSXc07VFighW1s jyMvLNkZ5IAPTCANOMZ5FIZYIIMqadM= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-653-uA_oeWjgOymST09e5U7YjQ-1; Fri, 25 Mar 2022 11:55:05 -0400 X-MC-Unique: uA_oeWjgOymST09e5U7YjQ-1 Received: by mail-qv1-f69.google.com with SMTP id z2-20020a056214060200b00440d1bc7815so6299167qvw.1 for ; Fri, 25 Mar 2022 08:55:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=Sj2yN5VHvKvvxPdPGvyt/IB3Tm2Jh6pAOKPI3VUB6WU=; b=ZFqLsr2aFOPwiI4CTzF1WdMAPs/kNceE5fP+pwiTc37mURUTbO9tnLYMJtbT4WiXC+ E0tRH2BYThjZrwnv1ENnxccJqU0ov4V75VgWheAuOMay80cMF4dJbhuTDqz1h7Ph5OaI 4UNnQFFuEEOCy87+6heuVrAOv7DqcJH6CIdVkBiUwN30iOqQO3S+I6NDmBlEn2F71+BI XWRk2ncBhmovPixQ7UhV9CYJsIVnBi9Hr7sxiKhpjcBWNuZBUxCRxTPmh8b3bjg3JeEw hIwrC1THAz2LjAxEy3efMBeWOKeEZFYsQrXuSrbnIBli/sQbArhEUNc19eorVNYyYZZu cl1Q== X-Gm-Message-State: AOAM533Xwfgpz1jZozckpoHkpQdAk+Y+kfBroSrxEigj4Y/Hb1Fu9MYw AiE+3ecq1P0ZIInD2bRyVUwuqTydE7h4oofpuwgkdTeL2i4ybe3Vc6BlN0M4tJKzGf+iwzza78X dNRBWElY1eTk= X-Received: by 2002:ad4:404b:0:b0:440:dee0:4ab3 with SMTP id r11-20020ad4404b000000b00440dee04ab3mr9489484qvp.129.1648223704405; Fri, 25 Mar 2022 08:55:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwmgd6agiB5QoxPWvmz+L3j8KEZ3XbEmb1PtC1kTITlQ90UBgXxNv2zRiE/ZyHhCfn/MAN58g== X-Received: by 2002:ad4:404b:0:b0:440:dee0:4ab3 with SMTP id r11-20020ad4404b000000b00440dee04ab3mr9489452qvp.129.1648223703787; Fri, 25 Mar 2022 08:55:03 -0700 (PDT) Received: from localhost ([2601:184:4181:74c0:862e:5809:ed9e:e10e]) by smtp.gmail.com with ESMTPSA id o13-20020ac87c4d000000b002e1e732dea5sm5394936qtv.70.2022.03.25.08.55.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 08:55:03 -0700 (PDT) From: Robbie Harwood To: Glenn Washburn , grub-devel@gnu.org, Daniel Kiper Cc: Glenn Washburn Subject: Re: [PATCH] configure: Fix default -O2 being added when CFLAGS not set In-Reply-To: <20220324223116.3222258-1-development@efficientek.com> References: <20220324223116.3222258-1-development@efficientek.com> Date: Fri, 25 Mar 2022 11:54:59 -0400 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=170.10.129.124; envelope-from=rharwood@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2022 15:55:20 -0000 --=-=-= Content-Type: text/plain Glenn Washburn writes: > Autoconf will set a default CFLAGS of "-g -O2" if CFLAGS is not set. CFLAGS > was defaulted to "" early in configure to prevent this. Apparently something > changed in autoconf and now AC_USE_SYSTEM_EXTENSIONS, which is before the > default setting of CFLAGS, will pull in this check. Move the default > setting of CFLAGS to before this so that if will see CFLAGS as set and not > give it a default. This is a result of ad9ccf660013c208077b1e983d6c824df25ed1cf ("configure: Fix various new autotools warnings"), which hoisted AC_USE_SYSTEM_EXTENSIONS to avoid a new warning (slightly too far, it seems). > Signed-off-by: Glenn Washburn Reviewed-by: Robbie Harwood Be well, --Robbie --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAmI95dMUHHJoYXJ3b29k QHJlZGhhdC5jb20ACgkQJTL5F2qVpEKqTQ/9FSysC0sggpiW5t1FaHRmX+7oqBbb r9SHNaVqbcFgvyzBcDv1dx0YHJ22Ztvc0qAra+h46NYHZAG9mIGO3aecFj1Zj0M6 GtyFRikKWCzJqA3wp13p8UlRpwbLs9I2vqcX8KaVICKyYUHfy41w/MFgE0nGWmId lrEGUbrC93J9E6X5aJ3WPaN2Zuj0WM6c0Sw4qGcKDWQRUmMwDGGSuxbOFYUr70aD /keJZq+0Ghhlhf0gojPc5Wc9a+cSg7nF3Qz7vXHS0QbCeluT+RtEL9RdtVdop/2r YWHW7hVXbb+ysffDad0g8B0fJOqdNjmfVpBBBXavgWpTU0AR4htIiJ6Koz1d4x/T zuLRQV7E0ltvefc0XinOB5zrVB5Mv05WsSvmZYCJqN8IEH3nqfBGooM/amiaH8Uh qUCZbdHmb7PcCfJ/QS0faoZduKUAzpH/L9P01cgFgd/Yymhvl4bs62XFaBQtYhV4 lCqz3nWsj2LJLV+og73yrL0iRpPCPUotvPs19VJqR9l9BOyu5hzktY1b4lHSPSEJ HYu4QN8JyyCB+6ZYayIV3lgShx9Br1vo22VTE/tePHRKC+/45iaYUG5fSb4lvXYS RKFeJL5tG+ZXivwvPcxZv8zqeYVGAFbwFBvE2K7kvKGB/idCXqoQA8HUI/QZjJbw wMC8jh/7tgZ+eWg= =GU+V -----END PGP SIGNATURE----- --=-=-=--