From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nSkMh-0003qy-O6 for mharc-grub-devel@gnu.org; Fri, 11 Mar 2022 13:51:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSkMf-0003hj-Gv for grub-devel@gnu.org; Fri, 11 Mar 2022 13:51:49 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:30548) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSkMY-0008CG-JS for grub-devel@gnu.org; Fri, 11 Mar 2022 13:51:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647024701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kfZzokXwIKxAIMGobktbHgV7BC+66W8A5Zv76R7mDFk=; b=WO06/lWHVb/fYsAjlenEZeu6IZt/FCHanx5RQFL5sMNugAfquPp5Cje6cS45HGw2VU1vDW gF8kdgxKzZvCwLnj7S5IuRPASDddFNgjFu8KmXIvky3K9/uzsz8pj7CnzXl4sHtbGluldF sLiDgxQq8vdB4PXcS0mSc1K5MBiYN2U= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-244-NWcQwPz6PayCAcPBKuiEvg-1; Fri, 11 Mar 2022 13:51:39 -0500 X-MC-Unique: NWcQwPz6PayCAcPBKuiEvg-1 Received: by mail-qk1-f197.google.com with SMTP id 195-20020a3707cc000000b0067b0c849285so6818821qkh.5 for ; Fri, 11 Mar 2022 10:51:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=kfZzokXwIKxAIMGobktbHgV7BC+66W8A5Zv76R7mDFk=; b=E46/EK/zhf8Hd8BsU9ElnJKAABojU1AEhJjMwjeuixrkDUbCdZUGabf3MzvLCRN3jF dXBGm8zkTBamY9Py8t5APA8fEswvwWWvtJK3ZW58Hto3za59iYule4AlYzMBt4Lml1up 62Kc1oEd1PxXtKbZXd2N5XDfsjSSIrcrtkKePfyDEUQm5mrzygw29Lx7Uy7DAnZTqgve sPKxTBNS2PeL+on2wREwPYY28Zc+frUwygFbYsEKqbT/xT6y4aYx1RTVOFjxn0hjCt6j jCebQ3ZWerflDMqhNR9uQ5oBE7/PbLtXT9tJW7S2B0O48kTBDj2TC4PJendoE63lSBsY NWFA== X-Gm-Message-State: AOAM533KOLBfif5RvV/Vi8USOL4EyZH0B5ujjIpPzLBKQfhHp9Hz6zBW DdDmH9G5oaWonXuQ+VmDrjDhQwnBZEFm+MkONSy2X62l8Kn9EoMhXq+r4LzTrOGZWugSHeb7KUR H3zMXpifkU4I= X-Received: by 2002:a05:620a:ccb:b0:67b:3191:c635 with SMTP id b11-20020a05620a0ccb00b0067b3191c635mr7282733qkj.285.1647024698729; Fri, 11 Mar 2022 10:51:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJwiWLlW4NeqWTVxxNq7cZHTqZA0fY2rydXJqq0r1JHu+P0gNiGwa2RmqS1ekYy9ZfwIuKrAFg== X-Received: by 2002:a05:620a:ccb:b0:67b:3191:c635 with SMTP id b11-20020a05620a0ccb00b0067b3191c635mr7282708qkj.285.1647024698037; Fri, 11 Mar 2022 10:51:38 -0800 (PST) Received: from localhost ([2601:184:4181:74c0:862e:5809:ed9e:e10e]) by smtp.gmail.com with ESMTPSA id v18-20020ac85792000000b002e1c602cf9asm683647qta.22.2022.03.11.10.51.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Mar 2022 10:51:37 -0800 (PST) From: Robbie Harwood To: Daniel Kiper , grub-devel@gnu.org Cc: development@efficientek.com Subject: Re: [PATCH 0/6] Various fixes and cleanups In-Reply-To: <20220310233600.25910-1-daniel.kiper@oracle.com> References: <20220310233600.25910-1-daniel.kiper@oracle.com> Date: Fri, 11 Mar 2022 13:51:34 -0500 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=170.10.133.124; envelope-from=rharwood@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2022 18:51:49 -0000 --=-=-= Content-Type: text/plain Daniel Kiper writes: > Hey, > > Mostly build fixes plus one cleanup and INSTALL file update. > > Daniel > > INSTALL | 3 ++- > conf/i386-cygwin-img-ld.sc | 4 ++++ > configure.ac | 4 ++-- > grub-core/commands/i386/pc/sendkey.c | 8 ++++---- > grub-core/loader/i386/bsd.c | 2 +- > grub-core/osdep/windows/platform.c | 10 ++++++++++ > 6 files changed, 23 insertions(+), 8 deletions(-) > > Daniel Kiper (6): > osdep/windows/platform: Disable gcc9 -Waddress-of-packed-member > loader/i386/bsd: Initialize ptr variable in grub_bsd_add_meta() > commands/i386/pc/sendkey: Fix "writing 1 byte into a region of size 0" build error > conf/i386-cygwin-img-ld: Do not discard .data and .edata sections > configure: Drop ${grub_coredir} unneeded references > INSTALL: Add more cross-compiling Debian packages For all in series: I don't think any of these will break anything, but I haven't experienced any of these errors so I can't confirm they fix anything either. Subject to that, Reviewed-by: Robbie Harwood Be well, --Robbie --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAmIrmjYUHHJoYXJ3b29k QHJlZGhhdC5jb20ACgkQJTL5F2qVpEL+JxAAgPBSLmrppUwgOUKMWf4PNOk54Gq7 W+Ocx9As7GyNVQsIzG1n7vuXymj1darFIdBABQbAbKeMk9LQh/yA+1dlS5/5F+60 8p41R0sp+p0nYbm9734Brc3Jj2hJUtprVhc8IWGmcgR0oQcKqQJjbaQvv3s+VzQi Forh6cGCREO1F/ZaNaBmoLp/lJjOaKLREhy2U06R9BuJUY2B2DrngKNC5YitnTuN Xq/TUaOot38cYERinpwc9dwvTBeIydYav+R7QvHfDfEBUbjSW7q6wgKSuy7YxhiU k7S1c7WSM1aT0qlhp041AKiUjyok5pve5arZpBb6LWW+LeXVlKoVzpi/qu6gzqwM K+pPq2qwk9VZbRB6TSrRHiZPy5+5dWoIK5xMpP89hHcqi5VpciFQb1l7XiVQM+Zt bkQ855MAx9z0rKSjtv6CS0ei9L6NTjzEIJLF26liH+3JFyTJj150rmM69GVVtnD2 8FttZu2xd9Fu3+ktcnFLGy46GmiFRAJ0Ely9uil5rlE78xUnXC2Pm0oYuepw/iNZ 0OhMtbNCYK2Wj4MEm16EVr3RIXFk3KgawA1LD739RuJNOrirV4+pFn7VfYkgsrOI 84K5KwBcxsycZWCRsHrTM59mF7Ft5t9XBv97cJ3UWefmRDRQXqHcgqassF7+PwE6 77xt6pzK5k2GC2c= =ZPuz -----END PGP SIGNATURE----- --=-=-=--