From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nubOW-0001dA-3f for mharc-grub-devel@gnu.org; Fri, 27 May 2022 10:56:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56492) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nubOU-0001d1-QD for grub-devel@gnu.org; Fri, 27 May 2022 10:56:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:32454) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nubOS-0004Jz-3c for grub-devel@gnu.org; Fri, 27 May 2022 10:56:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653663406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UYvNC2DehZBhyROLvlCHzRXxVM/qpDPJ59oWKzFYgb8=; b=MqAZoDNTPtCVFuabAnVeAcAbtR2AvdSp+0l045kmg8cQNgGu6+Gx62p7NgCrQrEtd64nRx lCug9eYCajfEV8zODMT4hbSFbmYTPHf3rO6drNHg4N3Mm9tjn+snwrSKZEUSxo17vGFwra vW4nsc/oAjPT3eyuJtgV3d7BJPwYgwA= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-358--ypG5VDpNJStIchxifrXzA-1; Fri, 27 May 2022 10:56:45 -0400 X-MC-Unique: -ypG5VDpNJStIchxifrXzA-1 Received: by mail-qv1-f69.google.com with SMTP id l15-20020a056214028f00b004625e7032easo3695148qvv.9 for ; Fri, 27 May 2022 07:56:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=UYvNC2DehZBhyROLvlCHzRXxVM/qpDPJ59oWKzFYgb8=; b=uoNQx4XnLHGkFg+EAL9OopZEWYcihaWUX81QKlNF/HgpCmk5WOvNXTcS+QEJCCOZbJ QIzLsE71is43heTT2V6UldzHhnVzvRlBazotmK8Ehie070Sl9RkpHK1UiFYGrsgNW7CE uLBmsD0VjLgP+/4xEPzliGNEp4WyDIdQhjZiLnnV97ios+yswA9KiZXptW5Shw0yFJSv z2E+EbjT5/wJbUfXMnAlm0K+ZayuwPd876PhCaQ2zfGMOj6cVmsmSTJjGZNQYxPPusd2 22O1of1TenuaJ3FF+HpQc36yn1SAtLoplLdi3ahz0QGRqq8uj/8CMEV7GFz1sWRGUlmj TqrQ== X-Gm-Message-State: AOAM530B+lxDGQTV4wAbjdyjOgMI8Yd10icHCojL6mAWxo7IhlH+FLjX YzpaHMFxps4kYkk/u+TZctuoyPhtS8USaEHjjnOER5EgnzswbSgFO3Q6bRAOcssQQomg7+URaam K8mOZWddRBPvTIrHzujKkrP2HsKNmyF1Icwp4Zz+SN1GJOxbvwi5OXq+UaZ9Sjgc= X-Received: by 2002:a05:622a:153:b0:2f9:31a8:302f with SMTP id v19-20020a05622a015300b002f931a8302fmr23177709qtw.319.1653663404197; Fri, 27 May 2022 07:56:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwQqRgs2wfIw5u3dhZl36jlSRKadssQdyoXVTK6njwsGhBlvWwipX/toVq6SMmX9NYltZFEg== X-Received: by 2002:a05:622a:153:b0:2f9:31a8:302f with SMTP id v19-20020a05622a015300b002f931a8302fmr23177677qtw.319.1653663403689; Fri, 27 May 2022 07:56:43 -0700 (PDT) Received: from localhost (c-73-227-130-153.hsd1.ma.comcast.net. [73.227.130.153]) by smtp.gmail.com with ESMTPSA id c13-20020ac8054d000000b002f3e127be41sm2539042qth.20.2022.05.27.07.56.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 May 2022 07:56:43 -0700 (PDT) From: Robbie Harwood To: Michael Chang via Grub-devel , The development of GNU GRUB Cc: Michael Chang , Mathieu Desnoyers Subject: Re: [RFC PATCH v3 5/5] Cleanup: grub-mkconfig_lib: remove unused version comparison functions In-Reply-To: <20220527060746.GA8033@mazu> References: <20220520143741.217690-1-mathieu.desnoyers@efficios.com> <20220520143741.217690-6-mathieu.desnoyers@efficios.com> <20220527060746.GA8033@mazu> Date: Fri, 27 May 2022 10:56:38 -0400 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=170.10.133.124; envelope-from=rharwood@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 May 2022 14:56:51 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Michael Chang via Grub-devel writes: > On Thu, May 26, 2022 at 05:07:11PM -0400, Robbie Harwood wrote: >> Mathieu Desnoyers writes: >>=20 >>> There are no users left of version_find_latest(), version_test_gt(), >>> and version_test_numeric(). Remove those unused helper >>> functions. Using those helper functions is what caused the quadratic >>> sorting performance issues in the first place, so removing them is a >>> net win. >>> >>> Signed-off-by: Mathieu Desnoyers >>=20 >> Reviewed-by: Robbie Harwood > > Hm. This seems to contradict your proposed patch to use distro specific > sort by hooking into those functions got removed here. > > mkconfig: use distro sorts when available > https://www.mail-archive.com/grub-devel@gnu.org/msg33357.html > > I'd like to know more your comments about this as those hooks might > still be needed or where to keep distribution's sort ?=20=20 The series does, yes - both can't be applied as-is. I'm fine to rebase mine, but haven't done it yet. I don't mind adding them back if I need to. Be well, =2D-Robbie --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAmKQ5qYUHHJoYXJ3b29k QHJlZGhhdC5jb20ACgkQJTL5F2qVpEJMTBAAwpb7LwpIkP2mGtU8eb42ykY/D+NO Yy/UZwcnGwGM+20hLcYnc3OVtJjXyAP71onwlGugdRb+520RpHaHmETI5apZVDPu DuTrRZGtAl7bimtIZON7HY5b7T/S2XfWmm6Hi6L5HI37v8EUD/mAQxXf8/7PvM3p ZAu28fyW+XDpaTQQbtx44hdzXpcGd3tXLTU09aUwVNmFWyy/wZdMXw3wKyCd6coJ F3+S+NlDgfiBwMsGcmd1D1g/kGyvi9wPXKsI3M/xwOtpJ3Uf3pUJ4s4I1YPhtU6s km222WMwg3ilmVA6SdP+oFsKWdvYLtRsoauMQqtqi6Htn6Fqpj+301UepOc3ZIzh M6hUOCn29ewAHhWTqtCmzMhbAe2bfOCz7Z/kSze4fTUyn0rQv5BsPWzGOfDNMyrJ i0ddfJxf/GzaoUYUGprFJYo9Ozvs1G9AvQ6aF6pKPq2dKDjVGNwR73/YQWiGkFP2 Yn0Ui2ACVBU+9ETcAPS3IN7v6kJlfVfWrJExb7MNuZaiXgJn5oauJnDifH+TeksD ahEaOCeZN1UCTTKebnKPdmSfiVdLtYXepYT1f5kqNB7e50opg+YZdY4JRYkSpLOn TcZ48ZRbMWbaxWfK1JEueo9jPObjhtlAfuyFNGREvpHrwKICjwKddifB7QaIamLP kgvayWD0ho3Ng5c= =bV1X -----END PGP SIGNATURE----- --=-=-=--