From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1ndxEA-0004Ry-E9 for mharc-grub-devel@gnu.org; Mon, 11 Apr 2022 12:49:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndxE8-0004Nk-2I for grub-devel@gnu.org; Mon, 11 Apr 2022 12:49:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:59922) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndxE5-0002sL-0y for grub-devel@gnu.org; Mon, 11 Apr 2022 12:49:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649695755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IXUA4RIR/ecoieaCuf9V9MODHLAtRrGblgNcMYBXb18=; b=X6YFpF64ztC73APQCung1DFdsBzXPwsLR5sXZ+zsxkKHhXsbZFDQYXrUvGHK+grIfW2RKF pf0rWJyoKURzt0324Ap2oUDPKF9s0QCtsnZsLgtzKv5+pbZ/u+SrCRxnps4PfJD8ixM3zh S38MdCkN7rJKbCXpqr2zrnnfJuCKQmE= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-656-Ki5KPZ62NHuTlHyUfaeCyg-1; Mon, 11 Apr 2022 12:49:06 -0400 X-MC-Unique: Ki5KPZ62NHuTlHyUfaeCyg-1 Received: by mail-qt1-f198.google.com with SMTP id e5-20020ac85985000000b002e217abd72fso13097992qte.9 for ; Mon, 11 Apr 2022 09:49:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=IXUA4RIR/ecoieaCuf9V9MODHLAtRrGblgNcMYBXb18=; b=Z4tBUeGAxFKfvOEuu98KT2kqtQzwptpqOlePSXWi9VqgGRII1g4xy8Qk6O+AU3soSz v8FRb+kN3RCfp9S1WfRyl2b26iMHgz0TUFfD++lfyXIm1aXB2sfBLqYYfcMWMIRUoznX Dlde8CHWWj9XhToKY0XnN/u2onhfB4t1dpDse1G1Z2MdlGMLenwberb1OL91J6tRjZ1D kNwrMROYQXS8QU9Sji9OxTFfmE7vMyubkjNDqTh8CIWQmSUc/edwZDICRoLnQqrfpWXz I/rmqIXNOXILCKw04NLNeAaOnCMJxbkJLnuNCyAp0672dyj6HrV8Skg5TAnMcxExd9qv RnWA== X-Gm-Message-State: AOAM5332yIc0ygdnU5o4tUnDpPz6nFu4TY4wXxlVDC7UMdK9Q+Bt+4Bk r7IPg4/ox/CAPHJobn+jNh7CSZUQjLj5BwaG73KCRT7Buk1s3fdRr0+QFQj8Bsw4XI+VjYJg6U3 +XQqqs7mt1A0= X-Received: by 2002:ac8:7e88:0:b0:2eb:8eb4:6ca1 with SMTP id w8-20020ac87e88000000b002eb8eb46ca1mr211651qtj.486.1649695745814; Mon, 11 Apr 2022 09:49:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOFTeT291qFy9rh+B9E+XMMp+t9yKCKZGV6oUK3ZBGox9FRETDpTbuCSnMcIZXlIJ4Fa3HbQ== X-Received: by 2002:ac8:7e88:0:b0:2eb:8eb4:6ca1 with SMTP id w8-20020ac87e88000000b002eb8eb46ca1mr211632qtj.486.1649695745419; Mon, 11 Apr 2022 09:49:05 -0700 (PDT) Received: from localhost (c-73-227-130-153.hsd1.ma.comcast.net. [73.227.130.153]) by smtp.gmail.com with ESMTPSA id br13-20020a05620a460d00b00680d020b4cbsm18499814qkb.10.2022.04.11.09.49.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Apr 2022 09:49:04 -0700 (PDT) From: Robbie Harwood To: Glenn Washburn , Daniel Kiper , grub-devel@gnu.org Cc: Glenn Washburn Subject: Re: [PATCH v3] configure: Fix default -O2 being added when CFLAGS not set In-Reply-To: <20220409022959.178485-1-development@efficientek.com> References: <20220409022959.178485-1-development@efficientek.com> Date: Mon, 11 Apr 2022 12:49:01 -0400 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=170.10.133.124; envelope-from=rharwood@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Apr 2022 16:49:21 -0000 --=-=-= Content-Type: text/plain Glenn Washburn writes: > Autoconf will set a default CFLAGS of "-g -O2" if CFLAGS is not set. CFLAGS > was defaulted to "" early in configure to prevent this. A recent commit > ad9ccf660013c208077b1e983d6c824df25ed1cf ("configure: Fix various new > autotools warnings") added AC_USE_SYSTEM_EXTENSIONS, which pulls in the > autoconf CFLAGS check, before we default CFLAGS and thus setting the > autoconf default for CFLAGS. Move the default setting of CFLAGS to before > AC_USE_SYSTEM_EXTENSIONS so that autoconf will see CFLAGS as set and not > give it a default. > > CFLAGS is also moved above AC_CONFIG_AUX_DIR, because CFLAGS should be > defaulted to "" as soon as possible to catch any autoconf macros that try > to use some other default. Regardless, this currently has no effect as that > macro does not consider the CFLAGS variable. > > Signed-off-by: Glenn Washburn Reviewed-by: Robbie Harwood Be well, --Robbie --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAmJUW/0UHHJoYXJ3b29k QHJlZGhhdC5jb20ACgkQJTL5F2qVpEJVRg/+LMBk3k0Zd9TvvxdwDXo90/Cs0JbJ t/TkNSe8f5iDkcF2qPgvPe61nrSHz9i4zFuRVqAey+6bjrdx+w9JqGLcA6w3MIHu ed1IUSXp2N+3JkegS1pB/sYvZ3iViTFw4zufLlVTSyVW4j2QYHmM/eHIfmgdhIAl 6I7wRg1iwY29tSwR74Wxstf5kHGnmz4SN0BU7gKs9wRxZAJIenOXnd6PoYN8X865 tbMeToeBlJ9HKxs12DUzZqcW+4JKp44+pcwQfkKyG6WazL7Kq/k4j1RRhHHV5Mao aCLRwbxy61L+DlQwj7gylkkCBi/fod8UGeJRlTXRn05plorMEWYUGxD6Eu4qbQyO bXP4vd5sgmKqcL7cmBdYG8pVi+s09zeBuCTHp6Leb4mMEt3AvZh7ORggN/gIJQUS fM5akvF4jUcH00Fr5HsSA9qyxhhZKeQW6Xgr7NdZBXKU8c+GVoIupXS+KJEox+uA 1XLE1gCWUq7ePHnp3H9pFsnGXu9J0TLrD6Fj4tVQN9YQ8oAug7CUsC6dXfrcDMAd onvXzQehZ3jxpulwtLxkfGXGspAkDTQ2z1+VB1Z5pIn5PI08EE0hQPkWve2qGdGc sySwwGZisGUpm+WhTJtxnrRhDjaEbce7WENl+0ZU390cpeRhnqg3Wh4mxDmnOAYa r6G94ULwybbUGT4= =0iJ5 -----END PGP SIGNATURE----- --=-=-=--