From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1osQbR-0000vp-RR for mharc-grub-devel@gnu.org; Tue, 08 Nov 2022 10:33:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osQbE-0000jq-MV for grub-devel@gnu.org; Tue, 08 Nov 2022 10:33:17 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osQZB-0004PO-QM for grub-devel@gnu.org; Tue, 08 Nov 2022 10:31:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667921468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6gw7q6tr7oqTGrrUe5DK52LExs6oewXd+n3zBgDfqmM=; b=IxG6cmIMYMkpuoKqEl0fNlzbTVKGRa2AyUREI1XskaybyWTUgu5jX1GnZEKfAGtUOKkWuC Z5NS2PMTLV/c2jj0CJvuOaNJS9xhvUcmJsXuRhHCwodp3kork9FI3f4Kmnb9d3Qd3i5ey/ xZSHeZH302ViBjcUEjm7EsQ40p21jPs= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-607-ZA1o0k0DNTKeYRkGreyG5A-1; Tue, 08 Nov 2022 10:31:06 -0500 X-MC-Unique: ZA1o0k0DNTKeYRkGreyG5A-1 Received: by mail-qt1-f200.google.com with SMTP id n12-20020ac85a0c000000b003a5849497f9so4733576qta.20 for ; Tue, 08 Nov 2022 07:31:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6gw7q6tr7oqTGrrUe5DK52LExs6oewXd+n3zBgDfqmM=; b=34wK7wSu0F9JUVzCuoOJB1fkX1zTqlAsb6C08dANuinWOzw8zYiMZunP5yuCm928pg 4c5riR0ifY1Q/lKrR8TkF7ubUcwBMFSMSnWO3eSwKJSChGq4R/p6Xp/BqFNZhuwlig7O zK1H41MNmHgIuVsDEQfDpZiJkaV7OR6qBokp9BYGI9H6b5eX1URqylG1Jsq6n37LB9CN xPSkXWqHC0OMVVpSuFdPXmh/heTWkTaLJvHnsJu+5VTRlzk8uKHqoX7X/IT0Jq7+WxDr AX+lWHdpZ4syyEU5j3H30QIcCTVoJfAuaSnHIdYfhyRUosmuzHl9QUBHjOpJg5AIeack UNyQ== X-Gm-Message-State: ACrzQf0JM6HZboMVLkmGQa5+DHNOWtgOu/J5fz/Jjwo2nH61VaBxbKhE Zik2vaLxHrnObF5E+5IX28L5eRj+sLeQIzXTlPQoARBMJDcl99mU4SjmUVoozGtNIaHAbOjY2gu 1UWmQRnrz3AM= X-Received: by 2002:a05:6214:2a87:b0:4bb:e62e:4713 with SMTP id jr7-20020a0562142a8700b004bbe62e4713mr45432419qvb.2.1667921465487; Tue, 08 Nov 2022 07:31:05 -0800 (PST) X-Google-Smtp-Source: AMsMyM4UXhdBvI4F0tKgGb6W+pcuKPHnzcNwWvf4QZdRk2hgiyasQaaXq0bDNwND8ecOxwS0Zj/Leg== X-Received: by 2002:a05:6214:2a87:b0:4bb:e62e:4713 with SMTP id jr7-20020a0562142a8700b004bbe62e4713mr45432347qvb.2.1667921464893; Tue, 08 Nov 2022 07:31:04 -0800 (PST) Received: from localhost ([2600:4040:520a:8800:7d1c:f0a7:5c44:ed0e]) by smtp.gmail.com with ESMTPSA id fg26-20020a05622a581a00b00399b73d06f0sm8279645qtb.38.2022.11.08.07.31.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 07:31:04 -0800 (PST) From: Robbie Harwood To: Daniel Kiper Cc: grub-devel@gnu.org, javierm@redhat.com, phcoder@gmail.com, mchang@suse.com Subject: Re: [PATCH v3 1/1] Add paging instructions to normal and help prompts In-Reply-To: <20221108144819.cxkhlnkl2ls7vfnl@tomti.i.net-space.pl> References: <20221104170537.506302-1-rharwood@redhat.com> <20221104170537.506302-2-rharwood@redhat.com> <20221108144819.cxkhlnkl2ls7vfnl@tomti.i.net-space.pl> Date: Tue, 08 Nov 2022 10:31:01 -0500 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=170.10.129.124; envelope-from=rharwood@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Nov 2022 15:33:20 -0000 --=-=-= Content-Type: text/plain Daniel Kiper writes: > On Fri, Nov 04, 2022 at 01:05:37PM -0400, Robbie Harwood wrote: > >> --- >> grub-core/commands/help.c | 2 ++ >> grub-core/normal/main.c | 3 ++- >> 2 files changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/grub-core/commands/help.c b/grub-core/commands/help.c >> index ac3907f9df..2c70c7b417 100644 >> --- a/grub-core/commands/help.c >> +++ b/grub-core/commands/help.c >> @@ -135,6 +135,8 @@ grub_cmd_help (grub_extcmd_context_t ctxt __attribute__ ((unused)), int argc, >> } >> } >> >> + grub_printf ("\n\nTo enable less(1)-like paging, `set pager=1`.\n"); > > Are you OK with s/`/\"/g? If yes I can do it for you before committing > this patch? That's fine. >> + >> return 0; >> } >> >> diff --git a/grub-core/normal/main.c b/grub-core/normal/main.c >> index cb0e8e7fd2..2cb48a94f5 100644 >> --- a/grub-core/normal/main.c >> +++ b/grub-core/normal/main.c >> @@ -380,7 +380,8 @@ grub_normal_reader_init (int nested) >> >> msg_formatted = grub_xasprintf (_("Minimal BASH-like line editing is supported. For " >> "the first word, TAB lists possible command completions. Anywhere " >> - "else TAB lists possible device or file completions. %s"), >> + "else TAB lists possible device or file completions. To enable " >> + "less(1)-like paging, `set pager=1`. %s"), > > Do we need extra spaces here? I would be consistent with the rest of the > message and use one space everywhere? Again, I can make these changes > for you if you are OK with them. Also fine, thanks. Be well, --Robbie --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAmNqdjUUHHJoYXJ3b29k QHJlZGhhdC5jb20ACgkQJTL5F2qVpEI61Q//Zlox6B2ucVCm6+YfFsJ/fPcFjTD6 NC5JIVab6Sc/Y9F5n2RgBHg+TZlCwpvq6pHk78Iis5bigvRIbx5FpwvJ1+KjFeYd h9Xk9kolXDEriNU/SeLK2h24CVO8HNOlK2NRgCcPsYp20EVNmpvCfNKVGWADOn9I Fa1KqtjdJgiDQSZjMA8Ou6928bzNeO8KieqPi6TomE5wLSp/cv4uy23URuVbarBB 07YjWK7CnKaLP2Nrc2fIlxuFRqrL7SxCd2pQYF9GW3vkHQBNbjjf0YUSLrvKOtKP BvwmxSDgGqO/Pt7eld8GvoKtRVKUwIvkS3CQe5HBsWXjDzbdpAvM798BkM4AcmJ4 WGli8nL98GF0Il1ddaK1uqamwvXhoDUd3HogWmTuptWk0VKAYy4BhaQSiArznRgG /pL8jVS6smvOSuiIRk86aC72igU9ELl3HiVAKZw4DOixJxzuuUZP35cmwH4Jg7tL RJ2KPB5RVFr+ZhuGk1U8Q7f2raTYKP+BSbS9gBMgFd6bqsO6r35N60ErkuYmxZwF JdVOP78UO4EjbJFGnmURgi092q5B1wa+zOLfqNwT70XqXBbkiqBv/8/M5isUwZnC DTuRUwFlU5w7fiUD3uuq3Yk8VLOQzQ86s0/udOUZxCCBCijNBtoL6N+yL6XX0DqJ 2C3+AUFFlqYKquk= =3iyp -----END PGP SIGNATURE----- --=-=-=--