From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1olDSp-0004gt-BA for mharc-grub-devel@gnu.org; Wed, 19 Oct 2022 14:06:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olDSa-0004gL-RD for grub-devel@gnu.org; Wed, 19 Oct 2022 14:06:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:33197) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olDSY-0004wa-Uc for grub-devel@gnu.org; Wed, 19 Oct 2022 14:06:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666202787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qf9A7rnWqrb+EibYMN35A7PRUFMOnko0ijKD6eojRe0=; b=OhzOFCAnitlnaqOdryEiZ2mrvgTbB2K2NxeWxkFszvbF1Q/FnEUI7h0bQPwNoZSdwqSkEm k5ZHruxEAE/VuvM/lxvijuBE2hzAqWlY4iHGloHC6vZE9tjVbANHz7MOV3MfohaYvuemaR nYpl9gYG2JLztShTESV5em/spbOMIeg= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-428-eypsQ1ZYNgCrGxTajQsqvQ-1; Wed, 19 Oct 2022 14:06:25 -0400 X-MC-Unique: eypsQ1ZYNgCrGxTajQsqvQ-1 Received: by mail-qk1-f199.google.com with SMTP id j13-20020a05620a410d00b006e08208eb31so15343776qko.3 for ; Wed, 19 Oct 2022 11:06:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qf9A7rnWqrb+EibYMN35A7PRUFMOnko0ijKD6eojRe0=; b=yBJaBMgxvIjn2RzEXsaLNpC9SIWfm+PXzGI/t7+EN09OiNDrEmxnVNn7mIaSBI0mkm mC0IcB3yJHfSCckyQXvnrqLQhCbbktiqt4JkPB0p74XQbiMp3Kt0kTT/l2PC58Nn4JEk z9nCCMrFEoDcRSQqKsD+K7oTuB8Bd0/wnVWNGyACd/f27iVDG+unVci9AhIz8uahJC75 fmJlqwT30lJYbsXvT3AULb4W+Pv3tgcWv2/omXhKBDzolSXzWGbB5aXdku+RX5vDbkFe dEvP6fpKzEodkSpTaRFtKSFCId55dUH+0aRavsEHShffqD7Pb5Ov0O+EkBRoWz7MtcYM 4E5A== X-Gm-Message-State: ACrzQf3WwNFMjg2eZ/fDBo2LpS9Lrz9aEnfbuBY02tQqp7shb7cUB+r9 PWaJ4R6l5a3h7x3HVXnfXQHkmFfPZUBDdq3mYPg4vmD9lHjjM2afmdIzeh5fZkG2NMuPBQRFxVT j2gtt1I+yL0U= X-Received: by 2002:a05:620a:2a0c:b0:6cf:9085:683b with SMTP id o12-20020a05620a2a0c00b006cf9085683bmr6492496qkp.159.1666202784913; Wed, 19 Oct 2022 11:06:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7SIjw+54u4+08Fcc5p8ePSAbJDOdMfe9h+cCEO92SAJQNGhjZl/J8Q6NulPkIrSz1qOzI16w== X-Received: by 2002:a05:620a:2a0c:b0:6cf:9085:683b with SMTP id o12-20020a05620a2a0c00b006cf9085683bmr6492468qkp.159.1666202784559; Wed, 19 Oct 2022 11:06:24 -0700 (PDT) Received: from localhost ([2600:4040:520a:8800:7d1c:f0a7:5c44:ed0e]) by smtp.gmail.com with ESMTPSA id m15-20020a05620a13af00b006ee949b8051sm5271720qki.51.2022.10.19.11.06.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 11:06:24 -0700 (PDT) From: Robbie Harwood To: Daniel Kiper Cc: grub-devel@gnu.org, Raymund Will , rw@suse.de, John Jolly , Javier Martinez Canillas Subject: Re: [PATCH v4 1/1] Add support for grub-emu to kexec Linux menu entries In-Reply-To: <20221014111113.ptl44ny7vzrkeder@tomti.i.net-space.pl> References: <20221004191648.77723-1-rharwood@redhat.com> <20221004191648.77723-2-rharwood@redhat.com> <20221014111113.ptl44ny7vzrkeder@tomti.i.net-space.pl> Date: Wed, 19 Oct 2022 14:06:15 -0400 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=170.10.133.124; envelope-from=rharwood@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.256, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2022 18:06:37 -0000 --=-=-= Content-Type: text/plain Daniel Kiper writes: > On Tue, Oct 04, 2022 at 03:16:48PM -0400, Robbie Harwood wrote: > >> + return rc; >> +} >> + >> +static grub_err_t >> +grub_linux_unload (void) >> +{ >> + grub_dl_unref (my_mod); > > I understand that this marks this module as not in use. Right? If yes > please add a comment before grub_dl_unref() call what exactly happens > here and why. It took me a while to understand why it is > needed. Please do the same below for all grub_dl_ref() and > grub_dl_unref() calls. I expect it's modeled after the other linux.c - e.g., grub-core/loader/i386/linux.c has an almost identical grub_linux_unload() function. Be well, --Robbie --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAmNQPJgUHHJoYXJ3b29k QHJlZGhhdC5jb20ACgkQJTL5F2qVpEI/dg//cDcevPf3XG5c0phlcLQkU/7dFvIw h+0PYbzLhCSaJ0H6RmnV2YdeFizWm/Shwdm86pHyez7809bEVRc7stEQQZeF2+f0 wnuMP/9arbochdwTNfT5yxKIOnXs9k680P+Vud1/D3kuCPLLkJL+CKWESPk/sk9U a0yGQT+WLtNUiidnHes0D+9MYRCrlu5KvbvGHE4I0arQi7sslozSWZ83kAfeNYWT Z/OGCHVtVOcZGSRlubi8WRAgCsXqxjrel8OOP2nUrxlqslOMCwgOtBsN1SHyAytp 9/Mp2CW1XTiOc6l/LjgwnPPAg2tDqbtNc3sds853FLVnKotuG8IAsD12swalFYzm gqY3UmkVr2zwcq6yOtnvAXMnwIKnhG4uW8SwxD2YZmFXzFaUdHpt2ZKnQbtCM9GQ rAGde5mbBx2XS+trMVo8/BZ/hRpCfwk7ZFKM2BVYLpx2GGP8VjJZphTrGFzw4/8W d8ZWFrtNfFIY41J1ErJKQuIMHK7A5379e7Emm2uzDgGm+CczH5W/DXT8dMyIyyhC WgvYtDH3Og0oTqMp3CwmkBXhTftsyCz44MG3/OuQPB0G7hLjYsknfjmvXTWlldM1 IeuL/7glW7NN4MqsijfR51OTP71XiZuweUXk80BIRaeXXt4A/r5Ie7Qr/j2Lo8T7 sUAlWq2Xpj3TBPg= =mMxO -----END PGP SIGNATURE----- --=-=-=--