From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nFHUf-0005eU-3W for mharc-grub-devel@gnu.org; Wed, 02 Feb 2022 10:24:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFHUY-0005VQ-FZ for grub-devel@gnu.org; Wed, 02 Feb 2022 10:24:18 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:56215) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFHUV-0003yO-5c for grub-devel@gnu.org; Wed, 02 Feb 2022 10:24:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643815453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TYMEbSYUsZSOWVLwG43tgb150js0ZL+ZZdHVy9iHNN0=; b=Th1s9LxkAYSkZ5sGWd0GYAP91I2DoHmlSHOBjI2Qje9TjGU98cg3EO0eM32ME6OKShjd89 pON/sCtcDPQto79/GuFj5lSGOf/rd9Ts6TVXidoIyafp7riHftT6wSoyEeINh+vpq/A6Bj FqFUK4JkONi9xl7ueNRHm6wDurW6TKo= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-358-Jagid60cNzGT1wg8J5GzOA-1; Wed, 02 Feb 2022 10:24:12 -0500 X-MC-Unique: Jagid60cNzGT1wg8J5GzOA-1 Received: by mail-qk1-f200.google.com with SMTP id z205-20020a3765d6000000b0047db3b020dfso14662469qkb.22 for ; Wed, 02 Feb 2022 07:24:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=TYMEbSYUsZSOWVLwG43tgb150js0ZL+ZZdHVy9iHNN0=; b=Ik52HpPgOVP485491f4ONl6A0XkwvWucFASGP7m6J5ze8RMkD8lxqSCwrmGlDO6js6 XGg7fRgNqeNDJPbQjkJFPXlObyMWZxICwfntJZeIFtZxR5BR7k2oKGuxNbbaS8iKeD62 I0l4nThWlI6fZQM4hNwusQv6qCh4BvvKDZ10sze2sn1/lCiqtT92MbEbbETKhAJYSGFq 3BbzFk/EmUyoOG68A25JWZylL/uhTYiJyASnmtheC+D6/HYRl5Fa6KItY2iH/sJnd+CT yyX5khErVkP5vjZ0SBqLhtX6F5iZEw7iSn2pM82wyUgBLN9suC8qSzdwr5Alm4fycFh5 5XsA== X-Gm-Message-State: AOAM53258d1TMqBsF9b2mMu8RjtknpDYkhSwB31eNIk0n8IfS7r2oEzu d5rfoTzU0K7KrZ9DCJeQq9PrMg2qFZavspJwzNnbW6Ms3umCVXBaEm7BzGXO6RqVSuSCEWwte9b h39I2GhLYYNs= X-Received: by 2002:a05:622a:1981:: with SMTP id u1mr22622398qtc.225.1643815451665; Wed, 02 Feb 2022 07:24:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJzFnn3lWFTfSunPMe/6qeq2hgAmm2gsvUflrqJ1Bfpy2lLDcwkuF4OwBi9RLdC0AfW32nIB8w== X-Received: by 2002:a05:622a:1981:: with SMTP id u1mr22622356qtc.225.1643815450869; Wed, 02 Feb 2022 07:24:10 -0800 (PST) Received: from localhost ([2601:184:4181:74c0:862e:5809:ed9e:e10e]) by smtp.gmail.com with ESMTPSA id n19sm4703600qkp.52.2022.02.02.07.24.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Feb 2022 07:24:10 -0800 (PST) From: Robbie Harwood To: development@efficientek.com Cc: grub-devel@gnu.org, dkiper@net-space.pl, darren.kenny@oracle.com, ps@pks.im, dja@axtens.net Subject: Re: [PATCH v3 0/4] Update gnulib and drop some patches In-Reply-To: <20220201110932.531e3a8c@crass-HP-ZBook-15-G2> References: <20220127194000.111318-1-rharwood@redhat.com> <20220201110932.531e3a8c@crass-HP-ZBook-15-G2> Date: Wed, 02 Feb 2022 10:24:07 -0500 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=170.10.133.124; envelope-from=rharwood@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.086, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Feb 2022 15:24:18 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Glenn Washburn writes: > On Thu, 27 Jan 2022 14:39:56 -0500 > Robbie Harwood wrote: > >> Changes in this version: >> - Make the version of bootstrap match what it's supposed to >> - Restore fix-width.patch at dkiper's request >>=20 >> Be well, >> --Robbie > > I presume this has been build tested, right? > > I'm getting the following compiler error with gcc 10.1.0: > > In file included from > /home/g10/grub-tests-uml-update-gnulib/grub/grub-core/disk /luks2.c:30: > /home/g10/grub-tests-uml-update-gnulib/grub/grub-core/disk/luks2.c: In > function =E2=80=98luks2_verify_key=E2=80=99: > /home/g10/grub-tests-uml-update-gnulib/grub/grub-core/disk/luks2.c:398:75: > error: pointer targets in passing argument 5 of =E2=80=98base64_decode_ct= x=E2=80=99 > differ in signedness [-Werror=3Dpointer-sign] 398 | if (!base64_decode > (d->digest, grub_strlen (d->digest), (char *)digest, &digestlen)) | > ^~~= ~~~~~~~ > | > | | > grub_size_t * {aka long unsigned int *} > /home/g10/grub-tests-uml-update-gnulib/grub/grub-core/lib/gnulib/base64.h= :59:50: > note: in definition of macro =E2=80=98base64_decode=E2=80=99 59 | > base64_decode_ctx (NULL, in, inlen, out, outlen) | > ^~~~~~ > /home/g10/grub-tests-uml-update-gnulib/grub/grub-core/lib/gnulib/base64.h= :52:59: > note: expected =E2=80=98idx_t *=E2=80=99 {aka =E2=80=98long int *=E2=80= =99} but argument is of type > =E2=80=98grub_size_t *=E2=80=99 {aka =E2=80=98long unsigned int *=E2=80= =99} > 52 | char *restrict out, idx_t > *outlen); | > ~~~~~~~^~~~~~ > /home/g10/grub-tests-uml-update-gnulib/grub/grub-core/disk/luks2.c:400:69: > error: pointer targets in passing argument 5 of =E2=80=98base64_decode_ct= x=E2=80=99 > differ in signedness [-Werror=3Dpointer-sign] 400 | if (!base64_decode > (d->salt, grub_strlen (d->salt), (char *)salt, &saltlen)) | > ^~~~~~~~ | > | | > grub_size_t > * {aka long unsigned int *} > /home/g10/grub-tests-uml-update-gnulib/grub/grub-core/lib/gnulib/base64.h= :59:50: > note: in definition of macro =E2=80=98base64_decode=E2=80=99 59 | > base64_decode_ctx (NULL, in, inlen, out, outlen) | > ^~~~~~ > /home/g10/grub-tests-uml-update-gnulib/grub/grub-core/lib/gnulib/base64.h= :52:59: > note: expected =E2=80=98idx_t *=E2=80=99 {aka =E2=80=98long int *=E2=80= =99} but argument is of type > =E2=80=98grub_size_t *=E2=80=99 {aka =E2=80=98long unsigned int *=E2=80= =99} 52 | > char *restrict out, idx_t *outlen); | > ~~~~~~~^~~~~~ > /home/g10/grub-tests-uml-update-gnulib/grub/grub-core/disk/luks2.c: In > function =E2=80=98luks2_decrypt_key=E2=80=99: > home/g10/grub-tests-uml-update-gnulib/grub/grub-core/disk/luks2.c:439:22: > error: pointer targets in passing argument 5 of =E2=80=98base64_decode_ct= x=E2=80=99 > differ in signedness [-Werror=3Dpointer-sign] 439 | (char *)salt, > &saltlen)) | ^~~~~~~~ | | > | grub_size_t * {aka long unsigned int *} > /home/g10/grub-tests-uml-update-gnulib/grub/grub-core/lib/gnulib/base64.h= :59:50: > note: in definition of macro =E2=80=98base64_decode=E2=80=99 59 | > base64_decode_ctx (NULL, in, inlen, out, outlen) | > ^~~~~~ > /home/g10/grub-tests-uml-update-gnulib/grub/grub-core/lib/gnulib/base64.h= :52:59: > note: expected =E2=80=98idx_t *=E2=80=99 {aka =E2=80=98long int *=E2=80= =99} but argument is of type > =E2=80=98grub_size_t *=E2=80=99 {aka =E2=80=98long unsigned int *=E2=80= =99} 52 | > char *restrict out, idx_t *outlen); | > ~~~~~~~^~~~~~ > cc1: all warnings being treated as errors > > Should be an easy fix. What compiler version are you using? gcc11-series. I'll see if I can reproduce in a VM and get a fix out. Be well, =2D-Robbie --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAmH6ohcUHHJoYXJ3b29k QHJlZGhhdC5jb20ACgkQJTL5F2qVpEL2Ig//XZPwltUUaQzRoTtZJLP3MYPPL5Rw 1pa7fKsMXM0sh0+WK2fMnhLIAcaD7/bdI6L11/qDCkH8KiNpaeBHAE9dyEtRKPhN sAGN2+CtfJjeFSoONMZfW9XggJO2aiEBxuTxnEaWX0VZjycqZqrYGH58K70Gh04m J45NwvEFxXXAfl9XsxzOXqIr652/a2nURkkg/296VkIMha0IqTXNUD1EOI1PA6cV cC0eP7Mu444NUx5lnW1phFxS7O+g4zgz4Saj/B1sNLXXCNSves4uWghj0FkdazRy hF9+rRC3GYiCObfjkyrWmih3rCMX2lOBdd4+4erBKB+q83hsTlMwO3kPfcMJXPw/ S6RPSwCUqJ2RupuDBxUCv1Wl0mANAnIJwyfv+lSzoOAn3ynwEkXdDrb4Co6rPV/M gmhr2o5lwqW6iJM8wHT3es8SedeNelmR2mMXd9mdQ+X0VSxkNodsGXdVgWrutQ60 K/t9mQuFK67yS3uOUCEPc0YbjkHxbVSHKA9cRSzLy8316gLlfcDOCEGxTTr99Iw8 pGMtfg8TG7tx0wsj6O9y2cL+KolVNk78WgT6dC72m2h8VzRjrWuzNzSnU1x0HsIL o5Dy+GppX0k+Flqa1rrskAhePlIEXajgrNw45HE8Camm+m/kS3Ca2G4Z4TPaRlFt LhZR9K3414m6SDE= =H5Bc -----END PGP SIGNATURE----- --=-=-=--