From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1pIH2E-0004Ki-4P for mharc-grub-devel@gnu.org; Wed, 18 Jan 2023 17:35:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIH1s-0004Cv-NE for grub-devel@gnu.org; Wed, 18 Jan 2023 17:35:39 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIH1q-0001aP-Oy for grub-devel@gnu.org; Wed, 18 Jan 2023 17:35:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674081332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9DFMtjmARZV4np/dI4iR4RgFcMDElPavkxEEwwqaLF4=; b=hr31lciXFwONR/7rUPYD3Rq3Z/IYLOxKHHO1fm73aPE3km6rGOhRdjyQyIXG4uTYhqSHhZ 0BeJ0JKlq1CoqEPFmj+RBVQ1xw7+scxtODtEnNSQKvXijdfZvJjTWvvzJ7Vocy3XAVx74b 4nR855ioW0CdUu19s/k8re8XTrGsk9E= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-534-rs7bEQLXNvSdDX5Oz8g_1g-1; Wed, 18 Jan 2023 17:35:30 -0500 X-MC-Unique: rs7bEQLXNvSdDX5Oz8g_1g-1 Received: by mail-qv1-f71.google.com with SMTP id x6-20020a0cc506000000b005349c8b39d6so125216qvi.2 for ; Wed, 18 Jan 2023 14:35:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9DFMtjmARZV4np/dI4iR4RgFcMDElPavkxEEwwqaLF4=; b=MpBSmJOQNHGZwNyi+pgeuRNEG9sJp7aew2JKkqScwOxgqjXpz4uM6g+gmns16VgP5d YYRRjhNdORFRhjszg3BMyjDySqDB63e5vQa3J3E3Jl8LSG3GAXObhRl+hYkFUvUNE8RC pdXzU7mlRYnom6K7Q4KFUOa6qvuzgXADyRa/zKLyMf7fQeSryzepOk6hS3vKtWCI0QqS BZGiS1XTau+a4FddBlHDEgEE17Cu8HEIZUD0peUiBwL80mDOzr7BMTieWi9QOHq/ihO8 5HlKXLCNHOxRIvS2BNvLY8AcPlqLGKAvqdTc1+cCnUvP0g6Hue5gRhA2qq5afEuuxHNM QuIQ== X-Gm-Message-State: AFqh2kpHJAxU5eCoEYTIcy2XWw0u3Wr5JuY4e71+C6CTgRArJV4op7fd VC4pwX3FJU8g7mysWpNylr0+kNGmYIXn9y58tqaIacSxZjr3RykedV/rmoMPv5L5BUeGrvR7rJe 52DU7akAgl3E= X-Received: by 2002:a0c:e584:0:b0:532:dea:1eda with SMTP id t4-20020a0ce584000000b005320dea1edamr9497774qvm.52.1674081329984; Wed, 18 Jan 2023 14:35:29 -0800 (PST) X-Google-Smtp-Source: AMrXdXvRBWIe67TNeN7IyAqdnPQyOMINV0OlBNY7CkzMFgx0kSvYHGPkkCbiEAIvjOnIzd7nHGdHWA== X-Received: by 2002:a0c:e584:0:b0:532:dea:1eda with SMTP id t4-20020a0ce584000000b005320dea1edamr9497746qvm.52.1674081329488; Wed, 18 Jan 2023 14:35:29 -0800 (PST) Received: from localhost ([2600:4040:520a:8800:7d1c:f0a7:5c44:ed0e]) by smtp.gmail.com with ESMTPSA id s1-20020a05620a29c100b00704c6263924sm6399107qkp.13.2023.01.18.14.35.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jan 2023 14:35:28 -0800 (PST) From: Robbie Harwood To: Vladimir 'phcoder' Serbinenko , The development of GNU GRUB Subject: Re: [PATCH v1 1/2] Skip diskfilter on powerpc CDs In-Reply-To: References: <20230113202651.15607-1-rharwood@redhat.com> <20230113202651.15607-2-rharwood@redhat.com> Date: Wed, 18 Jan 2023 17:35:27 -0500 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=170.10.133.124; envelope-from=rharwood@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2023 22:35:39 -0000 --=-=-= Content-Type: text/plain "Vladimir 'phcoder' Serbinenko" writes: > This is not properly restricted to just raid. Only mdraid 1.1 is > affected. The condition should probably be along the lines "if msdos > is embedded in a device of unknown size, then skip mdraid 1.1 probing" My testing suggested it was both mdraid1x and mdraid09 - that is, the presence of either module was sufficient to trigger the issue. While I'm not an mdraid expert, I don't see other users of the diskfilter interface in the tree. If you have an alternate patch, I am happy to test whether it solves the issue. Be well, --Robbie --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAmPIdC8UHHJoYXJ3b29k QHJlZGhhdC5jb20ACgkQJTL5F2qVpEJxGQ//U1rsbOShz+qzfvwepMHBsBo469d6 FPRGOdXow1XntjATMOjLZnXeQ9secLJ/7lMYWmHI1Dw42kyndUxQU7wx0FCld5TC eCacYWfVfpVLEnau9xS3+EJGR57OzecHV+sWMyUZjVU6fn7KkyudZrNi3S9iRm8N T4qbb4ll+IDmGLBaLgjrfBes52JaMRNGUBq1ytnabUYHDRJjTNu2q3luFxBPmD80 WDqqc1eogCqglCsRo55zKpzmUJmrhitgy0/cPAYMiCk/yWtm4aHJMM2j0bAz317q BaIaUfrEYb7+XFv5EAi+7zQyAhfBNud7+vea0EFdGoyVVv/Be8xl0554VQyg8kr0 gJHmTIc3HndQmgEnhc8PxXqR4aQS3QXdU/CgroSLI1mDxuLpJh1fd5/Tcr/Ihw+S k1AfXqjSAGxWLVruuE6Nc22+Cms2k+uWoFzPOTH0353miJbf+h8bg1H0Zfi8Ir1d kGLcWWfgQlLM96/CRPIMaZuxwc9WcSzALR5jmvO6slkk1MfJP7Lwx0jJ6DfySUoH 65eECT2VYI48MPuGuO/P7JUYltStraveL0XApLtCjlbZ/NJqlAa+s3L1329An1Cz mf979EbT/QscMDifsRqWRaiBM1L18Az4u2idSk4hSsRWHVyQqhsywIybJVZZt8Gz VM90OqfaxJum+SI= =xNvv -----END PGP SIGNATURE----- --=-=-=--