From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1oQb4Q-0001tl-Hv for mharc-grub-devel@gnu.org; Tue, 23 Aug 2022 17:04:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQb43-0001px-DE for grub-devel@gnu.org; Tue, 23 Aug 2022 17:03:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:34382) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQb3y-0001Cm-Ri for grub-devel@gnu.org; Tue, 23 Aug 2022 17:03:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661288633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Qk4ZxSRYv0xyvK52+dSYeZLVkTZHncuwZDarMz8+fHQ=; b=bLv10AYRKtzQxJnyUpk2YNp7kD0qwlPfKNZxhkt8qu2zOOAzpfVHfReE0fvi0mWP6vavIJ y1taFsUOFWh0CNyXPqeF/wi8skjdPufjTfxgKd0qRFPCaSvS6xrBgu0Ex4U9ZWwfbye16W xGnEFl9PLNSSzhTDgnc9qhp2PFiOdfg= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-121-lBd3o2wAOtGElX_ihRGd6A-1; Tue, 23 Aug 2022 17:03:52 -0400 X-MC-Unique: lBd3o2wAOtGElX_ihRGd6A-1 Received: by mail-qv1-f70.google.com with SMTP id dh19-20020ad458d3000000b00496bf7e4a72so7564714qvb.0 for ; Tue, 23 Aug 2022 14:03:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc; bh=Qk4ZxSRYv0xyvK52+dSYeZLVkTZHncuwZDarMz8+fHQ=; b=nrukepp1zTq3frwjrwO0y6qVfqXr8HqBr8kYbVNVM0149v48HxXjz5oXkMfU56Yztn kNxofd7QbAYtVA9Tbiisd7y4SHDSnGmi0fc40d6iMLKEfDwtSmgejKBTjV5XHj6/ScUQ aJtZY4XLpu/TT7f1xe8sjOA4JrPIqJlxr9baeWVFIKVuiQvEaZOcNUwUBBCWyakMX7z4 UqyucGfZWiuINdenXKoBxpLRHRMT4zPFMZ++XdtcrJ2cFyBInsvp0VwklxdqOf2mgJnu x47bPcBLpRqTcPBmQtdZ/Nt3yrQekn5J7ACSSo5oga29AwBXw7/svA8jDlzEs6sICM8V 1cWA== X-Gm-Message-State: ACgBeo3K7T7n3e9APCoHjqruYJ8r+3SlBy3+8BbthcrtzuvQLgvnlqLP KORoISESrfveSQMCfjl6ELAUX6u8PrjnY/gehBdcP1fXCNPU2Q2zi/aP2YvkHP+qQfibTPiFJ7+ VJwLA0ajuezY= X-Received: by 2002:a05:6214:f25:b0:496:d0cb:ac8f with SMTP id iw5-20020a0562140f2500b00496d0cbac8fmr13466784qvb.54.1661288630915; Tue, 23 Aug 2022 14:03:50 -0700 (PDT) X-Google-Smtp-Source: AA6agR5Jq8q/R6IHLPjayeyfLTE5TSLblosGoj+l524UB0uah1sGbaZhLQMM2lDHK2f8EJPzoXWT+w== X-Received: by 2002:a05:6214:f25:b0:496:d0cb:ac8f with SMTP id iw5-20020a0562140f2500b00496d0cbac8fmr13466735qvb.54.1661288630455; Tue, 23 Aug 2022 14:03:50 -0700 (PDT) Received: from localhost ([2601:184:4181:74c0:862e:5809:ed9e:e10e]) by smtp.gmail.com with ESMTPSA id h13-20020a05620a284d00b006bbdcb3fff7sm10681288qkp.69.2022.08.23.14.03.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Aug 2022 14:03:49 -0700 (PDT) From: Robbie Harwood To: Daniel Kiper Cc: Raymund Will , grub-devel@gnu.org, Javier Martinez Canillas Subject: Re: [PATCH v2 1/1] Add support for grub-emu to kexec Linux menu entries In-Reply-To: <20220820112310.f6qrzk5krd4nznwy@tomti.i.net-space.pl> References: <20220719203934.319797-1-rharwood@redhat.com> <20220803152639.cne3dtxofhqakjqr@tomti.i.net-space.pl> <20220811180820.asy5a4h5rh3vfr4y@tomti.i.net-space.pl> <20220815131615.GA9135@suse.de> <20220820112310.f6qrzk5krd4nznwy@tomti.i.net-space.pl> Date: Tue, 23 Aug 2022 17:03:46 -0400 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=170.10.129.124; envelope-from=rharwood@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2022 21:03:59 -0000 --=-=-= Content-Type: text/plain Daniel Kiper writes: > On Tue, Aug 16, 2022 at 12:07:06PM -0400, Robbie Harwood wrote: >> Raymund Will writes: >> >>> Granted, the duplication of `--kexec` to signify "force it", might >>> as well be spelled out as `--force-kexec` (or something similar). >>> (But that change will provoke inconsistencies during an indefinite >>> migration phase, where pre-boot images don't match binaries in the >>> root filesystem, notably, when rollback snapshots come into play.) >> >> Passing --kexec twice (or --force-kexec) doesn't appear to change >> anything in the versions of this patch I can easily find. We could >> add > > Yeah, I think Raymund is talking about a bit different version of the > patch. Raymund, could you provide us the one which has that features, > and potentially others, implemented? openSUSE's version of this patch has support for that which I'll incorporate in the next version. >> the behavior you're describing though - Daniel, would that help with >> your concerns about it? > > I would prefer --force-kexec but if double --kexec is used in existing > environments I am OK with the latter. However, please document this > behavior in the GRUB's docs. Appears to be in use in openSUSE; I imagine they'll want that preserved. Could probably add --force-kexec as well if that's desired. >>> Config-overrides in `grub.cfg` in turn would be a nice addition, but >>> are relatively expensive to implement, as they'd probably need to be >>> parsed and split into an array for `grub_util_exec()`, right? >> >> Yes. It's inevitably best-effort, especially if we can't depend on a >> working shell. > > I would prefer to have "config-overrides" but if it requires tons of > work I am OK with existing implementation, +/- minor tweaks/fixes, > assuming its assumptions and limitations are properly documented. I think the reason Raymund and I are hesitant is due to the lexing of arguments. We need to split them to pass to grub_util_exec(), which means we need to know how to split them. And we can't just split on the space character because of things like --append - i.e., it can reasonably have spaces in it. Quoting also is a problem for similar reasons (and the suggested syntax uses single quotes). So I don't see a simple way out, but maybe I've missed something. Are there particular arguments you have in mind for adding? Maybe they should be made default, or have specific options. Be well, --Robbie --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAmMFQLIUHHJoYXJ3b29k QHJlZGhhdC5jb20ACgkQJTL5F2qVpEJsIw/7B+qcRXWHSBIZ0epR6fBneAEdZcQ4 JNQcoqI30AWJiwZjoyuWBbQ/vtzjP6Nw8OeFFqGqYW43Kf6UeqgcDY2G+pmsVknD cOQLsmPcMb9oyk2LI7EqVwgBInRpWFW5afpgOsXD+c6ZzbTVh9JSKZUS36yc1rku kkDz3nlMgliqFeosjvLq09GGy3csh3fEbdQ7jdvVnO+25o8m3+DGx1Gm0qcTUNQt /r6HkcZ45GKEQ9aIxss652YS3eFGuAx6oCOODMNr1ic/ioCD2szlO7CXVGMBFH7W SBLV3oL483h4e7erh8aVysgEC6YFR/8cbYI5tupS6FxbdfLZJsg0bjMN0VlFYdoj QNUsdeM/1umjEzbU9hxT6esZ32vq+bzBD42lAjXjW0bCYq6NsjZiA4yGl6iuSVOq /uwJuFJ4cQlDC8kQtmxY2JBBH89VSBMJ9nSJpeuXEOgK48sCmJ9Ox106funrGzTC b4tMr+0QCfJc9hlfrbY4dAItpF9D4yI+umVbYTKhJabGGiSVI2eNdsKmq8zSdu/E zBk2HcmY1AeTBXDygyZsJIGJjuOIoqZn3O6yss2LF/XiZfBemrzGoOHOGHS3O6N9 sVJiTjwmFsluvSXlaENd5HgFqukFCI7ipZHecFEXgyx3VERnv8td2heWSHYoF9kE sFUYr4dJlbGbu8o= =orW9 -----END PGP SIGNATURE----- --=-=-=--