From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nPqUV-0006Hp-Fi for mharc-grub-devel@gnu.org; Thu, 03 Mar 2022 13:47:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52486) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPqUS-0006DX-Sk for grub-devel@gnu.org; Thu, 03 Mar 2022 13:47:53 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:26439) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPqUP-0001g5-5o for grub-devel@gnu.org; Thu, 03 Mar 2022 13:47:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646333265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wiX/LFAlDXPMuCeYNNO8RwBZShDYrDMzoKRFmL30cRw=; b=A02pKxjOwZppaJNb0SNKall2/qVTKHC15hnwXvG9IsslAW/a4uiPzPSbAOitELzyQx5uo9 nLIP7Gga9B+j3oJfs5KPt8CsBB2kjp5X1JpKlGBVs8LIP5FwnKptj0ECgw0VGRMZxoudFS qqif1bxWTATHTyaPSYqX+R6lbambrzk= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-137-Gl379JP1N4uTPhdvR393Sw-1; Thu, 03 Mar 2022 13:47:44 -0500 X-MC-Unique: Gl379JP1N4uTPhdvR393Sw-1 Received: by mail-qt1-f198.google.com with SMTP id e20-20020ac85994000000b002de4c01eef4so4227876qte.22 for ; Thu, 03 Mar 2022 10:47:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=wiX/LFAlDXPMuCeYNNO8RwBZShDYrDMzoKRFmL30cRw=; b=aN0kEbJ8lAbkirxl2KrtTd0Osye8SBS0DaadeYAyGeHeXT72nbhmg3tBefuQXPueKl HoaMIVjcC4KRZtUdkNkT4bnd1VZNDQiO5meVOrlioadG+UWqLN4+EeNykhtH4vgftVFy BDLATTpv0B+c0BrVg+CDOgafMpJtYm4AyeOb7d+dC9C0YirzPGicK+Z4BsKl9OkcIz/a pymZYkGKXXd/msR38cvm/b0i7PK56AJWQZc4stwuY5hD9poVpgUx6ZSRLDxetw7w3ku3 3d2TqBI+POQGtrwCvx+mOPxxQ/nWOSBoYzfPOxW3LHTFZhCzsurESyZi73dPC+bXgHOF nsuA== X-Gm-Message-State: AOAM5301oWfzHn87q2JqheDljcNBl1Oky+99ki9Nt0NTo8A/YwwYMvVJ eUMrqjRgMm8NLZkq4bvkgxUv6oY/Nebj5rPAeTdSyfw3Q2uB0vBwCAAm7OYkSbgA/tDLeDQupFB px6tuy0Pg49M= X-Received: by 2002:ae9:e013:0:b0:608:5443:8f31 with SMTP id m19-20020ae9e013000000b0060854438f31mr386754qkk.352.1646333263546; Thu, 03 Mar 2022 10:47:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJxPtU0Ly62Wo8ESn95C5neha02cqU0aO03IHqlRiHBLen9Me4ckWAcgIYInGSNrDUYHVduacA== X-Received: by 2002:ae9:e013:0:b0:608:5443:8f31 with SMTP id m19-20020ae9e013000000b0060854438f31mr386718qkk.352.1646333262430; Thu, 03 Mar 2022 10:47:42 -0800 (PST) Received: from localhost ([2601:184:4181:74c0:862e:5809:ed9e:e10e]) by smtp.gmail.com with ESMTPSA id e8-20020ac85dc8000000b002de409f360fsm2034827qtx.76.2022.03.03.10.47.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Mar 2022 10:47:42 -0800 (PST) From: Robbie Harwood To: development@efficientek.com Cc: The development of GNU GRUB , dkiper@net-space.pl Subject: Re: [PATCH v8 4/6] Drop gnulib no-abort.patch In-Reply-To: <20220303113531.5843179b@crass-HP-ZBook-15-G2> References: <20220302190829.195337-1-rharwood@redhat.com> <20220302190829.195337-5-rharwood@redhat.com> <20220302182209.7244939c@crass-HP-ZBook-15-G2> <20220303113531.5843179b@crass-HP-ZBook-15-G2> Date: Thu, 03 Mar 2022 13:47:29 -0500 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=170.10.129.124; envelope-from=rharwood@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2022 18:47:53 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Glenn Washburn writes: > Robbie Harwood wrote: > >> If you have a patch that makes this work, I don't have a problem with >> it. However, I was unable to make that work in practice. > > Can you provide some specifics on what problem you were running in to? > Was it a link issue at build time? platform specific? Did it build > fine, but blew up in testing? Did you try using the linker options I > suggested above? No, nor am I about to. This is code that I have, that builds, that I'm submitting to grub. If you want a different approach, that's fine - you're welcome to write a patch to do that instead. I have built this bike shed and I *really* do not care what color it is, nor do I appreciate being asked to test other people's proposals for them: you're presumably just as capable of building the code yourself and seeing if something works or doesn't. This is v8 of the series and I'm pretty much done caring about it at this point. For completeness, here's what happens if one just defines to grub_abort without further modification: $ uname -m x86_64 $ ./bootstrap ... $ ./configure --enable-grub-mkfont ... $ make ... gcc -DHAVE_CONFIG_H -I. -I.. -Wall -W -DGRUB_MACHINE_PCBIOS=3D1 -DGRUB_MA= CHINE=3DI386_PC -m32 -nostdinc -isystem /usr/lib/gcc/x86_64-linux-gnu/11/in= clude -I../include -I../include -DGRUB_FILE=3D\"lib/gnulib/regex.c\" -I. -I= . -I.. -I.. -I../include -I../include -I../grub-core/lib/libgcrypt-grub/src= / -I../grub-core/lib/posix_wrap -I../grub-core/lib/gnulib -I../grub-core/= lib/gnulib -D_FILE_OFFSET_BITS=3D64 -std=3Dgnu99 -Os -m32 -Wall -W -Wshado= w -Wpointer-arith -Wundef -Wchar-subscripts -Wcomment -Wdeprecated-declarat= ions -Wdisabled-optimization -Wdiv-by-zero -Wfloat-equal -Wformat-extra-arg= s -Wformat-security -Wformat-y2k -Wimplicit -Wimplicit-function-declaration= -Wimplicit-int -Wmain -Wmissing-braces -Wmissing-format-attribute -Wmultic= har -Wparentheses -Wreturn-type -Wsequence-point -Wshadow -Wsign-compare -W= switch -Wtrigraphs -Wunknown-pragmas -Wunused -Wunused-function -Wunused-la= bel -Wunused-parameter -Wunused-value -Wunused-variable -Wwrite-strings -W= nested-externs -Wstrict-prototypes -g -Wredundant-decls -Wmissing-prototype= s -Wmissing-declarations -Wextra -Wattributes -Wendif-labels -Winit-self -= Wint-to-pointer-cast -Winvalid-pch -Wmissing-field-initializers -Wnonnull -= Woverflow -Wvla -Wpointer-to-int-cast -Wstrict-aliasing -Wvariadic-macros -= Wvolatile-register-var -Wpointer-sign -Wmissing-include-dirs -Wmissing-prot= otypes -Wmissing-declarations -Wformat=3D2 -march=3Di386 -mrtd -mregparm=3D= 3 -falign-functions=3D1 -falign-loops=3D1 -falign-jumps=3D1 -freg-struct-re= turn -mno-mmx -mno-sse -mno-sse2 -mno-sse3 -mno-3dnow -Wa,-mx86-used-note= =3Dno -msoft-float -fno-dwarf2-cfi-asm -mno-stack-arg-probe -fno-asynchrono= us-unwind-tables -fno-unwind-tables -fno-ident -fno-PIE -fno-pie -fno-stack= -protector -Wtrampolines -Werror -ffreestanding -fno-builtin -Wno-undef -= Wno-sign-compare -Wno-unused -Wno-unused-parameter -Wno-redundant-decls -Wn= o-unreachable-code -Wno-conversion -MT lib/gnulib/regexp_module-regex.o -= MD -MP -MF lib/gnulib/.deps-core/regexp_module-regex.Tpo -c -o lib/gnulib/r= egexp_module-regex.o `test -f 'lib/gnulib/regex.c' || echo './'`lib/gnulib/= regex.c In file included from ../grub-core/lib/gnulib/libc-config.h:36, from lib/gnulib/regex.c:23: lib/gnulib/regcomp.c: In function =E2=80=98regerror=E2=80=99: ../config.h:145:19: error: implicit declaration of function =E2=80=98grub_a= bort=E2=80=99; did you mean =E2=80=98grub_reboot=E2=80=99? [-Werror=3Dimpli= cit-function-declaration] 145 | # define abort grub_abort | ^~~~~~~~~~ lib/gnulib/regcomp.c:509:5: note: in expansion of macro =E2=80=98abort=E2= =80=99 509 | abort (); | ^~~~~ ../config.h:145:19: error: nested extern declaration of =E2=80=98grub_abort= =E2=80=99 [-Werror=3Dnested-externs] 145 | # define abort grub_abort | ^~~~~~~~~~ lib/gnulib/regcomp.c:509:5: note: in expansion of macro =E2=80=98abort=E2= =80=99 509 | abort (); | ^~~~~ cc1: all warnings being treated as errors ... $ git diff diff --git a/config.h.in b/config.h.in index 0fca0597d..8ad4aa0ac 100644 =2D-- a/config.h.in +++ b/config.h.in @@ -142,7 +142,7 @@ typedef __UINT_FAST32_TYPE__ uint_fast32_t; * a prototype for abort(), so leave this as a macro that doesn't take * arguments. */ =2D# define abort __builtin_trap +# define abort grub_abort # endif /* !_GL_INLINE_HEADER_BEGIN */ =20 /* gnulib doesn't build cleanly with older compilers. */ $=20 Be well, =2D-Robbie --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAmIhDUEUHHJoYXJ3b29k QHJlZGhhdC5jb20ACgkQJTL5F2qVpEJDzQ/8Di/61c2ShfAkeoSwYOmi1IbRjeaT MCImIGLkJnwBmeIrTYf9KV7qpV0J5FWFiZVeVsEnNZ/22TnbCwqEKNPpbU4MLnJl gg7yY/w4cz6h5GP5U1TtNy3RbfDVbm+IbBeVGvNw8UqoN6tcyq0LygyXI6v0O+kz MYcxXzWudoYCrXCUd5cN5se4E5RxtQLaEb38A1aXQcvlLOWJ8DHPaYS+BYK/dJby +4eG/+VntyDyDND0VaWp8Fc5i1HgS9B6jUMP2KjqjREuVsg1nDbS/0xaQTnqP8kZ 3puRkJWWXwKAeSNsc3Y7CKW5iw0FA1vHBUnrEwrjhnjBOoSxryjsK7CE0p+8h0+T 44WioQTlqDIQrw3HU67Bjlke0Z2viQXDnEuZpE5rfUbgNcCP95Qbu3D56hf6BGM9 UWDOdgMi0LvqD35CANNdqHqYC5uY968IjL3hkObuO9vdfjVBzL0SxG/42H8sA3b7 iGcQDvf7mThqjDmXOSD7C/Ub55Dt1ologf5jmmin1A/FqzLXnFJDId/ncG0pNKLk NWt/nKZeS9ThQXkOW+WlHmiISTP7ijWu0clwJz5+9/H/hWMocSaWGGrYxUFTjPr1 OzhcA4lbmI0XGEZ9F2lf8bQxOVktPrEmx2BlJodlb2UpRU6lah6NUsfW+7ZHXb94 0XMJaXDoxZTeuNA= =cgVz -----END PGP SIGNATURE----- --=-=-=--