Re: [PATCH 2/2] EFI: console: Do not set cursor until the first text output

[Robbie Harwood <rharwood@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]

Javier Martinez Canillas <javierm@redhat.com> writes:

> On 1/28/22 12:43, Hans de Goede wrote:
>> To allow flickerfree boot the EFI console code does not call
>> grub_efi_set_text_mode (1) until some text is actually output.
>> 
>> Depending on if the output text is because of an error loading
>> e.g. the .cfg file; or because of showing the menu the cursor needs
>> to be on or off when the first text is shown.
>> 
>> So far the cursor was hardcoded to being on, but this is causing
>> drawing artifacts + slow drawing of the menu as reported here:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1946969
>> 
>> Handle the cursorstate in the same way as the colorstate to fix this,
>> when no text has been output yet, just cache the cursorstate and
>> then use the last set value when the first text is output.
>> 
>> Fixes: 2d7c3abd871f ("efi/console: Do not set text-mode until we actually need it")
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

Reviewed-by: Robbie Harwood <rharwood@redhat.com>

Be well,
--Robbie

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]