All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robbie Harwood <rharwood@redhat.com>
To: development@efficientek.com
Cc: The development of GNU GRUB <grub-devel@gnu.org>,
	Peter Jones <pjones@redhat.com>
Subject: Re: [PATCH 2/2] Make a "gdb" dprintf that tells us load addresses.
Date: Tue, 19 Oct 2021 17:08:59 -0400	[thread overview]
Message-ID: <jlglf2o67tg.fsf@redhat.com> (raw)
In-Reply-To: <20211015222557.4a578efe@crass-HP-ZBook-15-G2>

[-- Attachment #1: Type: text/plain, Size: 978 bytes --]

Glenn Washburn <development@efficientek.com> writes:

> I don't think we need to agree (that is for you to agree that the issue
> I'm describing is something to be concerned about). However, like I
> said, I think we can both be satisfied by not leaving out the file:line
> and to prepend "\n" to "add-symbol-file" so that it will start on a new
> line. So I'll ask again. Is my proposal an acceptable modification for
> the need that you have?

No, this is what I was trying to explain.  There's one add-symbol-file
line per module.  If there's no file:line, you get something like this:

    add-symbol-file ...
    add-symbol-file ...
    add-symbol-file ...

This can be directly pasted into gdb.

Your proposal results in something like:

    dl.c:694:
    add-symbol-file ...
    dl.c:694:
    add-symbol-file ...
    dl.c:694:
    add-symbol-file ...

You can't easily copy-paste that into gdb.  It needs to be processed to
remove the file:line stuff.

Be well,
--Robbie

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

  reply	other threads:[~2021-10-19 21:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-11 18:48 [PATCH 0/2] Print out load addresses for .text and .data Robbie Harwood
2021-10-11 18:48 ` [PATCH 1/2] Add grub_qdprintf() - grub_dprintf() without the file+line number Robbie Harwood
2021-10-12  6:14   ` Glenn Washburn
2021-10-11 18:48 ` [PATCH 2/2] Make a "gdb" dprintf that tells us load addresses Robbie Harwood
2021-10-12  6:29   ` Glenn Washburn
2021-10-14 17:09     ` Robbie Harwood
2021-10-15 20:24       ` Glenn Washburn
2021-10-15 20:55         ` Robbie Harwood
2021-10-16  3:25           ` Glenn Washburn
2021-10-19 21:08             ` Robbie Harwood [this message]
2021-10-19 21:57               ` Glenn Washburn
2021-10-20  6:45               ` Thomas Schmitt
  -- strict thread matches above, loose matches on Subject: below --
2021-10-16 17:48 Michael Schierl
2021-10-18 20:29 ` Glenn Washburn
2021-10-18 21:04   ` Michael Schierl
2021-10-19  7:06     ` Glenn Washburn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jlglf2o67tg.fsf@redhat.com \
    --to=rharwood@redhat.com \
    --cc=development@efficientek.com \
    --cc=grub-devel@gnu.org \
    --cc=pjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.