From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nD7up-0000lx-Gt for mharc-grub-devel@gnu.org; Thu, 27 Jan 2022 11:46:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35134) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nD7un-0000i9-Sf for grub-devel@gnu.org; Thu, 27 Jan 2022 11:46:30 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21626) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nD7uk-0000RV-AQ for grub-devel@gnu.org; Thu, 27 Jan 2022 11:46:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643301972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L7uRDWxx5+YOM5Kvqg153YsWgCguxiwT7+6IvxE9Zwk=; b=PtR6kK18w66Vq3bG5FCI8xLN7okWZfNyMoqr4AY4eu3yEcRZcncX3MUTesyo64Y7TwtNP4 jhaZx3IIjEfE/8iD/+OJiCxy5v9QftBLNgzeXG3xif8xd3c1W3XhyYXFvxeLzzN8bgUfRw UlE4HaB8GieUWdOUsCAKXrUAWXPY50M= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-134-pgxNt1d0MT6q5f9yN43Nmw-1; Thu, 27 Jan 2022 11:46:09 -0500 X-MC-Unique: pgxNt1d0MT6q5f9yN43Nmw-1 Received: by mail-qt1-f198.google.com with SMTP id y22-20020ac87c96000000b002d1bfdbd86dso2599309qtv.20 for ; Thu, 27 Jan 2022 08:46:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=L7uRDWxx5+YOM5Kvqg153YsWgCguxiwT7+6IvxE9Zwk=; b=nrS5vVz7kUVZhQ9+HD0wOI+QuV1++Xq+acWDrNV2OBmJ+8SmdSlmUZV/FSOrVYAp92 ANPV3P0QduFkFENsG3qWfR7pW7eWr5CI52m0Zfj6kJkBpBHFAmtzkl5tO0H+bhZhN1Qz K8Bm2HRMSPTPeBVViEwXHKI65gyDL1OphI5bgQsW+t28KHjdJ7w1vu4eUocqrCn3m6+A H//hCZCcqi//Wxkjl21Vob7/qmx04cadLpIxczaCy4uyiOVgqqF9ZDnB9TrZ0/OkjUH0 NRdCFnVU7TWHnbM+zvSLZYZVcpF9Ku1bVaYACezcwdbYdcf212igRPFlDakJPtogRG11 QL4g== X-Gm-Message-State: AOAM533Syr7Ep+LFSijxTqtC2cNMgNFhA9dHabe9LKvOIQahsUsFSuVF ZW9qQW/w2nArUoAylHN+BkRAsMSOUmmiuKPHB6WYFsHG6ZljBrZ56SAeI7FHqxcOUIbujDXOMuH cGBI8eBKGGJE= X-Received: by 2002:a05:620a:21d9:: with SMTP id h25mr3351738qka.322.1643301968584; Thu, 27 Jan 2022 08:46:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJyO2Oa7mfzP5sIqkm9nFFmIF0dFyd7OamLsrABCiv96Ns6AfU4CzTyEttDAjt9qrVXKA7wZ7w== X-Received: by 2002:a05:620a:21d9:: with SMTP id h25mr3351694qka.322.1643301967887; Thu, 27 Jan 2022 08:46:07 -0800 (PST) Received: from localhost ([2601:184:4181:74c0:862e:5809:ed9e:e10e]) by smtp.gmail.com with ESMTPSA id s14sm564035qkp.79.2022.01.27.08.46.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jan 2022 08:46:07 -0800 (PST) From: Robbie Harwood To: development@efficientek.com Cc: The development of GNU GRUB , dkiper@net-space.pl, darren.kenny@oracle.com, ps@pks.im, dja@axtens.net Subject: Re: [PATCH v2 0/4] Update gnulib and drop patches In-Reply-To: <20220126205548.7054a4ff@crass-HP-ZBook-15-G2> References: <20220126220912.84413-1-rharwood@redhat.com> <20220126205548.7054a4ff@crass-HP-ZBook-15-G2> Date: Thu, 27 Jan 2022 11:46:04 -0500 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=170.10.133.124; envelope-from=rharwood@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.159, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jan 2022 16:46:30 -0000 --=-=-= Content-Type: text/plain Glenn Washburn writes: > Robbie Harwood wrote: > >> fix-width.patch has not merged upstream. A version has been >> proposed, but would need significant rewrite. It doesn't seem worth >> the effort to carry, and once this changeset merges to grub, it >> becomes easier to increment our gnulib version if something like it >> ever does merge there. > > Thanks Robbie for updating gnulib, this is something I've been wanting > to get done. If I'm understanding you correctly, fix-width.patch is > being dropped but there is not replacement for what it did. All good questions. To back up for a moment, my original plan had been to wait longer and see if we could get a better version of that patch accepted into gnulib. However, we're accelerated from that now because us using an old gnulib is holding up other efforts (and according to my bug mail this morning, is needed to build with newer gcc/glibc). > How was this patch functionally being used by GRUB? And what will the > effects be of dropping it? Looking at the patch maybe one of the > places its used is in GRUB's help command. If so, does that mean that > line wrapping when printing help will be affected? Not totally clear, and there's no commit information to help. Mostly it seems to change gnulib's width assumption to be multibyte-character aware. I think this could cause lines to not wrap early in locales that are mutibyte-heavy, but I don't actually know, as I don't speak any languages that meet that criteria. gnulib upstream pointed out that this is only papering over the problem though: it won't work for Chinese, for instance. (It also won't work for Thai, but there's nothing that anyone can do there.) I could be wrong, but I'm actually not sure this affects grub at all. We're not translated, which I think means that every character we put in a help string will fit in a single byte under UTF-8. Be well, --Robbie --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAmHyzEwUHHJoYXJ3b29k QHJlZGhhdC5jb20ACgkQJTL5F2qVpEJ93BAAxXH3XE63jUiSpSnrWXbrl4rOvE4G zZ3kWMj3shLZwGaCeuuR8UN8dsc4CYVZQfD7ICHXXUcTyC2dyPTOKSuFvqvRKKH8 UHT9McS8I1l89S8e4mdN+bdHzbJ7DDOeOL6VX1D0+4/icrYHqmncll3WTTxiKFS0 Yoy5aHRN0hZ/Vhc3redYUAvmu+HESrGiZquG6/B6A4gmfkCykNr+0MMO10BOlK5e OeZko7dhHmqNJ4eD9EDY5EMNN4UVAl0lq2j4xSpc4KDdcjNkMm8CfZPDtQH8E7b6 SeGsTDc/13eXL5/i/ydF6+9xk8xEc/r59at9k8u+6RcfHYtPJSQ0fWKfxi8GJZzU mi95QCQyTLlViEhYn037k9SOq2/E75TeI8/SWs6JtTUzHzRGOZETuoyNITS01yK5 W95htNnNjwoaWzCNq2Qb+q3OWi2LVtKkhbpX8mH6V5foLy83xBoD3QqSkI45sSYI VAfQC19VmuaL3ePfV50KrMOAZM/O/GZHX1pEhnWiUQQIdFgvAAWhBn8/uIMe41u8 gIK6Ffion1w6dEvhpgGSuc4/ZUClMePWgkTFQzj5MSFk20o+zoTDUEy4UQ9WSWNC bBceJ9eL+JtjTEY5wMcxr9g+PhI5gqH1FOcoKaQUY2dekKGEYhQaKufTW2lu2T7+ f0ctmbQnrc+ii+w= =hbjX -----END PGP SIGNATURE----- --=-=-=--