From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mpYM1-0000eU-Sw for mharc-grub-devel@gnu.org; Tue, 23 Nov 2021 11:09:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpYM0-0000Yp-8A for grub-devel@gnu.org; Tue, 23 Nov 2021 11:09:08 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:30420) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpYLx-0000Ye-Qw for grub-devel@gnu.org; Tue, 23 Nov 2021 11:09:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637683745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7WIfB7Ru5RUXQKeuSCQRtpO3RYKH2/AiirkF8Iu+pzY=; b=izRKfDprgEU7hJd+5oWiPuAbT5xYxv8wm7rz2KrITh02/MijtTLmS/myZgLXVQMNfSb4SZ SjpyNtmMxFxFjferNSmA+iIHCWeGerBzpxDvBtIQy4uIPeXpp7WLHlGVU1dwuijwLl6zph ldOst3nttuvrUqYcs67Zvfyr/Bf2ICg= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-378-OWPsQozcON2e6I-NpcG3cQ-1; Tue, 23 Nov 2021 11:09:03 -0500 X-MC-Unique: OWPsQozcON2e6I-NpcG3cQ-1 Received: by mail-qv1-f69.google.com with SMTP id h14-20020a0562140dae00b003ae664126e9so19432959qvh.3 for ; Tue, 23 Nov 2021 08:09:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=7WIfB7Ru5RUXQKeuSCQRtpO3RYKH2/AiirkF8Iu+pzY=; b=j+exHGxcIfiENhQgI7eNFJOH6B0ItsdowK2QiGs0HmBkRVm+rBt6eK5tKmvGTDbHiJ mX69GzXKdmnUHbpLX8MWX/EdECZev16cUgNQ4yXyyMtsPd6q8PKPhxPajQ6+xPSs3Zbg L/4P7+J5XQIK4qEjV/y5cGCmZUANtW+sY6hZgZZ8dKTmQSPfMTejI7YhUJhFRKlBoRuU mq6Nc9d4vC184GAYc9WlLz8nXuNFBVUCvGSnai3+HsRpo1W+JYe2DBL70zS5BsZeYoI2 lNJhETrPaik1twXUx243XBN98E+bERSX4+22pQCFbP9lzvlCowShX+vWNrmm6qkhDZa8 WU5Q== X-Gm-Message-State: AOAM532h2PQeac3gwi+Oo1BSli1YFL5H8Rkbo7VhV3tEXkzHj28PTtTX 6H3pRgWxXxTpGnAkDdMSh+23OFeZMfRSbGR8L+o2/SgjWoBtsGUHlGftf25iRenBr6K10T1S06+ yhLqxe/R+6kQ= X-Received: by 2002:a05:622a:c8:: with SMTP id p8mr7515983qtw.52.1637683742456; Tue, 23 Nov 2021 08:09:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJwjmA6I1VXVPpDHGLWKBpWPh18Npp+dwueL/uQWAaoB8seJVlYAbEM9oRdDcPvf4G3d41x2lQ== X-Received: by 2002:a05:622a:c8:: with SMTP id p8mr7515899qtw.52.1637683741766; Tue, 23 Nov 2021 08:09:01 -0800 (PST) Received: from localhost ([2601:184:4181:74c0:862e:5809:ed9e:e10e]) by smtp.gmail.com with ESMTPSA id s2sm6317542qtw.22.2021.11.23.08.09.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Nov 2021 08:09:01 -0800 (PST) From: Robbie Harwood To: Daniel Axtens , grub-devel@gnu.org Subject: Re: [PATCH] Drop gnulib fix-base64.patch In-Reply-To: <87wnkydgyk.fsf@dja-thinkpad.axtens.net> References: <20211028192227.351582-1-rharwood@redhat.com> <87wnkydgyk.fsf@dja-thinkpad.axtens.net> Date: Tue, 23 Nov 2021 11:08:55 -0500 Message-ID: MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=rharwood@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=170.10.133.124; envelope-from=rharwood@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2021 16:09:08 -0000 --=-=-= Content-Type: text/plain Daniel Axtens writes: > Robbie Harwood writes: > >> +/* For gnulib's base64 code. */ >> +#define _GL_ATTRIBUTE_CONST /* empty */ > > Do we support any compiler so old or configuration so weird that we > can't simply use 'const' here? Unfortunately it's not quite that simple. _GL_ATTRIBUTE_CONST actually gates turning on `__attribute ((__const__))`, which if memory serves is a GCC extension. I don't know what the support matrix on grub is, but based on the original patch there was a need to support non-gcc-likes. Would be fine with changing that, though. (Personally, I think it should be obvious to a reasonable compiler that isbase64() is purely arithmetic. However, gnulib upstream did not like my proposal to drop the attribute marker, so we're stuck with it.) Be well, --Robbie --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAmGdEhgUHHJoYXJ3b29k QHJlZGhhdC5jb20ACgkQJTL5F2qVpEJylxAAj5OeBAobBG96UtQMvY/VBOZVfXjL E2t/I91KuiHerJQUMRUvTVvbrtDfuipAS4hCb19MBlLCxUVElVq41ohEx1Lhrmyi LYfz2aWuuQoI/4ZRnuAOF2I+VVeDy6jPLx0le5E+Wamq1V9rUmUMlfh5CVby5FPh 4334kl/t+fDWWEWY3lEZBLVNl2id7xlJKRYEScCqjSCpCG6/rPgAKry1gtQAHNsF P+C693PNDzvPAZfLlB1xegKZfa+W7/qAzkOiGrSqcSly+NvuOLLqdGlvn6KtvxL8 Z4wm6cYGTJtLYr164hku7Nteoj9mUHevNY+trH3MD/I/ZeoFzzN8858CZG+0YDY5 RhZqN22sa0FaEOKCe6xgApywtdKKFgpUL+Xr2y5Err0m3xlLpfK2uMyZcP6YOR+s 1oxKrfB/CFC1hrRzxcGeYrj3Wh4auvp0Z9AFlC/ZSxc+jI5QhFyPsWkXN3bCzbcv i7OE6rW/BSaePPdVjoAHVMdRumgoK2ktpS/nQcN846Pk+ghSG5lKcMk0by8bfcW/ e9gwRLjJtbp+sH7NN0pau0PN98acVc6iL3tEsUdNej3nkmENX9Ia16ra11AtCSGH 4nVq+ZcvDeKlRdrkQC4j44GN0pyNq47ACdcnQL3BkXObN3qZfdJHV9AtxoZgESOr YCod5gzJ5nhHLqA= =Ctg2 -----END PGP SIGNATURE----- --=-=-=--