From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nuKhY-0004U1-75 for mharc-grub-devel@gnu.org; Thu, 26 May 2022 17:07:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuKhW-0004To-Du for grub-devel@gnu.org; Thu, 26 May 2022 17:07:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:44509) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuKhS-0003aX-B8 for grub-devel@gnu.org; Thu, 26 May 2022 17:07:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653599236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cMjEcIImsltN3enM3822EmyDYOY0IhRwF4R9RCNOK24=; b=ZN4j6sFlITgEnye+nQ2aS/7NY/RM10vPpVECKdPnIzRjN+aQyL2KPj6p+Tkvy6AUOGjBFH iRxr5anA6YJE8WOj7b4ECqh+m5dckesqFQcZq6QDGuHFYQEHOCmCxXi5J9k4PJ9lP8Rut0 H2f39OOnqMiflVtAgv1XgVosASykHcA= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-395-aIScB0OcPtSVXsCwA50-bQ-1; Thu, 26 May 2022 17:07:14 -0400 X-MC-Unique: aIScB0OcPtSVXsCwA50-bQ-1 Received: by mail-qk1-f198.google.com with SMTP id m26-20020a05620a13ba00b006a32a7adb78so2454112qki.10 for ; Thu, 26 May 2022 14:07:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=cMjEcIImsltN3enM3822EmyDYOY0IhRwF4R9RCNOK24=; b=O2qaVh4C35+7mgEwlChaDILZK173BNcTcexPFnyfc9Um/XumQIYqSHoI/2vIl+lwqV 9093qDTwfq+4Jn2po9HubP+DlNHTBd+YzI/F5yzwg2KkFJVZElv5BtTQFNAbIdEwBtZO h+XKRNiDtTtFxVfrxZialVrU612vfg/0vT8ER+IhKaEXruoxzT7z5ZEhA+aQjcSqQN7S DNtQniZsyyfIE4u72RVEDtn9KgkMJQto9wx3ynqKJaNfXjUkSHkcnnu3nERQa8J+FXsS nsNYLfQrH8fy3QkqyN77hMb/anKA/y7gZVWnlHyU/+/KmBs+pG5EgkVQjG0fQyLhL7Mu wK1A== X-Gm-Message-State: AOAM531ImX94Ng+hS/HzsD6D210NBkoSjllRZ4fyzS0tN944j0RnfsVg up9E3Fb0XoG4nqcbUh8PGATMQw8DiAbF1QW2JztYht3s5s9qEJHRr34yME5nMdBJIzE7Xm4tHEV r7plAy8rcPzU= X-Received: by 2002:a05:620a:2442:b0:6a5:a0ac:ab3a with SMTP id h2-20020a05620a244200b006a5a0acab3amr6037728qkn.32.1653599233719; Thu, 26 May 2022 14:07:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxSNM77aE3h2Jqh7ogz3iGzQQphGRaVbVGMhNv/cPD1T4Rqr4YAjepvj/LLHohRd6skIRSRcA== X-Received: by 2002:a05:620a:2442:b0:6a5:a0ac:ab3a with SMTP id h2-20020a05620a244200b006a5a0acab3amr6037697qkn.32.1653599233263; Thu, 26 May 2022 14:07:13 -0700 (PDT) Received: from localhost (c-73-227-130-153.hsd1.ma.comcast.net. [73.227.130.153]) by smtp.gmail.com with ESMTPSA id a85-20020ae9e858000000b0069fc13ce257sm1709971qkg.136.2022.05.26.14.07.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 14:07:12 -0700 (PDT) From: Robbie Harwood To: Mathieu Desnoyers , grub-devel@gnu.org Cc: Mathieu Desnoyers Subject: Re: [RFC PATCH v3 5/5] Cleanup: grub-mkconfig_lib: remove unused version comparison functions In-Reply-To: <20220520143741.217690-6-mathieu.desnoyers@efficios.com> References: <20220520143741.217690-1-mathieu.desnoyers@efficios.com> <20220520143741.217690-6-mathieu.desnoyers@efficios.com> Date: Thu, 26 May 2022 17:07:11 -0400 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=170.10.129.124; envelope-from=rharwood@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2022 21:07:22 -0000 --=-=-= Content-Type: text/plain Mathieu Desnoyers writes: > There are no users left of version_find_latest(), version_test_gt(), and > version_test_numeric(). Remove those unused helper functions. Using > those helper functions is what caused the quadratic sorting performance > issues in the first place, so removing them is a net win. > > Signed-off-by: Mathieu Desnoyers Reviewed-by: Robbie Harwood Be well, --Robbie --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAmKP6/8UHHJoYXJ3b29k QHJlZGhhdC5jb20ACgkQJTL5F2qVpEIMXBAAlWf96HPRQE/KS1Gme2e6HnmJr7yt ZnwqzrJcYJDyJUv67QX9ej8b8/8AvClvl5oWsCdTkDAji488QRHvuKz3hTq5at4m vNSHORhxDVv75bun/KWCogZhb2eXSQ/pSafPxrSpl1gkcEkNjJw/B20mSUTHXutR pFuic4/a3FnsK9F0Jw4FGu5t10eE4xfOTYKKV9tr7tAOV7iNT93F4k36oqUb3nqV c5aCaaQUlnT/A4W8/ImQvVUrLJza/eQGRXkrDMtXCOa+01NyXkf9PJ1KaDyhvTRF vE+hn7GClWQ1Z1ZzZFoxsQmmVo2aF11t+aroQwrNyEaR3c1Po2lgyal+8KM2oDxx lDukUre1pYn325IRlvlohK/7d/c2DvBidsJk32tlyec8+AIg2GSIJ2jG4/VYaV8l W5GPIDRrBYay1mSmU2Q8ecjEsHl/SrY7N7pAK2ggOGRIpqwIGFDNMz5/Aw/yC4Pu C/AD24hurAjnJx9M2V3fSw218fLFZD7fy6yKiUHvOUz/xU73cleDvnCH7NEd4MOX 43IH9tGbebqEV9RWqilB1i0v7OmAlKnbwmK57C4vZWZlDDx3AQAZs6maQUQtH1uc aMCg4RFWgm49ELSmJ3Ks3+nh5YmQ09szMtu5b/4bOrPoE4EIrzkalhAxBea25x8o FI3HbSyqi/7Immc= =4ne8 -----END PGP SIGNATURE----- --=-=-=--