From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mv6a4-000143-67 for mharc-grub-devel@gnu.org; Wed, 08 Dec 2021 18:42:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43296) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mv6a2-00013n-Lr for grub-devel@gnu.org; Wed, 08 Dec 2021 18:42:34 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:32438) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mv6Zx-0007ZU-Oj for grub-devel@gnu.org; Wed, 08 Dec 2021 18:42:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639006948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z8e1suwf9t95Ugxr2siWmv6SEi9OAvqoKQXEoFI1SYc=; b=C24leeHjCDKf1wr92hvb19Ap1XUTtHcHaD0lTnQThhFenBy+L2hbJZslWxa1pMSVKqH5Pe lF3vFlP6nEXxdNy+VDoK/8MmMDNghLe9q8Jb1fYXRBt+LfqH48RnDupvDPEhsPDKrI0fv9 r6e6jmUtzF6PE8K79fVmGTYaCeliP2o= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-568-4McoNdBlOWCvVevvnk2wWw-1; Wed, 08 Dec 2021 18:42:19 -0500 X-MC-Unique: 4McoNdBlOWCvVevvnk2wWw-1 Received: by mail-qt1-f199.google.com with SMTP id h13-20020ac87d4d000000b002af9c496444so5832985qtb.22 for ; Wed, 08 Dec 2021 15:42:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=JiViYrIOtm5bJU34w9ix0qb/HtHKtTJX/xTG9MfQJsI=; b=oZWUdvenTTqV6vFOQGgfS7wkyG8I0XF9j/N4R+hAyjqfNTuCrIsq1qHeRZCc6gqM7+ O10DxdU4sKtvbHyRfMPST7e/inYlAr8R5IvVJtD26iHPwhxJskhYY/2uDglxRzvrPOT2 GzZ7lpKHkMyQXTOTQT+3cymTeBzCh9U5lM4OTl/nFxjjMoaNC31pm3YJOLLQJX0sEilc kV7SgtBvcuT7pmefYhIE8nOGUowVkeuIs+WozWiCuedUi5OuIJhPjjmbb54bO3fyhnOX kFenbPxugvxD5cHbFpz8Qv2t4H/V+uD3Jv7Q8OeawuyFdbcGD0OKxqIXoqbr293E9nf9 u4/g== X-Gm-Message-State: AOAM530yxLgly4fGez34YOWXdb6zdY1wkzP4pBNZPnshmmrslo6+BkwK P+vSTgTFPj4rIaFUYf4xtmNfdZ8yW2WEk2usR1fWFdGLU/A6IzqLilOlKPsFpLn1Or1leWj8ZD3 JVUDVJqPUdro= X-Received: by 2002:a05:622a:1a03:: with SMTP id f3mr12278416qtb.141.1639006938537; Wed, 08 Dec 2021 15:42:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJw3wv5nqFaXPJyCieTB8ZUa1sTN87diFPT41wIS/wljTHqCPPuz1kRetFwQYurbsMk/AKskqw== X-Received: by 2002:a05:622a:1a03:: with SMTP id f3mr12278332qtb.141.1639006937540; Wed, 08 Dec 2021 15:42:17 -0800 (PST) Received: from localhost ([2601:184:4181:74c0:862e:5809:ed9e:e10e]) by smtp.gmail.com with ESMTPSA id v21sm2682146qta.0.2021.12.08.15.42.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Dec 2021 15:42:17 -0800 (PST) From: Robbie Harwood To: Nicholas Vinson , grub-devel@gnu.org Subject: Re: [PATCH] Add Fedora location of DejaVu SANS font In-Reply-To: <4a790b05-53b1-bfd9-f5bf-8c54ef009185@gmail.com> References: <20211206222542.20068-1-rharwood@redhat.com> <4dff5c81-6efc-41b9-3ef6-52f63025ec9e@gmail.com> <4a790b05-53b1-bfd9-f5bf-8c54ef009185@gmail.com> Date: Wed, 08 Dec 2021 18:42:14 -0500 Message-ID: MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=rharwood@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=170.10.133.124; envelope-from=rharwood@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.619, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Dec 2021 23:42:34 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Nicholas Vinson writes: > On 12/8/21 12:58, Robbie Harwood wrote: >> Nicholas Vinson writes: >>> On 12/7/21 15:04, Robbie Harwood wrote: >>>> Nicholas Vinson writes: >>>> >>>>> Wouldn't it be better to modify configure.ac so the location could >>>>> be passed in instead of having one-off patches for alternate >>>>> locations? Something like >>>>> --with-dejavu-font=3D/usr/share/fonts/dejavu-sans-fonts? >>>> >>>> That would mean that anyone using grub2 that wants the dejavu fonts >>>> will have to figure out that the option exists and pass it to the >>>> buildscripts. That's a pretty bad user experience for anyone >>>> building their own grub. >>> >>> On the contrary, it doesn't have to mean that at all. It could mean >>> that when a path is given, configure would use the provided path; >>> otherwise, it falls back to its default list to find the font. >>=20 >> But then we still have to keep the default list... and I'd still be here >> as a distro maintainer wanting my distro's path in the default list. I >> don't see how this is any better. > > And you want it in the default path because? Most likely because you're= =20 > patching configure or using tools like sed or awk to change configure or= =20 > Makefile to use your path? You know that approach is brittle and you=20 > want something better. No, that's not it. Don't put words in other people's mouths. We're sitting on more than 220 downstream patches that I want upstreamed. The relative brittleness of this particular change is *nothing* in comparison, believe me :) The sheer number here means I'm starting with the easy stuff. The one-liners, simple conceptual things, *stuff that should be non-contentious*. > Adding your distro's choice location to a pre-defined list works until=20 > the distro changes where it stores the font. At that point you are back= =20 > where you started. Manually patching GRUB until a version of GRUB is=20 > released with your new path in the list. > > The same is true with any other distro that uses a location not in the=20 > list. The approach you're suggesting is that submit a patch, get GRUB=20 > updated. > > What I am asking for puts an end to that. Once the flag is in place, the= =20 > builder can pick whatever path is desirable, pass it into the configure= =20 > script, and have GRUB builds. No need to craft a patch, send it to the= =20 > mailing list, and wait for the update to make it into a GRUB release. But my point is this hurts everyone who's *not* the distro maintainer but building their own grub. That's the user experience issue I was talking about. Everyone developing on Fedora now has to remember another flag or it won't work the same. >>> Such an approach would mimic configure's current behavior for values >>> such as bootdir and grubdir. >>=20 >> But those are *install* paths, not *detection* paths. We're not >> installing the font - we're figuring out where it is on the system. > > In the context of building GRUB, bootdir and grubdir are *not*=20 > installation directories. They are simply default paths that get written= =20 > into the built code. Right, that's what I mean by "install" path. It's a place where you put stuff, not a place where you find stuff. > Effort is often times its own reward. I would not want to deprive you > of it. Wow, okay. You know this comes across as rather hostile, right? Is this really the approach you want to take when someone *shows up with code* and asks you to clarify your feedback? Tell them to go away and RTFM? Be well, --Robbie --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAmGxQtYUHHJoYXJ3b29k QHJlZGhhdC5jb20ACgkQJTL5F2qVpEKfBQ//fgDGCzH40qb4QuEDsSRLbrhIxr+2 hQIKc41y/IvnP4x0SWD/4DOEg8t18mb3aQW3IbGgY2Cf619e2Zt9VzVg8ZsB2G6P GMBXEO3E3YQ+AVJkoYB4N8ApK+/YyfM5Jb6sA+ZF7i1hBeHnCxD4Wk1+wjjMnv3D zmRTINsZJUsVv5yZyX62RWFkPHtdzisC4gCYSJ0Lp8SZO+IKuWNcY7g57ollwFCb 6wuuQm4QpPk1fFnl1LsnzHB2jddae8susDrNh3Z4PJVoHrR0WjSJabtgRmZWjvz5 MFbToS4sv5GYKRZRCDN9+llF/wLPNryTcFj7kudeT6s9lvgRsTxB7bwT8f4E/l4E BqaDwLWaWCTM3jmlIbMnejEtA688Jm7VLtU5vIbiLJQFy9vp/qjaBG94jC00raN/ DXtHRbWs05JcljQ71m3GkrSSsHyIK6c9JjX0FXhqsYrb/qhGA9vDbYjd9cHcuzCS bUh/mlzb5RsQmUlQacE0503ik1aZslpMxnDO8zO3G1+KO+B8Zf9NeIy+EoItNMEk QVZMX4XYv845UFealf77vqN1ourY64wZrYpC32pimaIlzm+sDuxEHvHsZZl6uru4 QKvbGq7HzF4h7BrIOPMkiHlXkFkES+55WjkUfRJQp6DeHbzi6P0WL1+xrgLHJGaw gyNPRKNWAhc/yL0= =myfH -----END PGP SIGNATURE----- --=-=-=--