From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nEazl-0003ep-F6 for mharc-grub-devel@gnu.org; Mon, 31 Jan 2022 13:01:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEazk-0003aS-3S for grub-devel@gnu.org; Mon, 31 Jan 2022 13:01:40 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:57617) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEazh-00085n-SC for grub-devel@gnu.org; Mon, 31 Jan 2022 13:01:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643652069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vOcIwxbvEvERQEn0BKAkfEayJTPXIyGfTRxj16V0SP4=; b=fPE/rAuAEqRrlusc/hWeXPbgVMbP7+rJlbOXZxZWRq3GOXSZuCppk3Cg8DXDmOd74t3nfr 9xlqPDMS3Merl52jYBm7mIQElAQ8Lq+X2wcRgeGpG5R36hpRomOWoiCxlCCxoVkgor4rEK 1OYR05V9t+FgQcbe7BSShgzSIlQnrgE= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-646-Lv6MtusWMqSrVfxKDSjNfA-1; Mon, 31 Jan 2022 13:01:06 -0500 X-MC-Unique: Lv6MtusWMqSrVfxKDSjNfA-1 Received: by mail-qt1-f198.google.com with SMTP id c15-20020ac87dcf000000b002d0a849c0beso10905797qte.16 for ; Mon, 31 Jan 2022 10:01:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=vOcIwxbvEvERQEn0BKAkfEayJTPXIyGfTRxj16V0SP4=; b=hR73O4oF7TMckX9DEi5Tejadp2TY+94veJyiCdyBeLLsY2a7KEuhDZyWYqD96f7Q07 zUlkPgS/mJLM04Ihd1LFOCfoKtY9drKeDBNZwgWQaDqZHJtLyhzW40L/mD7069G2gwbb zp5GMRtEq/i+ZkWq7v5vkFbdcoUU78FoxdDTXgjL8PUK3LeYyGKDml0hixf98pFMbJbq dbSEweDLDYX9aX8FAj976FRynPJSW2E8Nz8My6+tsGxsx73BywIPdLX8oFF/pLsnbA8Q Qy8tC8uXM66dfo7Rg2SR4VN73ehhVH9NnCgV8o0QrH3tM1oJYKTuXZB5hMXiox+sL/UW mWoA== X-Gm-Message-State: AOAM531yCbv/tUCiyZZ2rxHYO4YPxtDzULlFC0Q14WFkt6PYp/99chwP 5MIKaQoelABupdmQmleQ6SyeLBRfMf50s6ZOlwV+rECDje+QtiW3gu6gYpx2UWEI0Spgdiq1sfw U44s46F0BoV4= X-Received: by 2002:ac8:5950:: with SMTP id 16mr15544484qtz.141.1643652065587; Mon, 31 Jan 2022 10:01:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJzusxOf25HcW+LvCBm1Y7dLA5LTMFf+6RUaAqsDeYkB7t0DPpOBmzX/ktKKx0o3qA7vGenYGA== X-Received: by 2002:ac8:5950:: with SMTP id 16mr15544437qtz.141.1643652065019; Mon, 31 Jan 2022 10:01:05 -0800 (PST) Received: from localhost ([2601:184:4181:74c0:862e:5809:ed9e:e10e]) by smtp.gmail.com with ESMTPSA id y17sm8971866qtw.0.2022.01.31.10.01.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 10:01:04 -0800 (PST) From: Robbie Harwood To: Hans de Goede , grub-devel@gnu.org Cc: Hans de Goede Subject: Re: [PATCH 2/2] EFI: suppress the "Welcome to GRUB!" message in EFI builds In-Reply-To: <20220128103033.74343-3-hdegoede@redhat.com> References: <20220128103033.74343-1-hdegoede@redhat.com> <20220128103033.74343-3-hdegoede@redhat.com> Date: Mon, 31 Jan 2022 13:01:03 -0500 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=170.10.133.124; envelope-from=rharwood@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.088, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jan 2022 18:01:40 -0000 --=-=-= Content-Type: text/plain Hans de Goede writes: > Grub EFI builds are now often used in combination with flicker-free > boot, but this breaks with upstream grub because the "Welcome to GRUB!" > message will kick the EFI fb into text mode and show the msg, > breaking the flicker-free experience. > > EFI systems are so fast, that when the menu or the countdown are enabled > the message will be immediately overwritten, so in these cases not > printing the message does not matter. > > And in case when the timeout_style is set to TIMEOUT_STYLE_HIDDEN, > the user has asked grub to be quiet (for example to allow flickfree > boot) annd thus the message should not be printed. > > Signed-off-by: Hans de Goede Reviewed-by: Robbie Harwood Be well, --Robbie --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAmH4I98UHHJoYXJ3b29k QHJlZGhhdC5jb20ACgkQJTL5F2qVpEKgIw//WRnWEFGZB8goWv9dgKvEleleSE59 QIsQaVAHzlpL/UgNPCb4E6dYgvLpf2CEg2vQm+k9cxcO1mc3fhmcjuixPOGzIlEL t9JOuwrsM3r7yfxqQYQSspT6x5mL5T9blL2NZhLPPd+zJqUe2b7V5kdneQ7qkGkX ALs81p2uvzJgp5Nunki+owrfdJzYNt6f23ANSpyaL4AuOG0TxIURA/1Ohn+37Piq rzXjF769JXwZrzFdQmBKkmmf3OLsKbV1bleQxWoukVC6nKoBFtwd+fe9MGqne6/4 Ypx5wI0BttpTacYAT11xJ9X0LxAutjNT1MeTyi+cxYWmJvbu/37DxtXnxNXX+Xzi tijBSEB+b9AAulkF69SW7rPmpje5TkNHnISjSEpm5eaEKDI6wTD/Aq78M3MCZCmO jydzia71mdzUHRYk8uhm5XZZhRKAVWz48tbVunNpGGOp/GTg5Z5pcbXx9JtJH2RW dL+C5rhVjzCt6AS1MImc1a9sV6Fm/M30jOhfLyH5pgsT7ctz23Z0esTXO42NH2Q9 hsrA+Y3nbYkSbjbM3S6+N2kkv1PDT+qv4gGq5KHaMlz0YvFy45xo8JvwAYzxlZZ+ DUxZaaMnrJLdtdnVyt126YB4lphPCH/FjZ3SLdJlyUlk6z8UyOXkOTlVjVVbdorC GDevdfWWabD8VN0= =Hiaj -----END PGP SIGNATURE----- --=-=-=--