From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1phBsj-0007Dc-W3 for mharc-grub-devel@gnu.org; Tue, 28 Mar 2023 12:09:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phBsh-0007DN-VU for grub-devel@gnu.org; Tue, 28 Mar 2023 12:09:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phBsg-00068P-36 for grub-devel@gnu.org; Tue, 28 Mar 2023 12:09:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680019740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4tKuccTfOuqxTb5q8jEzosYVFUMw/q6FPDcYkep5d1k=; b=AyHPrbZ8Aid1vCFJYS9IA5GsXJIbp6+/TBq3sPDxYgZ7VVcRUPe+AXP1oPbZmq08se16H4 Fx5Fu+m1VYoQzX7tjb9izdEDPFjnxz7gTejTc+//f9STkRkhOEMyXRo6vK8YuYG+BVNSNv o4bxX/9yHrq7A41hmJgX309JnECY88s= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-215-UjFMZmPKP1qmtGoDDsDnhw-1; Tue, 28 Mar 2023 12:08:58 -0400 X-MC-Unique: UjFMZmPKP1qmtGoDDsDnhw-1 Received: by mail-qt1-f200.google.com with SMTP id a19-20020a05622a02d300b003e4ecb5f613so3039177qtx.21 for ; Tue, 28 Mar 2023 09:08:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680019738; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4tKuccTfOuqxTb5q8jEzosYVFUMw/q6FPDcYkep5d1k=; b=c2YmoZ7fZkRpHpW4dv52ipilOaIYel5PWxRfUPnRT+BIiPCaGKWfpsffoAaHpEb7uu cwRnK6z4sdu2x1aGeJA+d6uo8wjU155HENlHFBR9UH4eoxLo0BwyBvuhR/XxZjBXYinG sCihzfRCkZ/fTYQ9FEf8GX1eSVOahcygEGgmaWmyPxoKiIfTnOChXuZxBXdyWSjT9ZVR Ne0zKMGRHLQ+ez16qJgjKhOuNHQGCdJmrUWpozi3i7xejV7SinCiEj6xkOLDHpSXhaZ6 ypsltxaQJNIW0FQSoVEuvUX+Pa2A3jqYhPbaWJd334/GyGn8E33o00WrCqA+R7Nive+2 GAfw== X-Gm-Message-State: AAQBX9dWEmHae9xh5N2y6Hy1DGmtf4ZnVb/waClDY7Lfn2LRRopy2uPN H/tVFUL1K2LZxZ364Xs2W1l8M7kXAU+k4IVR+VSl2IJ2G++Kin12hbEbea/VzbHRDM/0BHYM7KJ w6BIo126iGNIj/PqGvGYdANRiuH5C7+MIDStdOs/Df/2B3vSNby2GHoufnnXgPzCXP6IpU3E= X-Received: by 2002:a05:622a:1104:b0:3e4:e9e4:5d0e with SMTP id e4-20020a05622a110400b003e4e9e45d0emr11684277qty.50.1680019738408; Tue, 28 Mar 2023 09:08:58 -0700 (PDT) X-Google-Smtp-Source: AKy350a5OZgjjOk+TLULn5k0MCjP+oscUES2NzRml9oXTw7zXFbPaoUGO7A1L+K10clu2zzgujSVcw== X-Received: by 2002:a05:622a:1104:b0:3e4:e9e4:5d0e with SMTP id e4-20020a05622a110400b003e4e9e45d0emr11684219qty.50.1680019737917; Tue, 28 Mar 2023 09:08:57 -0700 (PDT) Received: from localhost ([2600:4040:5204:6800:da7c:a2cd:3b13:a673]) by smtp.gmail.com with ESMTPSA id 204-20020a3708d5000000b007485a383921sm2843623qki.116.2023.03.28.09.08.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Mar 2023 09:08:57 -0700 (PDT) From: Robbie Harwood To: Michael Chang via Grub-devel , The development of GNU GRUB Cc: Michael Chang , meghanaprakash@in.ibm.com, avnish@linux.vnet.ibm.com, brking@linux.vnet.ibm.com, mamatha4@linux.vnet.ibm.com, mchauras@linux.vnet.ibm.com Subject: Re: [PATCH] ieee1275/ofdisk: retry on open and read failure In-Reply-To: <20230328083456.rxspg42vvmdfp6lh@lore> References: <20230328053001.90411-1-mchauras@linux.vnet.ibm.com> <20230328083456.rxspg42vvmdfp6lh@lore> Date: Tue, 28 Mar 2023 12:08:54 -0400 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=170.10.129.124; envelope-from=rharwood@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2023 16:09:08 -0000 --=-=-= Content-Type: text/plain Michael Chang via Grub-devel writes: > On Tue, Mar 28, 2023 at 11:00:01AM +0530, Mukesh Kumar Chaurasiya wrote: >> Sometimes, when booting from a very busy SAN, the access to the >> disk can fail and then grub will eventually drop to grub prompt. >> This scenario is more frequent when deploying many machines at >> the same time using the same SAN. >> This patch aims to force the ofdisk module to retry the open or >> read function after it fails. We use MAX_RETRIES to specify the >> amount of times it will try to access the disk before it >> definitely fails. > > To clarify this is a continuation of previous patch [1]. Obviously the > count of retries, MAX_RETRIES, has been replaced by a timeout, > RETRY_DEFAULT_TIMEOUT, which is 15000 milliseconds or fifteen seconds. > It appears that the description was not updated accordingly and needs to > be amended. > > [1] https://www.mail-archive.com/grub-devel@gnu.org/msg32174.html We carry that ^ patch basically as-is downstream. This proposed patch seems rather different: there's environment logic, more functions, etc.. As Michael says, it would be helpful if what's happening here could be clarified - especially since the description mentions MAX_RETRIES from Diego's patch, but there's no mention of Diego's authorship in the commit message, and no MAX_RETRIES in the code... Be well, --Robbie --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAmQjERYUHHJoYXJ3b29k QHJlZGhhdC5jb20ACgkQJTL5F2qVpELEjQ/+LwYokgP7MBHumsN26IsFyjKM6BUB SX7XcQoGfE+cB8SfcAPwB6WoCojYpgiiAdStfF3I2oWeKBSMRd0WAbHg3oMOOQkh ngxaYv6zYeaanxF8ZTQo9Q18y8nNO89oLG8l3aJnDzIdLygJfsTTpDVpCLDKan77 FGu/ZINHvU3uKilWNLSPNYHnVDUB9tSELlMLdOOqva4mvWMwIhrg9K5c9OzvCaPl 8kb0ppvKYgDbignUc6kAwx5QP3sW14h8VYF5HcVgq7FjmKENizqUMzg4+FVoQ9j/ kJeTduheZzrdAYc/n411eTBo8CS+zLQCIajI9R1pscSrLpuctZLot0dO3jUCBEeG HdBIUgwSuElhMG9YEtVTL5FpEK+SM2MUTdYfZ+R4z+O3xEBrbeSnIlzH0hdBeFPb qHu5dUDtM15S48JpC9iY+UZNrZCdMrwRR5iSa3W1G0n6gzJJSaP7NolDI0op3TFH faEov3eL93JKQVQ5W+ctzf9SyckiPdBFYAd7NvA+oNj3F/hxyRgpGS797XLOVjOv KHyGrMJtzOfojD4cWgnMkDJH3eNz+n5qUw1kLlaTTRRANBLsDO7ZOh8RFmfIHgL0 E+pjz6ZntoQI6Qw+fJLdu1NHhAld0KhO68AQSU05YCqiidHqvBkkbgQGAXKqPyUT dPLnNBceFagGg8s= =syby -----END PGP SIGNATURE----- --=-=-=--