From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1olb6i-0002nV-Us for mharc-grub-devel@gnu.org; Thu, 20 Oct 2022 15:21:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olb6f-0002mp-NA for grub-devel@gnu.org; Thu, 20 Oct 2022 15:21:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olb6Q-0002EW-6p for grub-devel@gnu.org; Thu, 20 Oct 2022 15:21:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666293672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2BdgxoDZ/+kzofxo6io2OHsObDwwv0n6ttiin+2AcCI=; b=Wq/8KqCgHT02F3cdEvfBXeMZsWPViyTEan0ZJlt66TbQCWSqndsFJENOkW8BDOFzgH6X3l vR7MTWwsALeu0ttAYUDXYWvFbREDAo1IHqRA87PcaEBr1+0avp8383zoqof7U2pe3jYcpY LvsuzNN5qBK0SPDezOqD5dRs3Cc91RU= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-246-SRKvPavGM9ibfIXRPTN2DA-1; Thu, 20 Oct 2022 15:21:11 -0400 X-MC-Unique: SRKvPavGM9ibfIXRPTN2DA-1 Received: by mail-qt1-f197.google.com with SMTP id d25-20020ac847d9000000b0039d0dd90182so355286qtr.3 for ; Thu, 20 Oct 2022 12:21:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2BdgxoDZ/+kzofxo6io2OHsObDwwv0n6ttiin+2AcCI=; b=3c+ZD8fYmnvm6DKs6NaCb87yDKc/h5I1lYEyOR0fgCy2GgTvFmTRUoaxSKMmkNcBsd o5bKh5FgBY3Nnags1XSUCuTcS6Vny4926TzeksWLL131Vi5oo3I9O3jbnP9+YKlCBDkK pocLAzDdcpc3VZiIZ5/PKqVlVJOO9u8HNDgKBqufsTRQNY31/uSqnQbqj50AWrltzTsP 7gIXJnvwruDr1mMf5Nz9bQsVoyX0b+jMPECy2cYVCKN2QvRqWBzly5IDUTbC6ea6wfyJ Q1VRaDugbLAxueQr3ybYFHtrw8eYKFOF1Frr8c6krjeP26tO963h32mlV9g0eSF+nYxU MdRA== X-Gm-Message-State: ACrzQf2rJERCoTo2ssED6sCd5o8DguNreuwLYH912D+4zLyd6rTSRwW6 jV38gn/CtI9PxfK5LyNLb/MsXm2VhuZpCwolY4AGmNMa+IRQ2SdwuK1dVmM93Ogn9otUJxEiy1a dld9Th1pYOiM= X-Received: by 2002:a05:622a:58b:b0:39c:fab9:3045 with SMTP id c11-20020a05622a058b00b0039cfab93045mr9860393qtb.26.1666293670637; Thu, 20 Oct 2022 12:21:10 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7A2My5UaV9zTxonR5VQJ+UthCqxPQaMk1MudZOmP3Cymzrs7DwW5pE6OxwfIw6KVx1ZI1mwQ== X-Received: by 2002:a05:622a:58b:b0:39c:fab9:3045 with SMTP id c11-20020a05622a058b00b0039cfab93045mr9860368qtb.26.1666293670253; Thu, 20 Oct 2022 12:21:10 -0700 (PDT) Received: from localhost ([2600:4040:520a:8800:7d1c:f0a7:5c44:ed0e]) by smtp.gmail.com with ESMTPSA id bq8-20020a05622a1c0800b00394fce5fa64sm6578270qtb.9.2022.10.20.12.21.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 12:21:09 -0700 (PDT) From: Robbie Harwood To: Daniel Kiper Cc: grub-devel@gnu.org, Raymund Will , xxc3ncoredxx@gmail.com, John Jolly , Javier Martinez Canillas Subject: Re: [PATCH v5 1/1] Add support for grub-emu to kexec Linux menu entries In-Reply-To: <20221020134130.q6b6xnph2kswxlfb@tomti.i.net-space.pl> References: <20221019185000.74493-1-rharwood@redhat.com> <20221019185000.74493-2-rharwood@redhat.com> <20221020134130.q6b6xnph2kswxlfb@tomti.i.net-space.pl> Date: Thu, 20 Oct 2022 15:20:58 -0400 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=170.10.133.124; envelope-from=rharwood@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2022 19:21:31 -0000 --=-=-= Content-Type: text/plain Daniel Kiper writes: > On Wed, Oct 19, 2022 at 02:50:00PM -0400, Robbie Harwood wrote: > >> diff --git a/grub-core/kern/emu/misc.c b/grub-core/kern/emu/misc.c >> index d0e7a107e7..521220b49d 100644 >> --- a/grub-core/kern/emu/misc.c >> +++ b/grub-core/kern/emu/misc.c >> @@ -39,6 +39,7 @@ >> #include >> >> int verbosity; >> +int kexecute; > > We have bool type now so I would use it here. Or at least try it does > not break other builds... :-) As written, it's not actually a boolean... it keeps track of how many times the flag has been passed, and that's how the "pass twice" behavior is implemented. Be well, --Robbie --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAmNRn5oUHHJoYXJ3b29k QHJlZGhhdC5jb20ACgkQJTL5F2qVpEKZLA/+OxjsGoYP2NGjq5tQ+uLsRp6FPw2a ZvwR7rks2NWMx25gVQVBs/vKXtnE5IR18qX6LuS05qpOl5coYAj7Vr2EGawUxgyQ ypt2XN7cKgmoyS6F8dlQ3vgjhrGU4jTOPk7Txf3MrfOIA3wXw1Z2CyH7UjUY8A6k aOdN0c/Ox7t5Aq8hYtmwntPGy6xmvmaMzu5NCxZk6TSs05E3BQn660pfVnNAws+Y /q714T+2rkxfF1alxBWvidiL7LvJLFhuHundLy59r+c/0ymknp+hUBSwT9dlxJvB +tK3bUeWk5jdxsQmW6aPtUniI7/mww9ehl3F0Lv0KvAR9Y+TQJJkIUdsXptXMiky 3SlpUEN01lZIe1FIlPxYsv6Ag2HneXhoyaHiCCA6IlgytYfroYaaghOhrx4rY2b+ joeK4u//POuWzqI7UuCErEK/xPdQuQArfJt8V0zI5m+qF9AT1fawXcx6WiP1+WAm qijE524gZyOulT2tmNY3r2w4TziAvGeaFDYp9NjzSTZiRPSNUPtCBnJ7VF6fnA7W eka+iu0mVI5TLMrt4rwcFiqpbhIcu98O4WoSgDB136WD4/bWlFs5Fw8v/Xqa0wjS HRPFxZAsUeeVYWR4xQXTsymGeIWciIxgU8Ip2cMFS0gZ5J03cHLYgM1e0uyGRQM3 0mORPlSxx4XPlfw= =yVpQ -----END PGP SIGNATURE----- --=-=-=--