From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nmGEa-0000jy-EB for mharc-grub-devel@gnu.org; Wed, 04 May 2022 10:44:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmGEY-0000ap-9R for grub-devel@gnu.org; Wed, 04 May 2022 10:44:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:26215) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmGEV-0005oO-Aa for grub-devel@gnu.org; Wed, 04 May 2022 10:44:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651675441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8IAhKjXtE/ZF509hL8512G9Vr2iCmS53oEWdKVbEiYM=; b=ZUEV6fa5sBD2qGuAVno6shfhkWJcreK6iYKGm2KRMJDWeS7vinEF+raVxD//8aZOliNMvQ rmOrfgpwOwQKlKcO9J1uPsfGkbkXnI/7OMZpKSYHD6oMu6B+DXHtRRYXcXPZhW4swLQM75 CydeGvR3iDAvWTUgAHcQdU8KD2js0w8= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-433-UGZGS4NDO_uJD-GiQmf90A-1; Wed, 04 May 2022 10:43:59 -0400 X-MC-Unique: UGZGS4NDO_uJD-GiQmf90A-1 Received: by mail-qt1-f199.google.com with SMTP id v7-20020a05622a188700b002f3a65c8ab9so1104105qtc.12 for ; Wed, 04 May 2022 07:43:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=8IAhKjXtE/ZF509hL8512G9Vr2iCmS53oEWdKVbEiYM=; b=YIxfWkxLpjpkSXahm+z1dDA9vfkjtEHcAbUNH5vOv9pcO2Af7DMQTyodP5MpuiUgcU uOxHtdvjmFtwnUuYXX2TOlNCiDnw+2+4/ol/qN6Cs1GpLTHN7RIQY/PovCojKNcdXMpm V5HhBn/ECFFIkI3nUbeHLP1ttmdMYR/NLZh/75XSt4FUm0DUnhBNjaenyEu8tReliiw3 LE+va+toDzYOHZDh16puGFUG7gKjjgyQcHIUf01KG9G8tpnPQMbd8osP0BWF30qAQotP gOU0a5jgW8s3N3pxExJvzX/sCY/xqTLcZYhi56RGMVHyy97BOKU/J6yHk9QjFdFW7twc Sb/g== X-Gm-Message-State: AOAM531V7hRxHQ3iNNzo6wrfagdYMS+Ol45w3506EUVNJCy+5blkOnvr fdUC4IQBLSzbSW+xlopKHWBdhMIPBY04lktxHAJX/XZpEnTxAUynZRP6ZLyICm06/ccNrs8QG5H 9RE5XkyW+LbQ= X-Received: by 2002:a05:622a:4295:b0:2f1:d202:8285 with SMTP id cr21-20020a05622a429500b002f1d2028285mr19593949qtb.378.1651675439062; Wed, 04 May 2022 07:43:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkt5+MsuoQ3G6H2oJR/ykPNQnfyDUoW1F0r0xjbPD7Sm3nUAtCuc7DRdbD7TpPXJJmc9H1zQ== X-Received: by 2002:a05:622a:4295:b0:2f1:d202:8285 with SMTP id cr21-20020a05622a429500b002f1d2028285mr19593925qtb.378.1651675438677; Wed, 04 May 2022 07:43:58 -0700 (PDT) Received: from localhost (c-73-227-130-153.hsd1.ma.comcast.net. [73.227.130.153]) by smtp.gmail.com with ESMTPSA id z28-20020a05620a08dc00b0069fd21d0b09sm5907577qkz.0.2022.05.04.07.43.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 May 2022 07:43:57 -0700 (PDT) From: Robbie Harwood To: Mathieu Desnoyers , Daniel Kiper , Vladimir 'phcoder' Serbinenko , grub-devel@gnu.org, Paul Menzel Cc: Mathieu Desnoyers Subject: Re: [PATCH v2] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items In-Reply-To: <20220503153812.991408-1-mathieu.desnoyers@efficios.com> References: <20220503153812.991408-1-mathieu.desnoyers@efficios.com> Date: Wed, 04 May 2022 10:43:54 -0400 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=170.10.129.124; envelope-from=rharwood@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 14:44:06 -0000 --=-=-= Content-Type: text/plain Mathieu Desnoyers writes: > +version_reverse_sort () > +{ > + case $version_reverse_sort_sort_has_v in Does this need to be its own variable, or could it just reuse version_sort_sort_has_v? > +reverse_sorted_list=$(echo $list | tr ' ' '\n' | sed 's/$/ 2/' | sed 's/\.old 2/ 1/' | version_reverse_sort | sed 's/ 1$/.old/' | sed 's/ 2$//') Could the `sed | sed` pattern be collapsed into a single invocation using multiple -e switches?1 Be well, --Robbie --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEA5qc6hnelQjDaHWqJTL5F2qVpEIFAmJykSoUHHJoYXJ3b29k QHJlZGhhdC5jb20ACgkQJTL5F2qVpEIHKQ//SgAi5VcgfrOajQoh+vpIFl7qw/UV IaCPKYnTIlWyCZXH7xPLyUSpE8+BrkZuPhQcupiZ/DLZydfgmVXrLtZRH14Kx20I eKOmbUvO5Kx01dEK/g/+JSbtQ0qBQU3LILizEg75/d0YHv+FRAx/oOfLLPndj7QV xoqbfMUk3SGycxfFTSirOmjEd9B/AcEGpjk5pfgrkY0TDoZYzy7kRvSey8PvR0OT YffDiPxDQBkVZOwkDLTrkVj4Lwp/zFHD7O7upY1lZENb5RX9wLdO07lv72cwEaGZ vekWbbdemXS/3zokoHwF7kRG5VxWneW/wWpoq64kG4lQw4W7ldUoAn4H7lN8CM4h lI/iXNR/TWw1bmAiTN7G9l92/bEaTjTl+XfNzf+o8yY96lA0PK/cr22TX/Wq473j HpJx2wajIQ1Id+3BE8NyBecWcfAdqTViKzGUa3punEglt/ry7EbDW2c7TOdyRhSC saCI0jYyyBVY50HJU7jtVhLxXsbh0HIut+jwVYGyCIX3bFgZu5ZcgVzvU0S9M4MN dAcP5gJoqCmv/rosJq4FcV+cAxrAtDjDClkfaPTzm3t1RmBlEFvW6a1+9HIzuTaY 2iS8SMtxzJg9mlXN+bB8/oDRWO10ZsYllapcv8Cx5qiVaMGq+7A4MU2Ta00+GKMX Txac70Up3f1Dsy0= =Sjb8 -----END PGP SIGNATURE----- --=-=-=--