All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bandan Das <bsd@redhat.com>
To: "Michael Rapoport" <RAPOPORT@il.ibm.com>
Cc: jiangshanlai@gmail.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, mst@redhat.com,
	Tejun Heo <tj@kernel.org>
Subject: Re: [RFC PATCH 0/4] cgroup aware workqueues
Date: Mon, 04 Apr 2016 13:00:12 -0400	[thread overview]
Message-ID: <jpg1t6ljomb.fsf@linux.bootlegged.copy> (raw)
In-Reply-To: <201604031043.u33AhpSF023771@d06av06.portsmouth.uk.ibm.com> (Michael Rapoport's message of "Sun, 3 Apr 2016 13:43:46 +0300")

...
>> There have been discussions about this in the past and iirc, most people 
> agree
>> about not going the byos* route. But I am still all for such a proposal 
> and if
>> it's good/clean enough, I think we can definitely tear down what we have 
> and
>> throw it away! The I/O scheduling part is intrusive enough that even the 
> current
>> code base has to be changed quite a bit.
>
> The "byos" route seems more promising with respect to possible performance 
> gains, but it will definitely add complexity, and I cannot say if the 
> added complexity will be worth performance improvements.
>
> Meanwhile, I'd suggest we better understand what causes regression with 
> your current patches and maybe then we'll be smarter to get to the right 
> direction. :)
>

Agreed, let's try to understand the cause of the "underperformance" with wqs.
I disabled WQ_CGROUPS that effectively disables my changes and I can still
consistently reproduce the lower numbers.

>> *byos = bring your own scheduling ;)
>> 
>> > Thanks.
>
> --
> Sincerely yours,
> Mike.
>
> [1] https://lwn.net/Articles/650857/ 

  parent reply	other threads:[~2016-04-04 17:00 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-18 22:14 [RFC PATCH 0/4] cgroup aware workqueues Bandan Das
2016-03-18 22:14 ` [RFC PATCH 1/4] cgroup: Introduce a function to compare two tasks Bandan Das
2016-03-18 22:14 ` [RFC PATCH 2/4] workqueue: introduce support for attaching to cgroups Bandan Das
2016-03-18 22:14 ` [RFC PATCH 3/4] cgroup: use spin_lock_irq for cgroup match and attach fns Bandan Das
2016-03-18 22:14 ` [RFC PATCH 4/4] vhost: use workqueues for the works Bandan Das
2016-03-20 18:10 ` [RFC PATCH 0/4] cgroup aware workqueues Tejun Heo
2016-03-21 17:35   ` Bandan Das
2016-03-21  7:58 ` Michael Rapoport
2016-03-21  7:58   ` Michael Rapoport
2016-03-21  7:58 ` Michael Rapoport
2016-03-21 17:43   ` Bandan Das
2016-03-22  7:12     ` vhost threading model (was: Re: [RFC PATCH 0/4] cgroup aware workqueues) Michael Rapoport
2016-03-22 19:00       ` vhost threading model Bandan Das
2016-03-23 11:13         ` Michael Rapoport
2016-03-23 11:13         ` Michael Rapoport
2016-03-22  7:12     ` vhost threading model (was: Re: [RFC PATCH 0/4] cgroup aware workqueues) Michael Rapoport
2016-03-22  7:12       ` Michael Rapoport
2016-03-21  8:29 ` [RFC PATCH 0/4] cgroup aware workqueues Christian Borntraeger
2016-03-21 17:49   ` Bandan Das
     [not found] ` <201603210758.u2L7wiY9003907@d06av07.portsmouth.uk.ibm.com>
2016-03-30 17:04   ` Tejun Heo
2016-03-31  6:17     ` Michael Rapoport
2016-03-31  6:17       ` Michael Rapoport
2016-03-31 17:14       ` Tejun Heo
2016-03-31 18:45         ` Bandan Das
2016-04-03 10:43           ` Michael Rapoport
2016-04-03 10:43           ` Michael Rapoport
2016-04-03 10:43             ` Michael Rapoport
     [not found]           ` <201604031043.u33AhpSF023771@d06av06.portsmouth.uk.ibm.com>
2016-04-04 17:00             ` Bandan Das [this message]
2016-04-03 10:43         ` Michael Rapoport
2016-04-03 10:43         ` Michael Rapoport
2016-05-27  9:22         ` Michael Rapoport
2016-05-27 14:17           ` Tejun Heo
2016-05-27  9:22         ` Michael Rapoport
2016-03-31  6:17     ` Michael Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jpg1t6ljomb.fsf@linux.bootlegged.copy \
    --to=bsd@redhat.com \
    --cc=RAPOPORT@il.ibm.com \
    --cc=jiangshanlai@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.