Re: [PATCH] KVM: make halt_poll_ns static

[Bandan Das <bsd@redhat.com>]

Christian Borntraeger <borntraeger@de.ibm.com> writes:

> halt_poll_ns is used only locally. Make it static.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  virt/kvm/kvm_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 34310a8..58bc2a9 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -66,7 +66,7 @@
>  MODULE_AUTHOR("Qumranet");
>  MODULE_LICENSE("GPL");
>  
> -unsigned int halt_poll_ns = 0;
> +static unsigned int halt_poll_ns = 0;

We should remove the initialization to zero. (Unfortunately,
the usage pattern throughout the kernel code is not constant..)

Bandan
>  module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR);
>  
>  /*