From: Bandan Das <bsd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based execution controls
Date: Fri, 17 Feb 2017 12:22:14 -0500 [thread overview]
Message-ID: <jpgd1eg20mx.fsf@linux.bootlegged.copy> (raw)
In-Reply-To: <372283237.23068299.1487320918001.JavaMail.zimbra@redhat.com> (Paolo Bonzini's message of "Fri, 17 Feb 2017 03:41:58 -0500 (EST)")
Paolo Bonzini <pbonzini@redhat.com> writes:
> ----- Original Message -----
>> From: "Bandan Das" <bsd@redhat.com>
>> To: "Paolo Bonzini" <pbonzini@redhat.com>
>> Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
>> Sent: Friday, February 17, 2017 1:04:14 AM
>> Subject: Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based execution controls
>>
>> Paolo Bonzini <pbonzini@redhat.com> writes:
>>
>> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> > ---
>>
>> I took a quick look and found these two potential
>> consumers of these set/clear wrappers.
>>
>> vmcs_set_secondary_exec_control()
>> vmx_set_virtual_x2apic_mode()
>>
>> Since this has been reviewed already,
>> we can just have them later in a follow up
>> (unless you left them out intentionally).
>
> Both of these can both set and clear bits, so they could be the
> consumer of a new function
>
> void vmcs_write_bits(u16 field, u32 value, u32 mask)
>
> but I don't see much benefit in introducing it; the cognitive
> load is higher than vmcs_{set,clear}_bits.
Yes, agreed. Thanks!
> Paolo
prev parent reply other threads:[~2017-02-17 17:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 14:44 [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based execution controls Paolo Bonzini
2017-02-16 16:24 ` Radim Krčmář
2017-02-16 19:22 ` David Hildenbrand
2017-02-17 0:04 ` Bandan Das
2017-02-17 8:41 ` Paolo Bonzini
2017-02-17 17:22 ` Bandan Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jpgd1eg20mx.fsf@linux.bootlegged.copy \
--to=bsd@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.