From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a36cK-0005Uv-Tx for qemu-devel@nongnu.org; Sun, 29 Nov 2015 13:22:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a36cH-0005ij-MP for qemu-devel@nongnu.org; Sun, 29 Nov 2015 13:22:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47585) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a36cH-0005if-HI for qemu-devel@nongnu.org; Sun, 29 Nov 2015 13:22:29 -0500 From: Bandan Das References: <1447939696-28930-1-git-send-email-mst@redhat.com> <1447939696-28930-8-git-send-email-mst@redhat.com> <565AED2E.4010404@gmail.com> Date: Sun, 29 Nov 2015 13:22:26 -0500 In-Reply-To: <565AED2E.4010404@gmail.com> (Marcel Apfelbaum's message of "Sun, 29 Nov 2015 14:18:54 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PULL 07/15] q35: Check propery to determine if iommu is set List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: marcel@redhat.com, Peter Maydell , qemu-devel@nongnu.org, "Michael S. Tsirkin" Hi Marcel, Marcel Apfelbaum writes: ... > > Maybe is too late, but this contradicts QEMU usage, as I understand Why late ? We can always revert it :) > object_property_get_* should be used when we don't know object's type. My understanding is that it's not mandatory to use it only when type is unknown. Ofcourse, it makes it redundant when you do know the type. I tend to follow convention, I noticed another call to qdev_get_machine, and so opted for this. I am actually ok either way and don't prefer one way over the other. > Why use "iommu" when you can simply call current_machine->iommu ? > (if you don't like the wrapper, which is pretty harmless in my opinion) > > Thanks, > Marcel > >> mch_init_dmar(mch); >> } >> } >>