From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47645)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bsd@redhat.com>) id 1ZuS6u-0003GV-HS
	for qemu-devel@nongnu.org; Thu, 05 Nov 2015 16:30:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bsd@redhat.com>) id 1ZuS6q-0006vr-HT
	for qemu-devel@nongnu.org; Thu, 05 Nov 2015 16:30:20 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36593)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bsd@redhat.com>) id 1ZuS6q-0006vm-Bp
	for qemu-devel@nongnu.org; Thu, 05 Nov 2015 16:30:16 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (Postfix) with ESMTPS id 1C935935DA
	for <qemu-devel@nongnu.org>; Thu,  5 Nov 2015 21:30:16 +0000 (UTC)
From: Bandan Das <bsd@redhat.com>
References: <1446595225-23608-1-git-send-email-bsd@redhat.com>
	<1446595225-23608-4-git-send-email-bsd@redhat.com>
	<1446712860.30393.11.camel@redhat.com>
Date: Thu, 05 Nov 2015 16:30:14 -0500
In-Reply-To: <1446712860.30393.11.camel@redhat.com> (Gerd Hoffmann's message
	of "Thu, 05 Nov 2015 09:41:00 +0100")
Message-ID: <jpgio5g3zix.fsf@linux.bootlegged.copy>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 3/3] usb-mtp: add support for basic mtp
	events
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann <kraxel@redhat.com> writes:

> On Di, 2015-11-03 at 19:00 -0500, Bandan Das wrote:
>> -            .wMaxPacketSize        = 8,
>> +            .wMaxPacketSize        = 64,
>
> This is a guest-visible change, so strictly speaking this needs be tied
> to the machine type.  I think we can be a bit sloppy here though as
> usb-mtp does not support live migration.

Makes sense. I will add a comment above then.

> cheers,
>   Gerd