All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bandan Das <bsd@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: kvm@vger.kernel.org
Subject: Re: APIC_ID in apic_reg_write()
Date: Wed, 29 Apr 2015 14:54:50 -0400	[thread overview]
Message-ID: <jpgiocen4sl.fsf@redhat.com> (raw)
In-Reply-To: <55412433.7080805@siemens.com> (Jan Kiszka's message of "Wed, 29 Apr 2015 20:34:27 +0200")

Jan Kiszka <jan.kiszka@siemens.com> writes:

> Am 2015-04-29 um 18:47 schrieb Bandan Das:
>> 
>> Why do we allow writes to APIC_ID ? On all _newer_ processors, it's
>> read only. The spec doesn't explicitly mention it though, or atleast
>> I couldn't find it. Does userspace have a reason to modify it ?
>
> The APIC ID is read-only for x2APIC. It remains R/W for xAPIC.

Are you sure ? In 10.4 of the SDM, there is Note that says
"In processors based on Intel microarchitecture code name Nehalem the Local APIC ID
Register is no longer Read/Write; it is Read Only."

And I can verify on a SandyBridge and Haswell system that it's RO there too.

In fact, that was one of the reasons I had submitted a patch to remove
verify_local_APIC() from x86/kernel/apic.c (4399c03c678) If I am wrong we need to
revert atleast the associated commit message :)

> Jan

  reply	other threads:[~2015-04-29 18:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-29 16:47 APIC_ID in apic_reg_write() Bandan Das
2015-04-29 18:34 ` Jan Kiszka
2015-04-29 18:54   ` Bandan Das [this message]
2015-04-29 19:07     ` Jan Kiszka
2015-04-29 22:21       ` Bandan Das
2015-04-30  5:40         ` Jan Kiszka
2015-04-30 16:50           ` Bandan Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jpgiocen4sl.fsf@redhat.com \
    --to=bsd@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.