From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bandan Das Subject: Re: [PATCH v2 1/4] KVM: x86: INIT and reset sequences are different Date: Tue, 07 Apr 2015 12:35:20 -0400 Message-ID: References: <1427933438-12782-1-git-send-email-namit@cs.technion.ac.il> <1427933438-12782-2-git-send-email-namit@cs.technion.ac.il> <5523DA6F.1050905@redhat.com> <55240439.4060103@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Cc: Nadav Amit , kvm@vger.kernel.org To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:48528 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753278AbbDGQfZ (ORCPT ); Tue, 7 Apr 2015 12:35:25 -0400 In-Reply-To: <55240439.4060103@redhat.com> (Paolo Bonzini's message of "Tue, 07 Apr 2015 18:22:17 +0200") Sender: kvm-owner@vger.kernel.org List-ID: Paolo Bonzini writes: > On 07/04/2015 18:17, Bandan Das wrote: >> > I think a bool argument is good enough. QEMU has different functions, >> > and init ends up doing save/reset/restore which is pretty ugly. >> >> Right, I meant that init could just be a wrapper so that it atleast shows up in >> a backtrace - could be helpful for debugging. > > I suspect that the compiler would inline any sensible implementation and > it wouldn't show up in the backtraces. :( noinline ? :) Anyway, it's probably not worth the trouble, that could be easily figured out. Thanks, Bandan > Paolo