From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47376)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bsd@redhat.com>) id 1ZuS5B-0002Db-8J
	for qemu-devel@nongnu.org; Thu, 05 Nov 2015 16:28:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bsd@redhat.com>) id 1ZuS57-0006QL-7f
	for qemu-devel@nongnu.org; Thu, 05 Nov 2015 16:28:33 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36241)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bsd@redhat.com>) id 1ZuS57-0006QG-2C
	for qemu-devel@nongnu.org; Thu, 05 Nov 2015 16:28:29 -0500
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (Postfix) with ESMTPS id 950C8935D1
	for <qemu-devel@nongnu.org>; Thu,  5 Nov 2015 21:28:28 +0000 (UTC)
From: Bandan Das <bsd@redhat.com>
References: <1446595225-23608-1-git-send-email-bsd@redhat.com>
	<1446595225-23608-3-git-send-email-bsd@redhat.com>
	<1446712667.30393.8.camel@redhat.com>
Date: Thu, 05 Nov 2015 16:28:27 -0500
In-Reply-To: <1446712667.30393.8.camel@redhat.com> (Gerd Hoffmann's message of
	"Thu, 05 Nov 2015 09:37:47 +0100")
Message-ID: <jpgmvus3zlw.fsf@linux.bootlegged.copy>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based
	file monitoring
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann <kraxel@redhat.com> writes:

>> +#include <sys/inotify.h>
>
> What happens on non-linux systems?
>
> I guess we need some #ifdefs to not break the build there, or enable mtp
> only for CONFIG_LINUX=y instead of CONFIG_POSIX=y.

Oh, I had the ifdefs but somehow I confused myself by thinking CONFIG_POSIX
is enough not to compile on non-linux systems. I guess I was only thinking
about Windows. I will add them back.

>> +enum inotify_event_type {
>> +    CREATE = 1,
>> +    DELETE = 2,
>> +    MODIFY = 3,
>> +};
>
> Patch #3 removes this, I'd suggest to extent "enum mtp_code" with the
> event codes here so we don't need this temporary thing.

Ok.

> cheers,
>   Gerd