From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bandan Das Subject: Re: [PATCH v2 1/4] KVM: x86: INIT and reset sequences are different Date: Tue, 07 Apr 2015 12:17:03 -0400 Message-ID: References: <1427933438-12782-1-git-send-email-namit@cs.technion.ac.il> <1427933438-12782-2-git-send-email-namit@cs.technion.ac.il> <5523DA6F.1050905@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Cc: Nadav Amit , kvm@vger.kernel.org To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:43506 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753929AbbDGQRK (ORCPT ); Tue, 7 Apr 2015 12:17:10 -0400 In-Reply-To: <5523DA6F.1050905@redhat.com> (Paolo Bonzini's message of "Tue, 07 Apr 2015 15:23:59 +0200") Sender: kvm-owner@vger.kernel.org List-ID: Paolo Bonzini writes: > On 02/04/2015 04:17, Bandan Das wrote: >>> > x86 architecture defines differences between the reset and INIT sequences. >>> > INIT does not initialize the FPU (including MMX, XMM, YMM, etc.), TSC, PMU, >>> > MSRs (in general), MTRRs machine-check, APIC ID, APIC arbitration ID and BSP. >>> > >>> > EFER is supposed NOT to be reset according to the SDM, but leaving the LMA and >>> > LME untouched causes failed VM-entry. Therefore we reset EFER (although it is >>> > unclear whether the rest of EFER bits should be reset). >> Thanks! This was actually in my todo list. #INIT and #RESET are actually separate pins >> on the processor. So, shouldn't we differentiate between the two too by having >> (*vcpu_init) and (*vcpu_reset) separate ? > > I think a bool argument is good enough. QEMU has different functions, > and init ends up doing save/reset/restore which is pretty ugly. Right, I meant that init could just be a wrapper so that it atleast shows up in a backtrace - could be helpful for debugging. > Paolo > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html