From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56919)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bsd@redhat.com>) id 1bNlgP-0000Ij-Dw
	for qemu-devel@nongnu.org; Thu, 14 Jul 2016 14:48:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bsd@redhat.com>) id 1bNlgJ-0007v4-FY
	for qemu-devel@nongnu.org; Thu, 14 Jul 2016 14:48:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59838)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bsd@redhat.com>) id 1bNlgJ-0007ux-9r
	for qemu-devel@nongnu.org; Thu, 14 Jul 2016 14:48:19 -0400
From: Bandan Das <bsd@redhat.com>
References: <20160714114956.GA5245@gmail.com>
	<1468506844.26657.21.camel@redhat.com>
Date: Thu, 14 Jul 2016 14:48:17 -0400
In-Reply-To: <1468506844.26657.21.camel@redhat.com> (Gerd Hoffmann's message
	of "Thu, 14 Jul 2016 16:34:04 +0200")
Message-ID: <jpgzipknjim.fsf@linux.bootlegged.copy>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] usb-mtp: added support for files larger
 than 4gb
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Isaac Lozano <109lozanoi@gmail.com>, qemu-devel@nongnu.org

Gerd Hoffmann <kraxel@redhat.com> writes:

> On Do, 2016-07-14 at 04:49 -0700, Isaac Lozano wrote:
>> Added support for sending data larger than 4gb.
>
>> Also implemented
>> object properties so that Windows can receive >4gb files.
>
> Can you please split those into two separate patches?
>
>> +    case PROP_PERSISTENT_UNIQUE_OBJECT_IDENTIFIER:
>> +        /* Should be persistant between sessions,
>> +         * but using our objedt ID is "good enough"
>> +         * for now */
>> +        usb_mtp_add_u64(d, 0x0000000000000000);
>> +        usb_mtp_add_u64(d, o->handle);
>> +        break;
>
> Maybe use the inode number here?

I think it was me who suggested putting in all 0s to him as more of a
todo task :) The inode number should work here.

> cheers,
>   Gerd