From: Cong Wang <xiyou.wangcong@gmail.com>
To: linux-mm@kvack.org
Subject: Re: [PATCH] mm/buddy: get the allownodes for dump at once
Date: Thu, 21 Jun 2012 09:03:53 +0000 (UTC) [thread overview]
Message-ID: <jruo1o$j9v$1@dough.gmane.org> (raw)
In-Reply-To: alpine.DEB.2.00.1206201815100.3702@chino.kir.corp.google.com
On Thu, 21 Jun 2012 at 01:19 GMT, David Rientjes <rientjes@google.com> wrote:
>
> show_free_areas() is called by the oom killer, so we know two things: it
> can be called potentially very deep in the callchain and current is out of
> memory. Both are killers for this patch since you're allocating
> nodemask_t on the stack here which could cause an overflow and because you
> can't easily fix that case with NODEMASK_ALLOC() since it allocates slab
> with GFP_KERNEL when we we're oom, which would simply suppress vital
> meminfo from being shown.
>
Adding a comment in the beginning of show_free_areas() would be nice,
to tell people not to allocate more memory either on stack or in heap.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-21 9:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 8:35 [PATCH] mm/buddy: get the allownodes for dump at once Gavin Shan
2012-06-18 2:57 ` Cong Wang
2012-06-18 3:13 ` Gavin Shan
2012-06-21 1:19 ` David Rientjes
2012-06-21 4:47 ` Gavin Shan
2012-06-21 5:13 ` David Rientjes
2012-06-21 5:16 ` Gavin Shan
2012-06-21 9:03 ` Cong Wang [this message]
2012-06-21 9:11 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='jruo1o$j9v$1@dough.gmane.org' \
--to=xiyou.wangcong@gmail.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.