All of lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Izard <romain.izard.pro@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Add /var/www to device table
Date: Mon, 2 Jul 2012 08:33:24 +0000 (UTC)	[thread overview]
Message-ID: <jsrmck$gt1$1@dough.gmane.org> (raw)
In-Reply-To: 1340654541-10427-1-git-send-email-spdawson@gmail.com

On 2012-06-25, spdawson at gmail.com <spdawson@gmail.com> wrote:
> From: Simon Dawson <spdawson@gmail.com>
>
> The /var/www directory is listed in /etc/passwd in the skeleton target
> filesystem as the home directory of the www-data user (uid 33).
>
> In the final target filesystem, /var/www should be owned by www-data. This
> is important for the lighttpd package, for example.
>
> Signed-off-by: Simon Dawson <spdawson@gmail.com>

Shouldn't it be changed by using a LIGHTTPD_PERMISSIONS variable,
instead of modifying the common device table ? This makes the
relationship more evident.

See the following example:
---

diff --git a/package/lighttpd/lighttpd.mk b/package/lighttpd/lighttpd.mk
index b8aa310..34f59b2 100644
--- a/package/lighttpd/lighttpd.mk
+++ b/package/lighttpd/lighttpd.mk
@@ -62,4 +62,9 @@ define LIGHTTPD_UNINSTALL_TARGET_CMDS
 	rm -rf $(TARGET_DIR)/usr/lib/lighttpd
 endef
 
+#<name>		<type>	<mode>	<uid>	<gid>	<major>	<minor>	<start>	<inc>	<count>
+define LIGHTTPD_PERMISSIONS
+var/www		d	755	33	33	-	-	-	-	-
+endef
+
 $(eval $(call AUTOTARGETS))

-- 
Romain Izard

  parent reply	other threads:[~2012-07-02  8:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-25 20:02 [Buildroot] [PATCH] Add /var/www to device table spdawson at gmail.com
2012-06-30 17:46 ` Arnout Vandecappelle
2012-07-09 12:51   ` Simon Dawson
2012-07-02  8:33 ` Romain Izard [this message]
2012-07-03  8:03   ` Thomas Petazzoni
  -- strict thread matches above, loose matches on Subject: below --
2012-07-09 12:51 spdawson at gmail.com
2012-07-09 20:04 ` Arnout Vandecappelle
2012-07-09 20:20   ` Simon Dawson
2012-07-09 20:20 spdawson at gmail.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='jsrmck$gt1$1@dough.gmane.org' \
    --to=romain.izard.pro@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.