From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoWYn-00062f-VL for qemu-devel@nongnu.org; Tue, 10 Jul 2012 05:16:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SoWYh-0003cl-88 for qemu-devel@nongnu.org; Tue, 10 Jul 2012 05:16:45 -0400 Received: from plane.gmane.org ([80.91.229.3]:43296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoWYh-0003cM-0l for qemu-devel@nongnu.org; Tue, 10 Jul 2012 05:16:39 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1SoWYb-0004yr-Kx for qemu-devel@nongnu.org; Tue, 10 Jul 2012 11:16:33 +0200 Received: from 93-34-189-113.ip51.fastwebnet.it ([93.34.189.113]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 10 Jul 2012 11:16:33 +0200 Received: from pbonzini by 93-34-189-113.ip51.fastwebnet.it with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 10 Jul 2012 11:16:33 +0200 From: Paolo Bonzini Date: Tue, 10 Jul 2012 11:16:19 +0200 Message-ID: References: <1341861429-6297-1-git-send-email-minyard@acm.org> <1341861429-6297-4-git-send-email-minyard@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit In-Reply-To: <1341861429-6297-4-git-send-email-minyard@acm.org> Subject: Re: [Qemu-devel] [PATCH 3/9] isa: Add a way to query for a free interrupt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Il 09/07/2012 21:17, minyard@acm.org ha scritto: > From: Corey Minyard > > This lets devices that don't care about their interrupt number, like > IPMI, just grab any unused interrupt. I would try to avoid this. It is too dependent on the actual initialization order and command line. Just pick a reasonable value for the interrupt (5?) and make it customizable. I only gave a cursory look at the series, but it looks really well done except for command-line parsing. I'll reply to the patches individually. Paolo