From: Cong Wang <xiyou.wangcong@gmail.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2 v5][resend] tmpfs: interleave the starting node of /dev/shmem
Date: Wed, 11 Jul 2012 05:50:51 +0000 (UTC) [thread overview]
Message-ID: <jtj47r$tb7$1@dough.gmane.org> (raw)
In-Reply-To: 1341845199-25677-3-git-send-email-nzimmer@sgi.com
On Mon, 09 Jul 2012 at 14:46 GMT, Nathan Zimmer <nzimmer@sgi.com> wrote:
> +static unsigned long shmem_interleave(struct vm_area_struct *vma,
> + unsigned long addr)
> +{
> + unsigned long offset;
> +
> + /* Use the vm_files prefered node as the initial offset. */
> + offset = (unsigned long *) vma->vm_private_data;
> +
offset is 'unsigned long', but here you cast ->private_data to 'unsigned
long *'?? Please test your patches before posting.
Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-07-11 5:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 14:46 [PATCH 0/2 v5][resend] tmpfs not interleaving properly Nathan Zimmer
2012-07-09 14:46 ` Nathan Zimmer
2012-07-09 14:46 ` [PATCH 1/2 v5][resend] shmem: provide vm_ops when also providing a mem policy Nathan Zimmer
2012-07-09 14:46 ` Nathan Zimmer
2012-07-09 14:46 ` [PATCH 2/2 v5][resend] tmpfs: interleave the starting node of /dev/shmem Nathan Zimmer
2012-07-09 14:46 ` Nathan Zimmer
2012-07-11 5:50 ` Cong Wang [this message]
2012-07-23 10:58 ` Dan Carpenter
2012-07-23 10:58 ` Dan Carpenter
2012-07-23 19:26 ` Nathan Zimmer
2012-07-23 19:26 ` Nathan Zimmer
2012-07-25 4:38 ` Hugh Dickins
2012-07-25 4:38 ` Hugh Dickins
2012-07-25 14:58 ` KOSAKI Motohiro
2012-07-25 14:58 ` KOSAKI Motohiro
2012-07-25 16:15 ` Nathan Zimmer
2012-07-25 16:15 ` Nathan Zimmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='jtj47r$tb7$1@dough.gmane.org' \
--to=xiyou.wangcong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.