All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ola x Nilsson <ola.x.nilsson@axis.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: <olani@axis.com>, <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] ffmpeg: Package example files in ffmpeg-examples
Date: Mon, 28 Oct 2024 08:34:58 +0100	[thread overview]
Message-ID: <jwq5xpck7dp.fsf@axis.com> (raw)
In-Reply-To: <CA+chaQfU4r3funtCDVafY67z3CM-wkMYQ7jXH9F+sD5Pi06fvA@mail.gmail.com> (Martin Jansa's message of "Sun, 27 Oct 2024 18:19:54 +0100")


Looks good to me.

/Ola

On Sun, Oct 27 2024, Martin Jansa wrote:

> Wasn't very future proof for multilib :) please review:
> https://lists.openembedded.org/g/openembedded-core/message/206410
>
> On Tue, Aug 27, 2024 at 11:02 AM Ola x Nilsson via
> lists.openembedded.org <olani=axis.com@lists.openembedded.org> wrote:
>>
>> From: Ola x Nilsson <olani@axis.com>
>>
>> The most future proof way to not always ship the example files is to
>> package them separately.
>>
>> Signed-off-by: Ola x Nilsson <olani@axis.com>
>> ---
>>  meta/recipes-multimedia/ffmpeg/ffmpeg_6.1.1.bb | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-multimedia/ffmpeg/ffmpeg_6.1.1.bb b/meta/recipes-multimedia/ffmpeg/ffmpeg_6.1.1.bb
>> index fe34b87ccf..55313cc583 100644
>> --- a/meta/recipes-multimedia/ffmpeg/ffmpeg_6.1.1.bb
>> +++ b/meta/recipes-multimedia/ffmpeg/ffmpeg_6.1.1.bb
>> @@ -170,7 +170,8 @@ PACKAGES =+ "libavcodec \
>>               libavutil \
>>               libpostproc \
>>               libswresample \
>> -             libswscale"
>> +             libswscale \
>> +             ${PN}-examples"
>>
>>  FILES:libavcodec = "${libdir}/libavcodec${SOLIBS}"
>>  FILES:libavdevice = "${libdir}/libavdevice${SOLIBS}"
>> @@ -180,6 +181,7 @@ FILES:libavutil = "${libdir}/libavutil${SOLIBS}"
>>  FILES:libpostproc = "${libdir}/libpostproc${SOLIBS}"
>>  FILES:libswresample = "${libdir}/libswresample${SOLIBS}"
>>  FILES:libswscale = "${libdir}/libswscale${SOLIBS}"
>> +FILES:${PN}-examples = "${datadir}/${PN}/examples"
>>
>>  # ffmpeg disables PIC on some platforms (e.g. x86-32)
>>  INSANE_SKIP:${MLPREFIX}libavcodec = "textrel"
>> --
>> 2.39.2
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#203818): https://lists.openembedded.org/g/openembedded-core/message/203818
>> Mute This Topic: https://lists.openembedded.org/mt/108120002/3617156
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [martin.jansa@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>


      reply	other threads:[~2024-10-28  7:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-27  9:02 [PATCH] ffmpeg: Package example files in ffmpeg-examples olani
2024-10-27 17:19 ` [OE-core] " Martin Jansa
2024-10-28  7:34   ` Ola x Nilsson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwq5xpck7dp.fsf@axis.com \
    --to=ola.x.nilsson@axis.com \
    --cc=martin.jansa@gmail.com \
    --cc=olani@axis.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.