All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ola x Nilsson" <ola.x.nilsson@axis.com>
To: "douglas.royds@taitradio.com" <douglas.royds@taitradio.com>
Cc: Douglas via lists.openembedded.org
	<douglas.royds=taitradio.com@lists.openembedded.org>,
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] externalsrc: No single-task lock if S != B
Date: Fri, 9 Oct 2020 08:36:02 +0200	[thread overview]
Message-ID: <jwqv9fjlxd9.fsf@axis.com> (raw)
In-Reply-To: <CAFimOt5fQ=0JKpteCCAbDg14u-itABV7MEULuQEm3dUTFj89Lg@mail.gmail.com>



On Fri, Oct 09 2020, Douglas via lists.openembedded.org wrote:

> Allow different recipes to build things from the one external source tree in
> parallel, but only if the build is happening outside the source tree.
>
> Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
> ---
> meta/classes/externalsrc.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/externalsrc.bbclass
> b/meta/classes/externalsrc.bbclass
> index d200129987..73bbb2be3c 100644
> --- a/meta/classes/externalsrc.bbclass
> +++ b/meta/classes/externalsrc.bbclass
> @@ -85,7 +85,7 @@ python () {
> if task.endswith("_setscene"):
> # sstate is never going to work for external source trees, disable it
> bb.build.deltask(task, d)
> - else:
> + elif externalsrc == externalsrcbuild:

If any of the paths contain a symlink they can point to the same dir
without being textually equal.  You need to normalize them first.

/Ola


  reply	other threads:[~2020-10-09  6:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-09  5:31 [PATCH] externalsrc: No single-task lock if S != B Douglas
2020-10-09  6:36 ` Ola x Nilsson [this message]
2020-10-12  0:07 ` Douglas
2020-10-12  1:31 ` [PATCH v2] " Douglas Royds
2020-10-12 18:12   ` [OE-core] " Richard Purdie
2020-10-13  0:48 ` [PATCH v3] " Douglas Royds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwqv9fjlxd9.fsf@axis.com \
    --to=ola.x.nilsson@axis.com \
    --cc=douglas.royds=taitradio.com@lists.openembedded.org \
    --cc=douglas.royds@taitradio.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.