All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: Karl Mehltretter <kmehltretter@gmail.com>,
	Madhavan Srinivasan <maddy@linux.ibm.com>
Cc: Karl Mehltretter <kmehltretter@gmail.com>,
	Haren Myneni <haren@us.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	linuxppc-dev@lists.ozlabs.org, Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org, Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH v2] docs: powerpc: vas-api: Fix the structure name and the ioctl number in the example
Date: Mon, 07 Sep 2026 08:37:19 +0530	[thread overview]
Message-ID: <jyox21zs.ritesh.list@gmail.com> (raw)
In-Reply-To: <20260907004925.10948-1-kmehltretter@gmail.com>

Karl Mehltretter <kmehltretter@gmail.com> writes:

> struct vas_setup_attr does not exist; the name is struct
> vas_tx_win_open_attr. The example also defines VAS_TX_WIN_OPEN with the
> request number 1, while arch/powerpc/include/uapi/asm/vas-api.h has used
> 0x20 since the ioctl was added.
>
> Use struct vas_tx_win_open_attr and 0x20.
>
> Fixes: c12e38b1d52e ("Documentation/powerpc: VAS API")
> Suggested-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
> v2: also fix the ioctl request number in the example (Ritesh)
> v1: https://lore.kernel.org/r/20260905104313.43620-1-kmehltretter@gmail.com/
>
>  Documentation/arch/powerpc/vas-api.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks for fixing the ioctl number too and sending a v2.
LGTM. Please feel free to add:

Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>

      reply	other threads:[~2026-09-07  3:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07  0:49 [PATCH v2] docs: powerpc: vas-api: Fix the structure name and the ioctl number in the example Karl Mehltretter
2026-09-07  3:07 ` Ritesh Harjani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jyox21zs.ritesh.list@gmail.com \
    --to=ritesh.list@gmail.com \
    --cc=corbet@lwn.net \
    --cc=haren@us.ibm.com \
    --cc=kmehltretter@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.