Re: [PATCH v2 3/3] powerpc: Kconfig: Enable THP_SWAP on Book3S64

[Ritesh Harjani (IBM) <ritesh.list@gmail.com>]

kernel test robot <lkp@intel.com> writes:

> Hi Ritesh,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on akpm-mm/mm-everything]
> [also build test WARNING on linux-review/Ritesh-Harjani-IBM/include-linux-swap-h-Remove-unused-leftovers/20260611-111124 next-20260611]
> [cannot apply to powerpc/next powerpc/fixes linus/master v7.1-rc7]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Ritesh-Harjani-IBM/mm-swap-make-SWAPFILE_CLUSTER-runtime/20260611-181121
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
> patch link:    https://lore.kernel.org/r/3abf510d24c8ef17bd5e324cccc5e03e548afade.1781170904.git.ritesh.list%40gmail.com
> patch subject: [PATCH v2 3/3] powerpc: Kconfig: Enable THP_SWAP on Book3S64
> config: arm64-randconfig-r133-20260611 (https://download.01.org/0day-ci/archive/20260612/202606121305.h0cxjhP2-lkp@intel.com/config)
> compiler: aarch64-linux-gcc (GCC) 8.5.0
> sparse: v0.6.5-rc1
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260612/202606121305.h0cxjhP2-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202606121305.h0cxjhP2-lkp@intel.com/
>
> sparse warnings: (new ones prefixed by >>)
>>> mm/swapfile.c:133:6: sparse: sparse: symbol 'swap_table_use_page' was not declared. Should it be static?
>
> vim +/swap_table_use_page +133 mm/swapfile.c
>
>    131	
>    132	unsigned int swap_slots_in_cluster __read_mostly;
>  > 133	bool swap_table_use_page __read_mostly;
>    134	

I had noticed this after sending the v2. But by then it was late.
Good that the sparse checker caught it.

So, I will declare this variable as static - that should fix the
sparse warning. I will spin a v3 in sometime with this fixed.

-ritesh