From: Koen Kooi <koen@dominion.thruhere.net>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH 2/2] meta-networking: stylize dnsmasq recipe
Date: Mon, 03 Sep 2012 08:06:59 +0200 [thread overview]
Message-ID: <k21he4$npr$1@ger.gmane.org> (raw)
In-Reply-To: <1346633420-10990-3-git-send-email-joe.macdonald@windriver.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Op 03-09-12 02:50, Joe MacDonald schreef:
> Signed-off-by: Joe MacDonald <joe.macdonald@windriver.com> ---
> .../recipes-daemons/dnsmasq/dnsmasq-dbus_2.55.bb | 10
> +++++----- meta-networking/recipes-daemons/dnsmasq/dnsmasq.inc |
> 14 +++++++------- meta-networking/recipes-daemons/dnsmasq/dnsmasq_2.55.bb
> | 3 ++- 3 files changed, 14 insertions(+), 13 deletions(-)
>
> diff --git a/meta-networking/recipes-daemons/dnsmasq/dnsmasq-dbus_2.55.bb
> b/meta-networking/recipes-daemons/dnsmasq/dnsmasq-dbus_2.55.bb index
> 896952d..5c4500f 100644 ---
> a/meta-networking/recipes-daemons/dnsmasq/dnsmasq-dbus_2.55.bb +++
> b/meta-networking/recipes-daemons/dnsmasq/dnsmasq-dbus_2.55.bb @@ -1,13
> +1,13 @@ # dnsmasq with support for DBus interface - -require
> dnsmasq_${PV}.bb +DEPENDS = "dbus"
>
> S = "${WORKDIR}/dnsmasq-${PV}"
>
> -DEPENDS = "dbus" EXTRA_OEMAKE = "COPTS=-DHAVE_DBUS"
>
> do_install_append () { - install -d
> ${D}${sysconfdir}/dbus-1/system.d - install -m 644
> dbus/dnsmasq.conf ${D}${sysconfdir}/dbus-1/system.d/ + install -d
> ${D}${sysconfdir}/dbus-1/system.d + install -m 644 dbus/dnsmasq.conf
> ${D}${sysconfdir}/dbus-1/system.d/ } + +require dnsmasq_${PV}.bb
The require should remain on top by the looks of it
> diff --git a/meta-networking/recipes-daemons/dnsmasq/dnsmasq.inc
> b/meta-networking/recipes-daemons/dnsmasq/dnsmasq.inc index
> e994852..3c87abf 100644 ---
> a/meta-networking/recipes-daemons/dnsmasq/dnsmasq.inc +++
> b/meta-networking/recipes-daemons/dnsmasq/dnsmasq.inc @@ -17,13 +17,13 @@
> INITSCRIPT_NAME = "dnsmasq" INITSCRIPT_PARAMS = "defaults"
>
> do_install () { - oe_runmake "PREFIX=${D}${prefix}" \ -
> "BINDIR=${D}${bindir}" \ - "MANDIR=${D}${mandir}" \ -
> install - install -d ${D}${sysconfdir}/ ${D}${sysconfdir}/init.d
> ${D}${sysconfdir}/dnsmasq.d - install -m 644
> ${WORKDIR}/dnsmasq.conf ${D}${sysconfdir}/ - install -m 755
> ${WORKDIR}/init ${D}${sysconfdir}/init.d/dnsmasq + oe_runmake
> "PREFIX=${D}${prefix}" \ + "BINDIR=${D}${bindir}" \ +
> "MANDIR=${D}${mandir}" \ + install + install -d
> ${D}${sysconfdir}/ ${D}${sysconfdir}/init.d ${D}${sysconfdir}/dnsmasq.d +
> install -m 644 ${WORKDIR}/dnsmasq.conf ${D}${sysconfdir}/ + install -m
> 755 ${WORKDIR}/init ${D}${sysconfdir}/init.d/dnsmasq }
>
> CONFFILES_${PN} = "${sysconfdir}/dnsmasq.conf" diff --git
> a/meta-networking/recipes-daemons/dnsmasq/dnsmasq_2.55.bb
> b/meta-networking/recipes-daemons/dnsmasq/dnsmasq_2.55.bb index
> 5f87704..e98f61c 100644 ---
> a/meta-networking/recipes-daemons/dnsmasq/dnsmasq_2.55.bb +++
> b/meta-networking/recipes-daemons/dnsmasq/dnsmasq_2.55.bb @@ -1,4 +1,5
> @@ -require dnsmasq.inc
>
> SRC_URI[dnsmasq-2.55.md5sum] = "b093d7c6bc7f97ae6fd35d048529232a"
> SRC_URI[dnsmasq-2.55.sha256sum] =
> "cf63ecf5977f00474cbda98376a9d8743500a82fd98e13f43d7037bce9f9f929" +
> +require dnsmasq.inc
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org
iD8DBQFQREkDMkyGM64RGpERAlR8AKC4IFFZEdpWSKGRXgSmXbIkALNU0QCePCWY
Es2gc0ph/ZPH/Kqcmg7syrM=
=EbfW
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-09-03 6:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 0:50 [meta-oe][meta-networking] Migrate dnsmasq Joe MacDonald
2012-09-03 0:50 ` [meta-oe][PATCH 1/2] meta-networking: Migrate dnsmasq into meta-networking Joe MacDonald
2012-09-03 0:50 ` [meta-oe][PATCH 2/2] meta-networking: stylize dnsmasq recipe Joe MacDonald
2012-09-03 6:06 ` Koen Kooi [this message]
2012-09-03 6:09 ` [meta-oe][PATCH 1/2] meta-networking: Migrate dnsmasq into meta-networking Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='k21he4$npr$1@ger.gmane.org' \
--to=koen@dominion.thruhere.net \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.