From: Tom Herbert <therbert@google.com>
To: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org, aabdulla@nvidia.com, davem@davemloft.net
Subject: Re: [PATCH] forcedeth: Stay in NAPI as long as there's work
Date: Wed, 28 Apr 2010 11:18:02 -0700 [thread overview]
Message-ID: <k2w65634d661004281118t9fd212fbs8afc3a115bfffdea@mail.gmail.com> (raw)
In-Reply-To: <g2t65634d661004281107j676369c9ge379434723478c1@mail.gmail.com>
On Wed, Apr 28, 2010 at 11:07 AM, Tom Herbert <therbert@google.com> wrote:
>>
>> It might be better to test the comparisons using
>> a cpu_to_le32 of the constants.
>>
> Yes. Probably should also be changed in nv_tx_done{_optimized} and
> nv_rx_process{_optimized}
>
Scratch that. flags are checked all over the place in those other functions.
>> static inline int nv_has_work(struct fe_priv *np)
>> {
>> if (nv_optimized(np))
>> return ((np->get_rx.ex != np->put_rx.ex) &&
>> !(np->get_rx.ex->flaglen & cpu_to_le32(NV_RX2_AVAIL))) ||
>> ((np->get_tx.ex != np->put_tx.ex) &&
>> !(np->get_tx.ex->flaglen & cpu_to_le32(NV_TX_VALID)));
>>
>> return ((np->get_rx.orig != np->put_rx.orig) &&
>> !(np->get_rx.orig->flaglen & cpu_to_le32(NV_RX_AVAIL))) ||
>> ((np->get_tx.orig != np->put_tx.orig) &&
>> !(np->get_tx.orig->flaglen & cpu_to_le32(NV_TX_VALID)));
>> }
>>
>>
>>
>
next prev parent reply other threads:[~2010-04-28 18:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-28 6:36 [PATCH] forcedeth: Stay in NAPI as long as there's work Tom Herbert
2010-04-28 17:54 ` Joe Perches
2010-04-28 18:07 ` Tom Herbert
2010-04-28 18:18 ` Tom Herbert [this message]
2010-04-28 18:13 ` Stephen Hemminger
2010-04-28 18:25 ` Stephen Hemminger
2010-04-28 21:25 ` David Miller
2010-04-28 23:56 ` Tom Herbert
2010-04-30 23:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=k2w65634d661004281118t9fd212fbs8afc3a115bfffdea@mail.gmail.com \
--to=therbert@google.com \
--cc=aabdulla@nvidia.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.