From: "Joachim Schmitz" <jojo@schmitz-digital.de>
To: git@vger.kernel.org
Subject: Re: [PATCH] Completion must sort before using uniq
Date: Fri, 23 Nov 2012 09:09:55 +0100 [thread overview]
Message-ID: <k8nb0t$2pf$1@ger.gmane.org> (raw)
In-Reply-To: CAFj1UpF2wh0imcqW7Ez_J14R_07a_A1-YWESaGrHRNa7Nsv-xg@mail.gmail.com
Marc Khouzam wrote:
> The uniq program only works with sorted input. The man page states
> "uniq prints the unique lines in a sorted file".
...
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -321,7 +321,7 @@ __git_refs ()
> if [[ "$ref" == "$cur"* ]]; then
> echo "$ref"
> fi
> - done | uniq -u
> + done | sort | uniq -u
Is 'sort -u' not universally available and sufficient here? It is POSIX at
least:
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/sort.html
Bye, Jojo
next prev parent reply other threads:[~2012-11-23 8:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1353557598-4820-1-git-send-email-marc.khouzam@gmail.com>
2012-11-22 4:16 ` [PATCH] Completion must sort before using uniq Marc Khouzam
2012-11-23 8:09 ` Joachim Schmitz [this message]
2012-11-23 8:21 ` Felipe Contreras
2012-11-23 11:17 ` [PATCH v2] " Marc Khouzam
2012-11-23 11:34 ` Felipe Contreras
2012-11-23 14:02 ` [PATCH v3] " Marc Khouzam
2012-11-23 19:21 ` Felipe Contreras
2012-11-25 6:32 ` Junio C Hamano
[not found] <002201cdc952$00159c90$0040d5b0$@schmitz-digital.de>
[not found] ` <CAFj1UpEMKq9zH3nbLwYrNZRmd52_KEcN5BBrzGg2jxCzd+fsbA@mail.gmail.com>
2012-11-23 12:15 ` [PATCH] " Joachim Schmitz
2012-11-23 12:26 ` Sascha Cunz
2012-11-23 12:36 ` Joachim Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='k8nb0t$2pf$1@ger.gmane.org' \
--to=jojo@schmitz-digital.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.