All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: core: fix unused variable sparse warning
Date: Fri, 7 Dec 2012 02:26:39 +0000 (UTC)	[thread overview]
Message-ID: <k9rk4v$icm$1@ger.gmane.org> (raw)
In-Reply-To: 1354838913-20084-1-git-send-email-dinggnu@gmail.com

On Fri, 07 Dec 2012 at 00:06 GMT, Cong Ding <dinggnu@gmail.com> wrote:
> the variables zero and unres_qlen_max are only used when CONFIG_SYSCTL is
> defined, otherwise it causes the following sparse warning when we turn on
> CONFIG_SYSCTL.
>

commit b93196dc5af7729ff7cc50d3d322ab1a364aa14f
Author: Cong Wang <amwang@redhat.com>
Date:   Thu Dec 6 10:04:04 2012 +0800

    net: fix some compiler warning in net/core/neighbour.c
        
    net/core/neighbour.c:65:12: warning: 'zero' defined but
not used [-Wunused-variable]
    net/core/neighbour.c:66:12: warning: 'unres_qlen_max' defined but
not used [-Wunused-variable]
    
    These variables are only used when CONFIG_SYSCTL is defined,
    so move them under #ifdef CONFIG_SYSCTL.
	        
    Reported-by: Fengguang Wu <fengguang.wu@intel.com>
    Signed-off-by: Cong Wang <amwang@redhat.com>
    Acked-by: Shan Wei <davidshan@tencent.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>


      parent reply	other threads:[~2012-12-07  2:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-07  0:06 [PATCH] net: core: fix unused variable sparse warning Cong Ding
2012-12-07  0:15 ` Cong Ding
2012-12-07  3:25   ` David Miller
2012-12-07  3:25     ` David Miller
2012-12-07 10:45   ` Shan Wei
2012-12-07  2:26 ` Cong Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='k9rk4v$icm$1@ger.gmane.org' \
    --to=xiyou.wangcong@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.